From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>
Subject: [PATCH v2 0/4] Improve fio max open zones handling
Date: Fri, 14 May 2021 12:52:50 +0000 [thread overview]
Message-ID: <20210514125233.10508-1-Niklas.Cassel@wdc.com> (raw)
From: Niklas Cassel <niklas.cassel@wdc.com>
Improve max open zones handling by introducing a new IO engine operation,
which can be implemented by ioengines.
Also provide a default implementation for Linux, which parses sysfs for
the max open zones value.
Update libzbc ioengine to utilize the new callback.
Having this callback has the two following advantages:
1) If the user forgets to specify a --max_open_zones value, we will
automatically use the maximum the drive supports.
(Instead of getting errors because fio tries to open too many zones.)
2) If the user specifies a --max_open_zones value that is too big,
we will return an error and fio will exit with a proper error message.
(Instead of getting errors because fio tries to open too many zones.)
Changes since v1:
-Fixed all review comments from Damien, except the unconditional logging,
I still think that a debug print is sufficient.
-Picked up Reviewed-by tag by Damien on patch 4/4.
Niklas Cassel (4):
zbd: only put an upper limit on max open zones once
oslib/linux-blkzoned: move sysfs reading into its own function
ioengines: add get_max_open_zones zoned block device operation
engines/libzbc: add support for the get_max_open_zones io op
engines/libzbc.c | 21 +++++++++
engines/skeleton_external.c | 13 ++++++
ioengines.h | 4 +-
oslib/blkzoned.h | 7 +++
oslib/linux-blkzoned.c | 83 ++++++++++++++++++++++++---------
zbd.c | 91 ++++++++++++++++++++++++++++++++++---
6 files changed, 190 insertions(+), 29 deletions(-)
--
2.25.1
next reply other threads:[~2021-05-14 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 12:52 Niklas Cassel [this message]
2021-05-14 12:52 ` [PATCH v2 1/4] zbd: only put an upper limit on max open zones once Niklas Cassel
2021-05-14 12:52 ` [PATCH v2 2/4] oslib/linux-blkzoned: move sysfs reading into its own function Niklas Cassel
2021-05-14 12:53 ` [PATCH v2 3/4] ioengines: add get_max_open_zones zoned block device operation Niklas Cassel
2021-05-14 12:53 ` [PATCH v2 4/4] engines/libzbc: add support for the get_max_open_zones io op Niklas Cassel
2021-05-14 14:57 ` [PATCH v2 0/4] Improve fio max open zones handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514125233.10508-1-Niklas.Cassel@wdc.com \
--to=niklas.cassel@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.