From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ABEBDC433B4
	for <netdev@archiver.kernel.org>; Sat, 15 May 2021 00:22:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 791BC613C1
	for <netdev@archiver.kernel.org>; Sat, 15 May 2021 00:22:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233856AbhEOAXL (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 14 May 2021 20:23:11 -0400
Received: from mail.kernel.org ([198.145.29.99]:40060 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229898AbhEOAXL (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 14 May 2021 20:23:11 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id B208A61370;
        Sat, 15 May 2021 00:21:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1621038119;
        bh=tTpKD4IrDTTlTh3tvZ6y0j4FaUTzFOPQo5RePfZzqPU=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=PXpB2DanK7yS+7WEEYFQgFsbUtRbheVJzny0iMNoVzXQ3aM5l443/PrNSM92VA3nn
         ERE79adepwN5grt59KgDkUvpPLCDXR6e43GX0l+gfBXqNa76vA1rHK4SNJAK1EkaKe
         HV0WVki9CZlXUDHqvCt6op7f3PwncIeXUGjRvE86s0hhcCnfsIv3wb0skH3ZBgF53l
         ekFjG3WCYwgYYoT5MdyMUKlgvYgtLvl6jPANmrXLjZZh/nyyWM+ZzsyK0sJXT1mqXy
         ioV3+0zefmniPGzbJfwBb+eCgtiK6AakUd2nngHRJITo/KoWoaGJxsQRY+RkHmomil
         GnE82eDDGcApA==
Date:   Fri, 14 May 2021 17:21:57 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     davem@davemloft.net, netdev@vger.kernel.org,
        eric.dumazet@gmail.com, simon.horman@netronome.com,
        oss-drivers@netronome.com, bigeasy@linutronix.de
Subject: Re: [PATCH net-next 1/2] net: add a napi variant for
 RT-well-behaved drivers
Message-ID: <20210514172157.7af29448@kicinski-fedora-PC1C0HJN>
In-Reply-To: <87y2cg26kx.ffs@nanos.tec.linutronix.de>
References: <20210514222402.295157-1-kuba@kernel.org>
        <87y2cg26kx.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sat, 15 May 2021 02:17:50 +0200 Thomas Gleixner wrote:
> On Fri, May 14 2021 at 15:24, Jakub Kicinski wrote:
> >  
> > +void __napi_schedule_irq(struct napi_struct *n)
> > +{
> > +	____napi_schedule(this_cpu_ptr(&softnet_data), n);  
> 
> Not that I have any clue, but why does this not need the
> napi_schedule_prep() check?

napi_schedule_prep() is in the non-__ version in linux/netdevice.h:

static inline void napi_schedule_irq(struct napi_struct *n)
{
	if (napi_schedule_prep(n))
		__napi_schedule_irq(n);
}