All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nishanth Menon" <nm@ti.com>
To: Yogesh Siraswar <yogeshs@ti.com>,
	<meta-ti@lists.yoctoproject.org>, <denys@konsulko.com>,
	<praneeth@ti.com>
Subject: Re: [meta-ti][dunfell/master][PATCH] linux-ti-staging: Added DTC_FLAG to Kernel argument to build dtbs with symbols
Date: Fri, 14 May 2021 14:26:15 -0500	[thread overview]
Message-ID: <20210514192615.5fwrfs2muos5t2c3@ascertain> (raw)
In-Reply-To: <167EFB30FCA6D486.24136@lists.yoctoproject.org>

On 11:18-20210514, Nishanth Menon via lists.yoctoproject.org wrote:
> On 20:21-20210513, Yogesh Siraswar wrote:

[...]

> 
> >  16 files changed, 137 insertions(+), 1 deletion(-)
> > 
> > diff --git a/conf/machine/am335x-evm.conf b/conf/machine/am335x-evm.conf
> > index 469c4d37..dc50e686 100644
> > --- a/conf/machine/am335x-evm.conf
> > +++ b/conf/machine/am335x-evm.conf
> > @@ -13,6 +13,15 @@ IMAGE_FSTYPES += "ubifs ubi"
> >  SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS3"
> >  SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
> >  
> > +#Add DTC_FLAGS to compile DTB with symbols.
> > +#Weak assignment so that can be over-written with
> > +#EXTRA_DTC_FLAGS = "" in local.conf
> 
> We dont need this comment every where, do we?
> > +
> > +EXTRA_DTC_FLAGS ?= "DTC_FLAGS=-@"
> > +
> > +KERNEL_EXTRA_ARGS += "${EXTRA_DTC_FLAGS}"
> 
> Should'nt this be in a common file
> [...]


Thinking again - should we make this a little easier in case the future
dtc needs more flags?

a) KERNEL_HAS_OVERLAYS as a single variable defined in machine.confs
b) ti-kernel.inc which introduces KERNEL_EXTRA_ARGS in the style above
(extra_dtc_flags...)
c) include ti-kernel.inc in mainline-linux and linux-ti-staging?

[...]


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

      parent reply	other threads:[~2021-05-14 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210514012143.7094-1-yogeshs@ti.com>
2021-05-14 16:18 ` [meta-ti][dunfell/master][PATCH] linux-ti-staging: Added DTC_FLAG to Kernel argument to build dtbs with symbols Nishanth Menon
     [not found] ` <167EFB30FCA6D486.24136@lists.yoctoproject.org>
2021-05-14 19:26   ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514192615.5fwrfs2muos5t2c3@ascertain \
    --to=nm@ti.com \
    --cc=denys@konsulko.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=praneeth@ti.com \
    --cc=yogeshs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.