From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8986C433B4 for ; Fri, 14 May 2021 13:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C58AA61442 for ; Fri, 14 May 2021 13:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233925AbhENNVW (ORCPT ); Fri, 14 May 2021 09:21:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:52500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhENNVV (ORCPT ); Fri, 14 May 2021 09:21:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4C8061451; Fri, 14 May 2021 13:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620998410; bh=vmjZo5FsCOZVRQUnwKI9G8xEtugt5u8YaX+YGYflkls=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jNMsbpAlj8goNw+JaeL09CUCLqsHDlRhYHacbNpKYUh891WEyRj31HUQlhGIYaQNO sj+IV9dHjH7YMQ3289I8i9FlqopA6muGZvoF1Y2riXJkH5TCZmjEIqkbY5hfU8Jzxn ba0mDgS3bffwhZcJnuvJIx1UkYUovTI2b/84Lmy4cRjoQkUPrRP/Mzdnql1QmE34IV YgVAfjme+pO/GTnFG/EI4jadvWsccEC67SMAxGCwtUJRzob85B/WIbnNZfISGswQ/q YD/oK8LGpiDGIocG9Sx9yPBpZQeAXj50/2/aHWmgA/2Es0wffjT15z8sAgCXTiTMyQ ybFjhzphVmLQw== Date: Fri, 14 May 2021 22:20:04 +0900 From: Masami Hiramatsu To: Tiezhu Yang Cc: Jonathan Corbet , Marc Koderer , Mauro Carvalho Chehab , Christian Brauner , Martin Schwidefsky , Johannes Thumshirn , Heiko Carstens , Jisheng Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post() Message-Id: <20210514222004.54f4c2b12099b569a872a2ee@kernel.org> In-Reply-To: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn> References: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 May 2021 16:10:10 +0800 Tiezhu Yang wrote: > It should use post_handler instead of pre_handler in handler_post(). Looks good to me. Acked-by: Masami Hiramatsu Thanks! > > Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module") > Signed-off-by: Tiezhu Yang > --- > > v2: rebase on the latest mainline kernel > > samples/kprobes/kprobe_example.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index c495664..602db3f 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs, > p->symbol_name, p->addr, regs->status); > #endif > #ifdef CONFIG_S390 > - pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n", > + pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n", > p->symbol_name, p->addr, regs->flags); > #endif > } > -- > 2.1.0 > -- Masami Hiramatsu