All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
To: Patrick Menschel <menschel.p@posteo.de>
Cc: linux-can <linux-can@vger.kernel.org>
Subject: Re: J1939 Questions on Intended usage
Date: Sat, 15 May 2021 14:26:11 +0200	[thread overview]
Message-ID: <20210515122611.GC2387@x1.vandijck-laurijssen.be> (raw)
In-Reply-To: <f0d77797-c485-2f88-57e3-b5c7b4953706@posteo.de>

On Fri, 14 May 2021 12:04:47 +0000, Patrick Menschel wrote:
> Hi Kurt,
> 
> J1939 just hit the raspberrypi-kernel-headers and will soon be part of
> regular raspberrypi-kernel [1] while it was already
> available in Python 3.9 for a couple of month. [2]
> 
> I was about to give it a spin but was confused of the call parameters.
> 
> Could you shed some light on the intended usage.
> 
> Do I need to open one socket per PGN I'm sending?
> e.g.
> 
> s1 = socket.socket(socket.AF_CAN, socket.SOCK_DGRAM, socket.CAN_J1939)
> s1.bind(interface_name, MY_NAME, PGN_OF_TSC1, MY_SA)
> s1.write(bytes(8))
> 
> s2 = socket.socket(socket.AF_CAN, socket.SOCK_DGRAM, socket.CAN_J1939)
> s2.bind(interface_name, MY_NAME, PGN_OF_EBC1, MY_SA)
> s2.write(bytes(8))

No, you don't _need_ to. You can.

If you need quite some different PGN's, it may be more interesting to:
s = socket.socket(socket.AF_CAN, socket.SOCK_DGRAM, socket.CAN_J1939)
s.bind(interface_name, MY_NAME, ANY_PGN, MY_SA)
s.sendto(bytes(8), DST_1, PGN_1)
s.sendto(bytes(8), DST_2, PGN_2)
...

I'm not a python expert, I just assume something like that is possible.

> 
> 
> What about the cyclic transmitted PGNs? Do I drop those into
> BroadcastManager somehow?

The broadcast manager is seperate from j1939, so it's apart.
> 
> 
> If I want to open an ISOTP Channel while a j1939 socket exists for my
> SA, does anything weird happen on that socket?

No, nothing weird will happen.

The only possible disadvantage I can think of is that the messages sent
using ISOTP do not honor the NAME-SA mapping, so on a bus with dynamic
addressing, you should be carefull to use local/remote addresses.

Kind regards,
Kurt

  reply	other threads:[~2021-05-15 12:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 12:04 J1939 Questions on Intended usage Patrick Menschel
2021-05-15 12:26 ` Kurt Van Dijck [this message]
2021-05-15 14:01   ` Patrick Menschel
2021-05-15 18:10     ` Patrick Menschel
2021-05-15 18:41       ` Marc Kleine-Budde
2021-05-15 18:42       ` Kurt Van Dijck
2021-05-15 19:00         ` Patrick Menschel
2021-05-15 19:07           ` Kurt Van Dijck
2021-05-15 19:17           ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210515122611.GC2387@x1.vandijck-laurijssen.be \
    --to=dev.kurt@vandijck-laurijssen.be \
    --cc=linux-can@vger.kernel.org \
    --cc=menschel.p@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.