From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3E3C433ED for ; Sat, 15 May 2021 20:41:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6195C61157 for ; Sat, 15 May 2021 20:41:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6195C61157 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B20358E0005; Sat, 15 May 2021 16:41:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAA758E0003; Sat, 15 May 2021 16:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 921828E0005; Sat, 15 May 2021 16:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 589598E0003 for ; Sat, 15 May 2021 16:41:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DED4A181AEF1E for ; Sat, 15 May 2021 20:41:43 +0000 (UTC) X-FDA: 78144636486.13.3BD3932 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id E37B6E0001AC for ; Sat, 15 May 2021 20:41:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B3D360249; Sat, 15 May 2021 20:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1621111302; bh=DvgZf0osZoE6IuLlR0dWRkN31mDCiFYcqBj39GpvImI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nt9TYTOOmm1beQJ4u04a+UJAJeRGfOyZg4oPsOuWHBXJgULNb5+LoW8P93OYpIKib 8g06fUQguC7Ghni/F83pu4cJ8GBXVxDzI8wLBgl13zWWGFglFQSWNjnO41ysS+m5fW JTZ8JYFLvloxjz6YDr4IJtEeq+8cl7w4bzfRX1LI= Date: Sat, 15 May 2021 13:41:41 -0700 From: Andrew Morton To: Guenter Roeck Cc: "Aneesh Kumar K.V" , linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy Subject: Re: [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument Message-Id: <20210515134141.b719412dc9dc46bdf2a8ced2@linux-foundation.org> In-Reply-To: <20210515163525.GA1106462@roeck-us.net> References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> <20210515163525.GA1106462@roeck-us.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E37B6E0001AC Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nt9TYTOO; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Stat-Signature: qftjx5efcn46ygeft4buqjus981jna99 X-HE-Tag: 1621111300-392701 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 15 May 2021 09:35:25 -0700 Guenter Roeck wrote: > > > > #define __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > > static inline void flush_pmd_tlb_range(struct vm_area_struct *vma, > ^^^^ > > unsigned long start, unsigned long end) > > +{ > > + return flush_pmd_tlb_pwc_range(vma, start, end, false); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Doesn't that cause build warnings/errors all over the place ? It will, thanks. I queued a fix. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4145BC433B4 for ; Sat, 15 May 2021 20:42:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EAE661157 for ; Sat, 15 May 2021 20:42:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EAE661157 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FjHQ05dbtz3bnW for ; Sun, 16 May 2021 06:42:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=nt9TYTOO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=nt9TYTOO; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FjHPS74y1z2y0C for ; Sun, 16 May 2021 06:41:47 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B3D360249; Sat, 15 May 2021 20:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1621111302; bh=DvgZf0osZoE6IuLlR0dWRkN31mDCiFYcqBj39GpvImI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nt9TYTOOmm1beQJ4u04a+UJAJeRGfOyZg4oPsOuWHBXJgULNb5+LoW8P93OYpIKib 8g06fUQguC7Ghni/F83pu4cJ8GBXVxDzI8wLBgl13zWWGFglFQSWNjnO41ysS+m5fW JTZ8JYFLvloxjz6YDr4IJtEeq+8cl7w4bzfRX1LI= Date: Sat, 15 May 2021 13:41:41 -0700 From: Andrew Morton To: Guenter Roeck Subject: Re: [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument Message-Id: <20210515134141.b719412dc9dc46bdf2a8ced2@linux-foundation.org> In-Reply-To: <20210515163525.GA1106462@roeck-us.net> References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> <20210515163525.GA1106462@roeck-us.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Aneesh Kumar K.V" , npiggin@gmail.com, linux-mm@kvack.org, kaleshsingh@google.com, joel@joelfernandes.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 15 May 2021 09:35:25 -0700 Guenter Roeck wrote: > > > > #define __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > > static inline void flush_pmd_tlb_range(struct vm_area_struct *vma, > ^^^^ > > unsigned long start, unsigned long end) > > +{ > > + return flush_pmd_tlb_pwc_range(vma, start, end, false); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Doesn't that cause build warnings/errors all over the place ? It will, thanks. I queued a fix.