From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37ED62FB0 for ; Sun, 16 May 2021 19:25:02 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id f8so3452943qth.6 for ; Sun, 16 May 2021 12:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2qL4/0Z0j2EC7jbRRZzIaoh/R+YfUxEYzXyjEiPdLIw=; b=MHlJIQoKIs9FDmz5xDjmKZtttdAJPcjjYWGNoa2yp5EtWPNDemGFZTsumk7+WDqtRI 9qzbmH9gyslbvtgyglH/sMERerS47EQLpi/iMC7fctQ68nxXM8hNvSGjq6WlzOTOH06m GRxU8XjE44sMeSYVsSq0j5fpBmDiTXoi38ErzDXPXskSuDXchNWGEqyRvh9gzQpWMrb1 fK8sdBig/Yrf1RogdTYcqM6hGvE6fRN4BrF6Zy+b0W4Br3K8Enc+mjURoYO/6vQZNmhU 9dYx5R5mOOFnFrRlus/uRuToJNNxZKJCDu4dNVFBxQMP5AYTz1YNkpEXLyLVr01myvNa ZS4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=2qL4/0Z0j2EC7jbRRZzIaoh/R+YfUxEYzXyjEiPdLIw=; b=EYNLLkzk+MhkvmDAlTXJAfZRUSjhyfbtEX8wCIjSozY/MmxKkZOD89to6dCd6Wu2Mx 082hnLi/o7dIj0YKO3bMmxaaeb02p+ifWnKO53RbwzFp+I1HqcAN8LL4G66P2ZZJXfPY GUPRU60jEUG07uGB1nXsJNfIzvnJmu+j4rxI9Sao2r4r53mhgb6SURqPTZmZZ4PJxtk4 e2bmbckP5BR27JG3XJHkUwDdU44bxsBZxYOriV8D/IM+9dLzh84gbnfz9ByMq/IsZDwF iDPm8+F4tHQ8M1YxQEsJY5qwIlaVnK2lfP1OQd8czNw76HXVXa73KpqyOwXwkGejenCC hPkA== X-Gm-Message-State: AOAM532lB/UY2C6QkOC0Mcc20b3KQme7IsBlIO0H3Lc3k37EjOQM3knc ksPSI/YRl2TV7J1pWwT6alo= X-Google-Smtp-Source: ABdhPJySW7oGInihkMTiq6GGDc4qKYHH9h1/OWMrzEJikC2X5P9mNZ7o6lRc0p7ulDGDt6AhuP4+7g== X-Received: by 2002:ac8:67d3:: with SMTP id r19mr52674143qtp.23.1621193101413; Sun, 16 May 2021 12:25:01 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 7sm10061446qtu.38.2021.05.16.12.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 12:25:01 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 16 May 2021 12:24:59 -0700 From: Guenter Roeck To: Martin Kaiser Cc: Larry Finger , Greg Kroah-Hartman , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] staging: rtl8188eu: use safe iterator in rtw_free_xmitframe_queue Message-ID: <20210516192459.GF2126643@roeck-us.net> References: <20210516160613.30489-1-martin@kaiser.cx> <20210516160613.30489-6-martin@kaiser.cx> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210516160613.30489-6-martin@kaiser.cx> On Sun, May 16, 2021 at 06:06:13PM +0200, Martin Kaiser wrote: > Use list_for_each_safe, we may delete list items while iterating over > the list. > > Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers") > Signed-off-by: Martin Kaiser Reviewed-by: Guenter Roeck > --- > compile-tested only > > drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c > index 3763d188b892..62b8f178280e 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c > @@ -1329,13 +1329,13 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram > > void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pframequeue) > { > - struct list_head *plist, *phead; > + struct list_head *plist, *phead, *temp; > struct xmit_frame *pxmitframe; > > spin_lock_bh(&pframequeue->lock); > > phead = get_list_head(pframequeue); > - list_for_each(plist, phead) { > + list_for_each_safe(plist, temp, phead) { > pxmitframe = list_entry(plist, struct xmit_frame, list); > > rtw_free_xmitframe(pxmitpriv, pxmitframe); > -- > 2.20.1 >