All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 00/24] Rid W=1 warnings in net
@ 2021-05-17  4:45 Yang Shen
  2021-05-17  4:45 ` [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers Yang Shen
                   ` (24 more replies)
  0 siblings, 25 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen

This is 1 of 2 sets to fully clean drivers/net.

Changes since v1:
 - add some warnings missed in v1
 - move the patches about drivers/net/wireless into another series

Yang Shen (24):
  net: arc: Demote non-compliant kernel-doc headers
  net: atheros: atl1c: Fix wrong function name in comments
  net: atheros: atl1e: Fix wrong function name in comments
  net: atheros: atl1x: Fix wrong function name in comments
  net: broadcom: bnx2x: Fix wrong function name in comments
  net: brocade: bna: Fix wrong function name in comments
  net: cadence: Demote non-compliant kernel-doc headers
  net: calxeda: Fix wrong function name in comments
  net: chelsio: cxgb3: Fix wrong function name in comments
  net: chelsio: cxgb4: Fix wrong function name in comments
  net: chelsio: cxgb4vf: Fix wrong function name in comments
  net: huawei: hinic: Fix wrong function name in comments
  net: micrel: Fix wrong function name in comments
  net: microchip: Demote non-compliant kernel-doc headers
  net: neterion: Fix wrong function name in comments
  net: neterion: vxge: Fix wrong function name in comments
  net: netronome: nfp: Fix wrong function name in comments
  net: calxeda: Fix wrong function name in comments
  net: samsung: sxgbe: Fix wrong function name in comments
  net: socionext: Demote non-compliant kernel-doc headers
  net: ti: Fix wrong struct name in comments
  net: via: Fix wrong function name in comments
  net: phy: Demote non-compliant kernel-doc headers
  net: hisilicon: hns: Fix wrong function name in comments

 drivers/net/ethernet/arc/emac_rockchip.c         |  2 +-
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c  |  6 +++---
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c  |  4 ++--
 drivers/net/ethernet/atheros/atlx/atl1.c         |  2 +-
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  2 +-
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c   |  4 ++--
 drivers/net/ethernet/brocade/bna/bfa_cee.c       |  2 +-
 drivers/net/ethernet/cadence/macb_pci.c          |  2 +-
 drivers/net/ethernet/cadence/macb_ptp.c          |  2 +-
 drivers/net/ethernet/calxeda/xgmac.c             |  8 ++++----
 drivers/net/ethernet/chelsio/cxgb3/sge.c         |  4 ++--
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c   |  2 +-
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c       |  4 ++--
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c       |  2 +-
 .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c    |  6 +++---
 .../net/ethernet/hisilicon/hns/hns_dsaf_main.c   | 16 ++++++++--------
 .../net/ethernet/hisilicon/hns/hns_dsaf_misc.c   |  4 ++--
 .../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c    |  8 ++++----
 .../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c    |  2 +-
 .../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c  |  4 ++--
 drivers/net/ethernet/hisilicon/hns/hns_enet.c    |  2 +-
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c |  6 +++---
 .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c    |  2 +-
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c |  8 ++++----
 drivers/net/ethernet/huawei/hinic/hinic_hw_if.c  |  2 +-
 drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c  |  2 +-
 drivers/net/ethernet/huawei/hinic/hinic_main.c   |  4 ++--
 drivers/net/ethernet/huawei/hinic/hinic_tx.c     |  2 +-
 drivers/net/ethernet/micrel/ksz884x.c            |  6 +++---
 drivers/net/ethernet/microchip/encx24j600.c      |  2 +-
 drivers/net/ethernet/neterion/s2io.c             |  4 ++--
 drivers/net/ethernet/neterion/vxge/vxge-config.c |  2 +-
 drivers/net/ethernet/neterion/vxge/vxge-main.c   |  4 ++--
 drivers/net/ethernet/netronome/nfp/ccm_mbox.c    |  2 +-
 .../ethernet/netronome/nfp/flower/tunnel_conf.c  |  2 +-
 .../ethernet/netronome/nfp/nfpcore/nfp_nffw.c    |  2 +-
 .../ethernet/qlogic/qlcnic/qlcnic_83xx_init.c    |  2 +-
 .../ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c    |  2 +-
 drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c  |  4 ++--
 drivers/net/ethernet/socionext/sni_ave.c         |  2 +-
 drivers/net/ethernet/ti/cpsw_ale.c               |  2 +-
 drivers/net/ethernet/via/via-velocity.c          |  6 +++---
 drivers/net/phy/adin.c                           |  2 +-
 drivers/net/phy/rockchip.c                       |  2 +-
 44 files changed, 80 insertions(+), 80 deletions(-)

--
2.17.1


^ permalink raw reply	[flat|nested] 28+ messages in thread

* [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 02/24] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
                   ` (23 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/arc/emac_rockchip.c:18: warning: expecting prototype for emac(). Prototype was for DRV_NAME() instead

Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/net/ethernet/arc/emac_rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c
index 48ecdf15eddc..1c9ca3bcb871 100644
--- a/drivers/net/ethernet/arc/emac_rockchip.c
+++ b/drivers/net/ethernet/arc/emac_rockchip.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
  * emac-rockchip.c - Rockchip EMAC specific glue layer
  *
  * Copyright (C) 2014 Romain Perier <romain.perier@gmail.com>
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 02/24] net: atheros: atl1c: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
  2021-05-17  4:45 ` [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 03/24] net: atheros: atl1e: " Yang Shen
                   ` (22 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Chris Snook

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/atheros/atl1c/atl1c_main.c:442: warning: expecting prototype for atl1c_set_mac(). Prototype was for atl1c_set_mac_addr() instead
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c:969: warning: expecting prototype for atl1c_setup_mem_resources(). Prototype was for atl1c_setup_ring_resources() instead
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1375: warning: expecting prototype for atl1c_configure(). Prototype was for atl1c_configure_mac() instead

Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 740127a6a21d..77da1c54c49f 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -432,7 +432,7 @@ static void atl1c_restore_vlan(struct atl1c_adapter *adapter)
 }
 
 /**
- * atl1c_set_mac - Change the Ethernet Address of the NIC
+ * atl1c_set_mac_addr - Change the Ethernet Address of the NIC
  * @netdev: network interface device structure
  * @p: pointer to an address structure
  *
@@ -960,7 +960,7 @@ static void atl1c_free_ring_resources(struct atl1c_adapter *adapter)
 }
 
 /**
- * atl1c_setup_mem_resources - allocate Tx / RX descriptor resources
+ * atl1c_setup_ring_resources - allocate Tx / RX descriptor resources
  * @adapter: board private structure
  *
  * Return 0 on success, negative on failure
@@ -1366,7 +1366,7 @@ static void atl1c_set_aspm(struct atl1c_hw *hw, u16 link_speed)
 }
 
 /**
- * atl1c_configure - Configure Transmit&Receive Unit after Reset
+ * atl1c_configure_mac - Configure Transmit&Receive Unit after Reset
  * @adapter: board private structure
  *
  * Configure the Tx /Rx unit of the MAC after a reset.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 03/24] net: atheros: atl1e: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
  2021-05-17  4:45 ` [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers Yang Shen
  2021-05-17  4:45 ` [PATCH v2 02/24] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 04/24] net: atheros: atl1x: " Yang Shen
                   ` (21 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Chris Snook

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/atheros/atl1e/atl1e_main.c:367: warning: expecting prototype for atl1e_set_mac(). Prototype was for atl1e_set_mac_addr() instead
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c:796: warning: expecting prototype for atl1e_setup_mem_resources(). Prototype was for atl1e_setup_ring_resources() instead

Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
index ff9f96de74b8..2eb0a2ab69f6 100644
--- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
@@ -357,7 +357,7 @@ static void atl1e_restore_vlan(struct atl1e_adapter *adapter)
 }
 
 /**
- * atl1e_set_mac - Change the Ethernet Address of the NIC
+ * atl1e_set_mac_addr - Change the Ethernet Address of the NIC
  * @netdev: network interface device structure
  * @p: pointer to an address structure
  *
@@ -787,7 +787,7 @@ static void atl1e_free_ring_resources(struct atl1e_adapter *adapter)
 }
 
 /**
- * atl1e_setup_mem_resources - allocate Tx / RX descriptor resources
+ * atl1e_setup_ring_resources - allocate Tx / RX descriptor resources
  * @adapter: board private structure
  *
  * Return 0 on success, negative on failure
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 04/24] net: atheros: atl1x: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (2 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 03/24] net: atheros: atl1e: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 05/24] net: broadcom: bnx2x: " Yang Shen
                   ` (20 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Chris Snook

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/atheros/atlx/atl1.c:1020: warning: expecting prototype for atl1_setup_mem_resources(). Prototype was for atl1_setup_ring_resources() instead

Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/ethernet/atheros/atlx/atl1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c
index eaf96d002fa5..c67201a13cf5 100644
--- a/drivers/net/ethernet/atheros/atlx/atl1.c
+++ b/drivers/net/ethernet/atheros/atlx/atl1.c
@@ -1011,7 +1011,7 @@ static int atl1_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
 }
 
 /**
- * atl1_setup_mem_resources - allocate Tx / RX descriptor resources
+ * atl1_setup_ring_resources - allocate Tx / RX descriptor resources
  * @adapter: board private structure
  *
  * Return 0 on success, negative on failure
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (3 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 04/24] net: atheros: atl1x: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-19  9:30   ` [EXT] " Sudarsana Reddy Kalluru
  2021-05-17  4:45 ` [PATCH v2 06/24] net: brocade: bna: " Yang Shen
                   ` (19 subsequent siblings)
  24 siblings, 1 reply; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba
  Cc: netdev, linux-kernel, Yang Shen, Ariel Elior, Sudarsana Kalluru,
	GR-everest-linux-l2

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13595: warning: expecting prototype for bnx2x_get_num_none_def_sbs(). Prototype was for bnx2x_get_num_non_def_sbs() instead
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4165: warning: expecting prototype for atomic_add_ifless(). Prototype was for __atomic_add_ifless() instead
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4193: warning: expecting prototype for atomic_dec_ifmoe(). Prototype was for __atomic_dec_ifmoe() instead

Cc: Ariel Elior <aelior@marvell.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: GR-everest-linux-l2@marvell.com
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 281b1c2e04a7..2acbc73dcd18 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -13586,7 +13586,7 @@ static int bnx2x_set_qm_cid_count(struct bnx2x *bp)
 }
 
 /**
- * bnx2x_get_num_none_def_sbs - return the number of none default SBs
+ * bnx2x_get_num_non_def_sbs - return the number of none default SBs
  * @pdev: pci device
  * @cnic_cnt: count
  *
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 6cd1523ad9e5..542c69822649 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -4152,7 +4152,7 @@ void bnx2x_init_mcast_obj(struct bnx2x *bp,
 /*************************** Credit handling **********************************/
 
 /**
- * atomic_add_ifless - add if the result is less than a given value.
+ * __atomic_add_ifless - add if the result is less than a given value.
  *
  * @v:	pointer of type atomic_t
  * @a:	the amount to add to v...
@@ -4180,7 +4180,7 @@ static inline bool __atomic_add_ifless(atomic_t *v, int a, int u)
 }
 
 /**
- * atomic_dec_ifmoe - dec if the result is more or equal than a given value.
+ * __atomic_dec_ifmoe - dec if the result is more or equal than a given value.
  *
  * @v:	pointer of type atomic_t
  * @a:	the amount to dec from v...
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 06/24] net: brocade: bna: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (4 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 05/24] net: broadcom: bnx2x: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 07/24] net: cadence: Demote non-compliant kernel-doc headers Yang Shen
                   ` (18 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba
  Cc: netdev, linux-kernel, Yang Shen, Rasesh Mody, Sudarsana Kalluru,
	GR-Linux-NIC-Dev

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/brocade/bna/bfa_cee.c:91: warning: expecting prototype for bfa_cee_get_attr_isr(). Prototype was for bfa_cee_get_stats_isr() instead

Cc: Rasesh Mody <rmody@marvell.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/brocade/bna/bfa_cee.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/brocade/bna/bfa_cee.c b/drivers/net/ethernet/brocade/bna/bfa_cee.c
index 06f221c44802..eeb05e31713f 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_cee.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_cee.c
@@ -82,7 +82,7 @@ bfa_cee_get_attr_isr(struct bfa_cee *cee, enum bfa_status status)
 }
 
 /**
- * bfa_cee_get_attr_isr - CEE ISR for get-stats responses from f/w
+ * bfa_cee_get_stats_isr - CEE ISR for get-stats responses from f/w
  *
  * @cee: Pointer to the CEE module
  * @status: Return status from the f/w
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 07/24] net: cadence: Demote non-compliant kernel-doc headers
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (5 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 06/24] net: brocade: bna: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 08/24] net: calxeda: Fix wrong function name in comments Yang Shen
                   ` (17 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba
  Cc: netdev, linux-kernel, Yang Shen, Nicolas Ferre, Claudiu Beznea

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/cadence/macb_pci.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/cadence/macb_pci.c | 2 +-
 drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c
index 353393dea639..8b7b59908a1a 100644
--- a/drivers/net/ethernet/cadence/macb_pci.c
+++ b/drivers/net/ethernet/cadence/macb_pci.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * DOC: Cadence GEM PCI wrapper.
  *
  * Copyright (C) 2016 Cadence Design Systems - https://www.cadence.com
diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
index 283918aeb741..5c368a9cbbbc 100644
--- a/drivers/net/ethernet/cadence/macb_ptp.c
+++ b/drivers/net/ethernet/cadence/macb_ptp.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * 1588 PTP support for Cadence GEM device.
  *
  * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 08/24] net: calxeda: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (6 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 07/24] net: cadence: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 09/24] net: chelsio: cxgb3: " Yang Shen
                   ` (16 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/calxeda/xgmac.c:720: warning: expecting prototype for init_xgmac_dma_desc_rings(). Prototype was for xgmac_dma_desc_rings_init() instead
 drivers/net/ethernet/calxeda/xgmac.c:867: warning: expecting prototype for xgmac_tx(). Prototype was for xgmac_tx_complete() instead
 drivers/net/ethernet/calxeda/xgmac.c:1049: warning: expecting prototype for xgmac_release(). Prototype was for xgmac_stop() instead
 drivers/net/ethernet/calxeda/xgmac.c:1822: warning: expecting prototype for xgmac_dvr_remove(). Prototype was for xgmac_remove() instead

Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/calxeda/xgmac.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index bbb453c6a5f7..b6a066404f4b 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -711,7 +711,7 @@ static void xgmac_rx_refill(struct xgmac_priv *priv)
 }
 
 /**
- * init_xgmac_dma_desc_rings - init the RX/TX descriptor rings
+ * xgmac_dma_desc_rings_init - init the RX/TX descriptor rings
  * @dev: net device structure
  * Description:  this function initializes the DMA RX/TX descriptors
  * and allocates the socket buffers.
@@ -859,7 +859,7 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv)
 }
 
 /**
- * xgmac_tx:
+ * xgmac_tx_complete:
  * @priv: private driver structure
  * Description: it reclaims resources after transmission completes.
  */
@@ -1040,7 +1040,7 @@ static int xgmac_open(struct net_device *dev)
 }
 
 /**
- *  xgmac_release - close entry point of the driver
+ *  xgmac_stop - close entry point of the driver
  *  @dev : device pointer.
  *  Description:
  *  This is the stop entry point of the driver.
@@ -1812,7 +1812,7 @@ static int xgmac_probe(struct platform_device *pdev)
 }
 
 /**
- * xgmac_dvr_remove
+ * xgmac_remove
  * @pdev: platform device pointer
  * Description: this function resets the TX/RX processes, disables the MAC RX/TX
  * changes the link status, releases the DMA descriptor rings,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 09/24] net: chelsio: cxgb3: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (7 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 08/24] net: calxeda: Fix wrong function name in comments Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 10/24] net: chelsio: cxgb4: " Yang Shen
                   ` (15 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Raju Rangoju

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/chelsio/cxgb3/sge.c:677: warning: expecting prototype for free_qset(). Prototype was for t3_free_qset() instead
 drivers/net/ethernet/chelsio/cxgb3/sge.c:1266: warning: expecting prototype for eth_xmit(). Prototype was for t3_eth_xmit() instead

Cc: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb3/sge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index 1cc3c51eff71..cec7308e2d5b 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -665,7 +665,7 @@ static void t3_reset_qset(struct sge_qset *q)
 
 
 /**
- *	free_qset - free the resources of an SGE queue set
+ *	t3_free_qset - free the resources of an SGE queue set
  *	@adapter: the adapter owning the queue set
  *	@q: the queue set
  *
@@ -1256,7 +1256,7 @@ static inline void t3_stop_tx_queue(struct netdev_queue *txq,
 }
 
 /**
- *	eth_xmit - add a packet to the Ethernet Tx queue
+ *	t3_eth_xmit - add a packet to the Ethernet Tx queue
  *	@skb: the packet
  *	@dev: the egress net device
  *
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 10/24] net: chelsio: cxgb4: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (8 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 09/24] net: chelsio: cxgb3: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 11/24] net: chelsio: cxgb4vf: " Yang Shen
                   ` (14 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Raju Rangoju

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/chelsio/cxgb3/sge.c:677: warning: expecting prototype for free_qset(). Prototype was for t3_free_qset() instead
 drivers/net/ethernet/chelsio/cxgb3/sge.c:1266: warning: expecting prototype for eth_xmit(). Prototype was for t3_eth_xmit() instead

Cc: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c
index 70dbee89118e..5bf117d2179f 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c
@@ -446,7 +446,7 @@ void cxgb4_ptp_init(struct adapter *adapter)
 }
 
 /**
- * cxgb4_ptp_remove - disable PTP device and stop the overflow check
+ * cxgb4_ptp_stop - disable PTP device and stop the overflow check
  * @adapter: board private structure
  *
  * Stop the PTP support.
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index 9428ef1f04a8..ae3ad99fbd06 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -6983,7 +6983,7 @@ int t4_fw_bye(struct adapter *adap, unsigned int mbox)
 }
 
 /**
- *	t4_init_cmd - ask FW to initialize the device
+ *	t4_early_init - ask FW to initialize the device
  *	@adap: the adapter
  *	@mbox: mailbox to use for the FW command
  *
@@ -10224,7 +10224,7 @@ int t4_load_cfg(struct adapter *adap, const u8 *cfg_data, unsigned int size)
 }
 
 /**
- *	t4_set_vf_mac - Set MAC address for the specified VF
+ *	t4_set_vf_mac_acl - Set MAC address for the specified VF
  *	@adapter: The adapter
  *	@vf: one of the VFs instantiated by the specified PF
  *	@naddr: the number of MAC addresses
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 11/24] net: chelsio: cxgb4vf: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (9 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 10/24] net: chelsio: cxgb4: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 12/24] net: huawei: hinic: " Yang Shen
                   ` (13 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Raju Rangoju

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/chelsio/cxgb4vf/sge.c:966: warning: expecting prototype for check_ring_tx_db(). Prototype was for ring_tx_db() instead

Cc: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c b/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
index 95657da0aa4b..7bc80eeb2c21 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
@@ -954,7 +954,7 @@ static void write_sgl(const struct sk_buff *skb, struct sge_txq *tq,
 }
 
 /**
- *	check_ring_tx_db - check and potentially ring a TX queue's doorbell
+ *	ring_tx_db - check and potentially ring a TX queue's doorbell
  *	@adapter: the adapter
  *	@tq: the TX queue
  *	@n: number of new descriptors to give to HW
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 12/24] net: huawei: hinic: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (10 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 11/24] net: chelsio: cxgb4vf: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 13/24] net: micrel: " Yang Shen
                   ` (12 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Bin Luo

Fixes the following W=1 kernel build warning(s):
 drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:604: warning: expecting prototype for cmdq_arm_ceq_handler(). Prototype was for cmdq_sync_cmd_handler() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:59: warning: expecting prototype for get_capability(). Prototype was for parse_capability() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:101: warning: expecting prototype for get_cap_from_fw(). Prototype was for get_capability() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:355: warning: expecting prototype for clear_io_resource(). Prototype was for clear_io_resources() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:1100: warning: expecting prototype for hinic_hwdev_get_sq(). Prototype was for hinic_hwdev_get_rq() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_if.c:341: warning: expecting prototype for dma_attr_table_init(). Prototype was for dma_attr_init() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c:904: warning: expecting prototype for hinic_put_wqe(). Prototype was for hinic_rq_put_wqe() instead
 drivers/net/ethernet/huawei/hinic/hinic_main.c:241: warning: expecting prototype for create_txqs(). Prototype was for create_rxqs() instead
 drivers/net/ethernet/huawei/hinic/hinic_main.c:295: warning: expecting prototype for free_txqs(). Prototype was for free_rxqs() instead
 drivers/net/ethernet/huawei/hinic/hinic_tx.c:667: warning: expecting prototype for free_all_rx_skbs(). Prototype was for free_all_tx_skbs() instead

Cc: Bin Luo <luobin9@huawei.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +-
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c  | 8 ++++----
 drivers/net/ethernet/huawei/hinic/hinic_hw_if.c   | 2 +-
 drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c   | 2 +-
 drivers/net/ethernet/huawei/hinic/hinic_main.c    | 4 ++--
 drivers/net/ethernet/huawei/hinic/hinic_tx.c      | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
index 577cb2cffff2..307a6d4af993 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
@@ -594,7 +594,7 @@ static void cmdq_update_errcode(struct hinic_cmdq *cmdq, u16 prod_idx,
 }
 
 /**
- * cmdq_arm_ceq_handler - cmdq completion event handler for sync command
+ * cmdq_sync_cmd_handler - cmdq completion event handler for sync command
  * @cmdq: the cmdq of the command
  * @cons_idx: the consumer index to update the error code for
  * @errcode: the error code
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
index 19a91c0223a7..428108eb10d2 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
@@ -48,7 +48,7 @@ enum io_status {
 };
 
 /**
- * get_capability - convert device capabilities to NIC capabilities
+ * parse_capability - convert device capabilities to NIC capabilities
  * @hwdev: the HW device to set and convert device capabilities for
  * @dev_cap: device capabilities from FW
  *
@@ -92,7 +92,7 @@ static int parse_capability(struct hinic_hwdev *hwdev,
 }
 
 /**
- * get_cap_from_fw - get device capabilities from FW
+ * get_capability - get device capabilities from FW
  * @pfhwdev: the PF HW device to get capabilities for
  *
  * Return 0 - Success, negative - Failure
@@ -346,7 +346,7 @@ static int wait_for_db_state(struct hinic_hwdev *hwdev)
 }
 
 /**
- * clear_io_resource - set the IO resources as not active in the NIC
+ * clear_io_resources - set the IO resources as not active in the NIC
  * @hwdev: the NIC HW device
  *
  * Return 0 - Success, negative - Failure
@@ -1090,7 +1090,7 @@ struct hinic_sq *hinic_hwdev_get_sq(struct hinic_hwdev *hwdev, int i)
 }
 
 /**
- * hinic_hwdev_get_sq - get RQ
+ * hinic_hwdev_get_rq - get RQ
  * @hwdev: the NIC HW device
  * @i: the position of the RQ
  *
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
index 55b327eebe64..0428faa68e80 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
@@ -334,7 +334,7 @@ static void set_dma_attr(struct hinic_hwif *hwif, u32 entry_idx,
 }
 
 /**
- * dma_attr_table_init - initialize the default dma attributes
+ * dma_attr_init - initialize the default dma attributes
  * @hwif: the HW interface of a pci function device
  **/
 static void dma_attr_init(struct hinic_hwif *hwif)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
index dcba4d009bad..336248aa2e48 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
@@ -894,7 +894,7 @@ struct hinic_rq_wqe *hinic_rq_read_next_wqe(struct hinic_rq *rq,
 }
 
 /**
- * hinic_put_wqe - release the ci for new wqes
+ * hinic_rq_put_wqe - release the ci for new wqes
  * @rq: recv queue
  * @cons_idx: consumer index of the wqe
  * @wqe_size: the size of the wqe
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
index 1da5997f034c..405ee4d2d2b1 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_main.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c
@@ -232,7 +232,7 @@ static void free_txqs(struct hinic_dev *nic_dev)
 }
 
 /**
- * create_txqs - Create the Logical Rx Queues of specific NIC device
+ * create_rxqs - Create the Logical Rx Queues of specific NIC device
  * @nic_dev: the specific NIC device
  *
  * Return 0 - Success, negative - Failure
@@ -288,7 +288,7 @@ static int create_rxqs(struct hinic_dev *nic_dev)
 }
 
 /**
- * free_txqs - Free the Logical Rx Queues of specific NIC device
+ * free_rxqs - Free the Logical Rx Queues of specific NIC device
  * @nic_dev: the specific NIC device
  **/
 static void free_rxqs(struct hinic_dev *nic_dev)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
index 7bd414aed6ff..c5bdb0d374ef 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_tx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
@@ -660,7 +660,7 @@ static void tx_free_skb(struct hinic_dev *nic_dev, struct sk_buff *skb,
 }
 
 /**
- * free_all_rx_skbs - free all skbs in tx queue
+ * free_all_tx_skbs - free all skbs in tx queue
  * @txq: tx queue
  **/
 static void free_all_tx_skbs(struct hinic_txq *txq)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 13/24] net: micrel: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (11 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 12/24] net: huawei: hinic: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 14/24] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
                   ` (11 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Tristram Ha

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/micrel/ksz884x.c:2163: warning: expecting prototype for sw_get_board_storm(). Prototype was for sw_get_broad_storm() instead
 drivers/net/ethernet/micrel/ksz884x.c:2985: warning: expecting prototype for port_w_phy(). Prototype was for hw_w_phy() instead
 drivers/net/ethernet/micrel/ksz884x.c:4792: warning: expecting prototype for transmit_done(). Prototype was for tx_done() instead

Cc: Tristram Ha <Tristram.Ha@micrel.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/micrel/ksz884x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 9ed264ed7070..3532bfe936f6 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -2153,7 +2153,7 @@ static void sw_cfg_broad_storm(struct ksz_hw *hw, u8 percent)
 }
 
 /**
- * sw_get_board_storm - get broadcast storm threshold
+ * sw_get_broad_storm - get broadcast storm threshold
  * @hw: 	The hardware instance.
  * @percent:	Buffer to store the broadcast storm threshold percentage.
  *
@@ -2973,7 +2973,7 @@ static void hw_r_phy(struct ksz_hw *hw, int port, u16 reg, u16 *val)
 }
 
 /**
- * port_w_phy - write data to PHY register
+ * hw_w_phy - write data to PHY register
  * @hw: 	The hardware instance.
  * @port:	Port to write.
  * @reg:	PHY register to write.
@@ -4782,7 +4782,7 @@ static void transmit_cleanup(struct dev_info *hw_priv, int normal)
 }
 
 /**
- * transmit_done - transmit done processing
+ * tx_done - transmit done processing
  * @hw_priv:	Network device.
  *
  * This routine is called when the transmit interrupt is triggered, indicating
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 14/24] net: microchip: Demote non-compliant kernel-doc headers
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (12 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 13/24] net: micrel: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 15/24] net: neterion: Fix wrong function name in comments Yang Shen
                   ` (10 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Jon Ringle

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/microchip/encx24j600.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Cc: Jon Ringle <jringle@gridpoint.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/microchip/encx24j600.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c
index 3658c4ae3c37..ee921a99e439 100644
--- a/drivers/net/ethernet/microchip/encx24j600.c
+++ b/drivers/net/ethernet/microchip/encx24j600.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
  * Microchip ENCX24J600 ethernet driver
  *
  * Copyright (C) 2015 Gridpoint
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 15/24] net: neterion: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (13 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 14/24] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 16/24] net: neterion: vxge: " Yang Shen
                   ` (9 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Jon Mason

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/neterion/s2io.c:2759: warning: expecting prototype for s2io_poll(). Prototype was for s2io_poll_msix() instead
 drivers/net/ethernet/neterion/s2io.c:5304: warning: expecting prototype for s2io_ethtol_get_link_ksettings(). Prototype was for s2io_ethtool_get_link_ksettings() instead

Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/neterion/s2io.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index 9cfcd5500462..27a65ab3d501 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -2743,7 +2743,7 @@ static int s2io_chk_rx_buffers(struct s2io_nic *nic, struct ring_info *ring)
 }
 
 /**
- * s2io_poll - Rx interrupt handler for NAPI support
+ * s2io_poll_msix - Rx interrupt handler for NAPI support
  * @napi : pointer to the napi structure.
  * @budget : The number of packets that were budgeted to be processed
  * during  one pass through the 'Poll" function.
@@ -5288,7 +5288,7 @@ s2io_ethtool_set_link_ksettings(struct net_device *dev,
 }
 
 /**
- * s2io_ethtol_get_link_ksettings - Return link specific information.
+ * s2io_ethtool_get_link_ksettings - Return link specific information.
  * @dev: pointer to netdev
  * @cmd : pointer to the structure with parameters given by ethtool
  * to return link information.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 16/24] net: neterion: vxge: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (14 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 15/24] net: neterion: Fix wrong function name in comments Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 17/24] net: netronome: nfp: " Yang Shen
                   ` (8 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Jon Mason

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/neterion/vxge/vxge-config.c:4895: warning: expecting prototype for vxge_hw_vpath_rx_doorbell_post(). Prototype was for vxge_hw_vpath_rx_doorbell_init() instead
 drivers/net/ethernet/neterion/vxge/vxge-main.c:1814: warning: expecting prototype for vxge_poll(). Prototype was for vxge_poll_msix() instead
 drivers/net/ethernet/neterion/vxge/vxge-main.c:4761: warning: expecting prototype for vxge_rem_nic(). Prototype was for vxge_remove() instead

Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/neterion/vxge/vxge-config.c | 2 +-
 drivers/net/ethernet/neterion/vxge/vxge-main.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
index 5162b938a1ac..38a273c4d593 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
@@ -4884,7 +4884,7 @@ vxge_hw_vpath_open(struct __vxge_hw_device *hldev,
 }
 
 /**
- * vxge_hw_vpath_rx_doorbell_post - Close the handle got from previous vpath
+ * vxge_hw_vpath_rx_doorbell_init - Close the handle got from previous vpath
  * (vpath) open
  * @vp: Handle got from previous vpath open
  *
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index 87892bd992b1..b113c158d6e3 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -1799,7 +1799,7 @@ static void vxge_reset(struct work_struct *work)
 }
 
 /**
- * vxge_poll - Receive handler when Receive Polling is used.
+ * vxge_poll_msix - Receive handler when Receive Polling is used.
  * @napi: pointer to the napi structure.
  * @budget: Number of packets budgeted to be processed in this iteration.
  *
@@ -4752,7 +4752,7 @@ vxge_probe(struct pci_dev *pdev, const struct pci_device_id *pre)
 }
 
 /**
- * vxge_rem_nic - Free the PCI device
+ * vxge_remove - Free the PCI device
  * @pdev: structure containing the PCI related information of the device.
  * Description: This function is called by the Pci subsystem to release a
  * PCI device and free up all resource held up by the device.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 17/24] net: netronome: nfp: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (15 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 16/24] net: neterion: vxge: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17 10:00   ` Simon Horman
  2021-05-17  4:45 ` [PATCH v2 18/24] net: calxeda: " Yang Shen
                   ` (7 subsequent siblings)
  24 siblings, 1 reply; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Simon Horman

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/netronome/nfp/ccm_mbox.c:52: warning: expecting prototype for struct nfp_ccm_mbox_skb_cb. Prototype was for struct nfp_ccm_mbox_cmsg_cb instead
 drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:35: warning: expecting prototype for struct nfp_tun_pre_run_rule. Prototype was for struct nfp_tun_pre_tun_rule instead
 drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c:38: warning: expecting prototype for NFFW_INFO_VERSION history(). Prototype was for NFFW_INFO_VERSION_CURRENT() instead

Cc: Simon Horman <simon.horman@netronome.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/netronome/nfp/ccm_mbox.c           | 2 +-
 drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +-
 drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/netronome/nfp/ccm_mbox.c b/drivers/net/ethernet/netronome/nfp/ccm_mbox.c
index f0783aa9e66e..4247bca09807 100644
--- a/drivers/net/ethernet/netronome/nfp/ccm_mbox.c
+++ b/drivers/net/ethernet/netronome/nfp/ccm_mbox.c
@@ -36,7 +36,7 @@ enum nfp_net_mbox_cmsg_state {
 };
 
 /**
- * struct nfp_ccm_mbox_skb_cb - CCM mailbox specific info
+ * struct nfp_ccm_mbox_cmsg_cb - CCM mailbox specific info
  * @state:	processing state (/stage) of the message
  * @err:	error encountered during processing if any
  * @max_len:	max(request_len, reply_len)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c
index d19c02e99114..ab70179728f6 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c
@@ -21,7 +21,7 @@
 #define NFP_TUN_PRE_TUN_IPV6_BIT	BIT(7)
 
 /**
- * struct nfp_tun_pre_run_rule - rule matched before decap
+ * struct nfp_tun_pre_tun_rule - rule matched before decap
  * @flags:		options for the rule offset
  * @port_idx:		index of destination MAC address for the rule
  * @vlan_tci:		VLAN info associated with MAC
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
index d4e02542e2e9..e2e5fd003ad6 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
@@ -24,7 +24,7 @@
 
 #define NFFW_FWID_ALL   255
 
-/**
+/*
  * NFFW_INFO_VERSION history:
  * 0: This was never actually used (before versioning), but it refers to
  *    the previous struct which had FWINFO_CNT = MEINFO_CNT = 120 that later
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 18/24] net: calxeda: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (16 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 17/24] net: netronome: nfp: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 19/24] net: samsung: sxgbe: " Yang Shen
                   ` (6 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Shahed Shaikh, Manish Chopra

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c:761: warning: expecting prototype for qlcnic_83xx_idc_cold_state(). Prototype was for qlcnic_83xx_idc_cold_state_handler() instead
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c:192: warning: expecting prototype for qlcnic_83xx_vnic_opmode(). Prototype was for qlcnic_83xx_config_vnic_opmode() instead

Cc: Shahed Shaikh <shshaikh@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
index d2c190732d3e..0a2f34fc8b24 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
@@ -746,7 +746,7 @@ static int qlcnic_83xx_idc_unknown_state(struct qlcnic_adapter *adapter)
 }
 
 /**
- * qlcnic_83xx_idc_cold_state
+ * qlcnic_83xx_idc_cold_state_handler
  *
  * @adapter: adapter structure
  *
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
index c4297aea7d15..711609503ba6 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
@@ -180,7 +180,7 @@ static int qlcnic_83xx_init_non_privileged_vnic(struct qlcnic_adapter *adapter)
 }
 
 /**
- * qlcnic_83xx_vnic_opmode
+ * qlcnic_83xx_config_vnic_opmode
  *
  * @adapter: adapter structure
  * Identify virtual NIC operational modes.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 19/24] net: samsung: sxgbe: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (17 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 18/24] net: calxeda: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 20/24] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
                   ` (5 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Byungho An

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:797: warning: expecting prototype for sxgbe_tx_clean(). Prototype was for sxgbe_tx_all_clean() instead
 drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1026: warning: expecting prototype for sxgbe_init_tx_coalesce(). Prototype was for sxgbe_tx_init_coalesce() instead

Cc: Byungho An <bh74.an@samsung.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
index 971f1e54b652..090bcd2fb758 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
@@ -789,7 +789,7 @@ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue)
 }
 
 /**
- * sxgbe_tx_clean:
+ * sxgbe_tx_all_clean:
  * @priv: driver private structure
  * Description: it reclaims resources after transmission completes.
  */
@@ -1015,7 +1015,7 @@ static void sxgbe_tx_timer(struct timer_list *t)
 }
 
 /**
- * sxgbe_init_tx_coalesce: init tx mitigation options.
+ * sxgbe_tx_init_coalesce: init tx mitigation options.
  * @priv: driver private structure
  * Description:
  * This inits the transmit coalesce parameters: i.e. timer rate,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 20/24] net: socionext: Demote non-compliant kernel-doc headers
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (18 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 19/24] net: samsung: sxgbe: " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 21/24] net: ti: Fix wrong struct name in comments Yang Shen
                   ` (4 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/socionext/sni_ave.c:28: warning: expecting prototype for sni_ave.c(). Prototype was for AVE_IDR() instead

Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/net/ethernet/socionext/sni_ave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
index fcbb4bb31408..5eb6bb4f7b6c 100644
--- a/drivers/net/ethernet/socionext/sni_ave.c
+++ b/drivers/net/ethernet/socionext/sni_ave.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/**
+/*
  * sni_ave.c - Socionext UniPhier AVE ethernet driver
  * Copyright 2014 Panasonic Corporation
  * Copyright 2015-2017 Socionext Inc.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 21/24] net: ti: Fix wrong struct name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (19 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 20/24] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 22/24] net: via: Fix wrong function " Yang Shen
                   ` (3 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba
  Cc: netdev, linux-kernel, Yang Shen, Cyril Chemparathy, Grygorii Strashko

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/ti/cpsw_ale.c:88: warning: expecting prototype for struct ale_dev_id. Prototype was for struct cpsw_ale_dev_id instead

Cc: Cyril Chemparathy <cyril@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/ti/cpsw_ale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
index d828f856237a..0c75e0576ee1 100644
--- a/drivers/net/ethernet/ti/cpsw_ale.c
+++ b/drivers/net/ethernet/ti/cpsw_ale.c
@@ -70,7 +70,7 @@ enum {
 };
 
 /**
- * struct ale_dev_id - The ALE version/SoC specific configuration
+ * struct cpsw_ale_dev_id - The ALE version/SoC specific configuration
  * @dev_id: ALE version/SoC id
  * @features: features supported by ALE
  * @tbl_entries: number of ALE entries
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 22/24] net: via: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (20 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 21/24] net: ti: Fix wrong struct name in comments Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 23/24] net: phy: Demote non-compliant kernel-doc headers Yang Shen
                   ` (2 subsequent siblings)
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Francois Romieu

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/via/via-velocity.c:1908: warning: expecting prototype for tx_srv(). Prototype was for velocity_tx_srv() instead
 drivers/net/ethernet/via/via-velocity.c:2466: warning: expecting prototype for velocity_get_status(). Prototype was for velocity_get_stats() instead
 drivers/net/ethernet/via/via-velocity.c:3734: warning: expecting prototype for velocity_cleanup(). Prototype was for velocity_cleanup_module() instead

Cc: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/via/via-velocity.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index fecc4d7b00b0..88426b5e410b 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -1897,7 +1897,7 @@ static void velocity_error(struct velocity_info *vptr, int status)
 }
 
 /**
- *	tx_srv		-	transmit interrupt service
+ *	velocity_tx_srv		-	transmit interrupt service
  *	@vptr: Velocity
  *
  *	Scan the queues looking for transmitted packets that
@@ -2453,7 +2453,7 @@ static int velocity_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
 }
 
 /**
- *	velocity_get_status	-	statistics callback
+ *	velocity_get_stats	-	statistics callback
  *	@dev: network device
  *
  *	Callback from the network layer to allow driver statistics
@@ -3723,7 +3723,7 @@ static int __init velocity_init_module(void)
 }
 
 /**
- *	velocity_cleanup	-	module unload
+ *	velocity_cleanup_module		-	module unload
  *
  *	When the velocity hardware is unloaded this function is called.
  *	It will clean up the notifiers and the unregister the PCI
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 23/24] net: phy: Demote non-compliant kernel-doc headers
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (21 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 22/24] net: via: Fix wrong function " Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17  4:45 ` [PATCH v2 24/24] net: hisilicon: hns: Fix wrong function name in comments Yang Shen
  2021-05-17 21:20 ` [PATCH v2 00/24] Rid W=1 warnings in net patchwork-bot+netdevbpf
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba
  Cc: netdev, linux-kernel, Yang Shen, Heiner Kallweit, Russell King

Fixes the following W=1 kernel build warning(s):

 drivers/net/phy/adin.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 drivers/net/phy/rockchip.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/phy/adin.c     | 2 +-
 drivers/net/phy/rockchip.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 55a0b91816e2..5ce6da62cc8e 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0+
-/**
+/*
  *  Driver for Analog Devices Industrial Ethernet PHYs
  *
  * Copyright 2019 Analog Devices Inc.
diff --git a/drivers/net/phy/rockchip.c b/drivers/net/phy/rockchip.c
index 52f1f65320fe..bb13e75183ee 100644
--- a/drivers/net/phy/rockchip.c
+++ b/drivers/net/phy/rockchip.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0+
-/**
+/*
  * drivers/net/phy/rockchip.c
  *
  * Driver for ROCKCHIP Ethernet PHYs
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH v2 24/24] net: hisilicon: hns: Fix wrong function name in comments
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (22 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 23/24] net: phy: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-17  4:45 ` Yang Shen
  2021-05-17 21:20 ` [PATCH v2 00/24] Rid W=1 warnings in net patchwork-bot+netdevbpf
  24 siblings, 0 replies; 28+ messages in thread
From: Yang Shen @ 2021-05-17  4:45 UTC (permalink / raw)
  To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Yisen Zhuang, Salil Mehta

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:121: warning: expecting prototype for hns_mac_is_adjust_link(). Prototype was for hns_mac_need_adjust_link() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:386: warning: expecting prototype for hns_mac_queue_config_bc_en(). Prototype was for hns_mac_port_config_bc_en() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:607: warning: expecting prototype for hns_mac_set_autoneg(). Prototype was for hns_mac_set_pauseparam() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:236: warning: expecting prototype for hns_ppe_qid_cfg(). Prototype was for hns_dsaf_ppe_qid_cfg() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:623: warning: expecting prototype for dsaf_tbl_tcam_mcast_cfg(). Prototype was for hns_dsaf_tbl_tcam_mcast_cfg() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:1220: warning: expecting prototype for hns_dsaf_tbl_tcam_init(). Prototype was for hns_dsaf_comm_init() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2121: warning: expecting prototype for dsaf_pfc_unit_cnt(). Prototype was for hns_dsaf_pfc_unit_cnt() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2153: warning: expecting prototype for dsaf_port_work_rate_cfg(). Prototype was for hns_dsaf_port_work_rate_cfg() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2745: warning: expecting prototype for hns_dsaf_get_sset_count(). Prototype was for hns_dsaf_get_regs_count() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2957: warning: expecting prototype for dsaf_probe(). Prototype was for hns_dsaf_probe() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:3011: warning: expecting prototype for dsaf_remove(). Prototype was for hns_dsaf_remove() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:366: warning: expecting prototype for hns_dsaf_srst_chns(). Prototype was for hns_dsaf_srst_chns_acpi() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:509: warning: expecting prototype for hns_mac_get_sds_mode(). Prototype was for hns_mac_get_phy_if() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:303: warning: expecting prototype for ppe_init_hw(). Prototype was for hns_ppe_init_hw() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:350: warning: expecting prototype for ppe_uninit_hw(). Prototype was for hns_ppe_uninit_hw() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:391: warning: expecting prototype for hns_ppe_reset(). Prototype was for hns_ppe_reset_common() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c:464: warning: expecting prototype for ppe_get_strings(). Prototype was for hns_ppe_get_strings() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c:920: warning: expecting prototype for rcb_get_sset_count(). Prototype was for hns_rcb_get_ring_regs_count() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:112: warning: expecting prototype for hns_xgmac_tx_lf_rf_insert(). Prototype was for hns_xgmac_lf_rf_insert() instead
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c:122: warning: expecting prototype for hns_xgmac__lf_rf_control_init(). Prototype was for hns_xgmac_lf_rf_control_init() instead
 drivers/net/ethernet/hisilicon/hns/hns_enet.c:777: warning: expecting prototype for hns_nic_adp_coalesce(). Prototype was for hns_nic_adpt_coalesce() instead
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:202: warning: expecting prototype for hns_nic_set_link_settings(). Prototype was for hns_nic_set_link_ksettings() instead
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:837: warning: expecting prototype for get_ethtool_stats(). Prototype was for hns_get_ethtool_stats() instead
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:894: warning: expecting prototype for get_strings(). Prototype was for hns_get_strings() instead

Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c    |  6 +++---
 .../net/ethernet/hisilicon/hns/hns_dsaf_main.c   | 16 ++++++++--------
 .../net/ethernet/hisilicon/hns/hns_dsaf_misc.c   |  4 ++--
 .../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c    |  8 ++++----
 .../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c    |  2 +-
 .../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c  |  4 ++--
 drivers/net/ethernet/hisilicon/hns/hns_enet.c    |  2 +-
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c |  6 +++---
 8 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index de6f051f5b0b..f41379de2186 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -111,7 +111,7 @@ int hns_mac_get_port_info(struct hns_mac_cb *mac_cb,
 }
 
 /**
- *hns_mac_is_adjust_link - check is need change mac speed and duplex register
+ *hns_mac_need_adjust_link - check is need change mac speed and duplex register
  *@mac_cb: mac device
  *@speed: phy device speed
  *@duplex:phy device duplex
@@ -374,7 +374,7 @@ static void hns_mac_param_get(struct mac_params *param,
 }
 
 /**
- * hns_mac_queue_config_bc_en - set broadcast rx&tx enable
+ * hns_mac_port_config_bc_en - set broadcast rx&tx enable
  * @mac_cb: mac device
  * @port_num: queue number
  * @vlan_id: vlan id`
@@ -597,7 +597,7 @@ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable)
 }
 
 /**
- * hns_mac_set_autoneg - set rx & tx pause parameter
+ * hns_mac_set_pauseparam - set rx & tx pause parameter
  * @mac_cb: mac control block
  * @rx_en: rx enable or not
  * @tx_en: tx enable or not
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
index c2a60612f503..fcaf5132b865 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -227,7 +227,7 @@ hns_dsaf_reg_cnt_clr_ce(struct dsaf_device *dsaf_dev, u32 reg_cnt_clr_ce)
 }
 
 /**
- * hns_ppe_qid_cfg - config ppe qid
+ * hns_dsaf_ppe_qid_cfg - config ppe qid
  * @dsaf_dev: dsa fabric id
  * @qid_cfg: value array
  */
@@ -613,7 +613,7 @@ static void hns_dsaf_tbl_tcam_data_cfg(
 }
 
 /**
- * dsaf_tbl_tcam_mcast_cfg - tbl
+ * hns_dsaf_tbl_tcam_mcast_cfg - tbl
  * @dsaf_dev: dsa fabric id
  * @mcast: addr
  */
@@ -1213,7 +1213,7 @@ void hns_dsaf_get_rx_mac_pause_en(struct dsaf_device *dsaf_dev, int mac_id,
 }
 
 /**
- * hns_dsaf_tbl_tcam_init - INT
+ * hns_dsaf_comm_init - INT
  * @dsaf_dev: dsa fabric id
  */
 static void hns_dsaf_comm_init(struct dsaf_device *dsaf_dev)
@@ -2111,7 +2111,7 @@ static void hns_dsaf_free_dev(struct dsaf_device *dsaf_dev)
 }
 
 /**
- * dsaf_pfc_unit_cnt - set pfc unit count
+ * hns_dsaf_pfc_unit_cnt - set pfc unit count
  * @dsaf_dev: dsa fabric id
  * @mac_id: id in use
  * @rate:  value array
@@ -2142,7 +2142,7 @@ static void hns_dsaf_pfc_unit_cnt(struct dsaf_device *dsaf_dev, int  mac_id,
 }
 
 /**
- * dsaf_port_work_rate_cfg - fifo
+ * hns_dsaf_port_work_rate_cfg - fifo
  * @dsaf_dev: dsa fabric id
  * @mac_id: mac contrl block
  * @rate_mode: value array
@@ -2738,7 +2738,7 @@ void hns_dsaf_get_strings(int stringset, u8 *data, int port,
 }
 
 /**
- *hns_dsaf_get_sset_count - get dsaf regs count
+ *hns_dsaf_get_regs_count - get dsaf regs count
  *return dsaf regs count
  */
 int hns_dsaf_get_regs_count(void)
@@ -2949,7 +2949,7 @@ int hns_dsaf_wait_pkt_clean(struct dsaf_device *dsaf_dev, int port)
 }
 
 /**
- * dsaf_probe - probo dsaf dev
+ * hns_dsaf_probe - probo dsaf dev
  * @pdev: dasf platform device
  * return 0 - success , negative --fail
  */
@@ -3004,7 +3004,7 @@ static int hns_dsaf_probe(struct platform_device *pdev)
 }
 
 /**
- * dsaf_remove - remove dsaf dev
+ * hns_dsaf_remove - remove dsaf dev
  * @pdev: dasf platform device
  */
 static int hns_dsaf_remove(struct platform_device *pdev)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index 1eaac89d60b7..23d9cbf262c3 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -351,7 +351,7 @@ hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset)
 }
 
 /**
- * hns_dsaf_srst_chns - reset dsaf channels
+ * hns_dsaf_srst_chns_acpi - reset dsaf channels
  * @dsaf_dev: dsaf device struct pointer
  * @msk: xbar channels mask value:
  * @dereset: false - request reset , true - drop reset
@@ -501,7 +501,7 @@ static void hns_ppe_com_srst(struct dsaf_device *dsaf_dev, bool dereset)
 }
 
 /**
- * hns_mac_get_sds_mode - get phy ifterface form serdes mode
+ * hns_mac_get_phy_if - get phy ifterface form serdes mode
  * @mac_cb: mac control block
  * retuen phy interface
  */
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c
index ff03cafccb66..a7eb87da4e70 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c
@@ -296,7 +296,7 @@ int hns_ppe_wait_tx_fifo_clean(struct hns_ppe_cb *ppe_cb)
 }
 
 /**
- * ppe_init_hw - init ppe
+ * hns_ppe_init_hw - init ppe
  * @ppe_cb: ppe device
  */
 static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb)
@@ -343,7 +343,7 @@ static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb)
 }
 
 /**
- * ppe_uninit_hw - uninit ppe
+ * hns_ppe_uninit_hw - uninit ppe
  * @ppe_cb: ppe device
  */
 static void hns_ppe_uninit_hw(struct hns_ppe_cb *ppe_cb)
@@ -382,7 +382,7 @@ void hns_ppe_uninit(struct dsaf_device *dsaf_dev)
 }
 
 /**
- * hns_ppe_reset - reinit ppe/rcb hw
+ * hns_ppe_reset_common - reinit ppe/rcb hw
  * @dsaf_dev: dasf device
  * @ppe_common_index: the index
  * return void
@@ -455,7 +455,7 @@ int hns_ppe_get_regs_count(void)
 }
 
 /**
- * ppe_get_strings - get ppe srting
+ * hns_ppe_get_strings - get ppe srting
  * @ppe_cb: ppe device
  * @stringset: string set type
  * @data: output string
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
index 5d5dc6942232..e2ff3ca198d1 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
@@ -913,7 +913,7 @@ int hns_rcb_get_common_regs_count(void)
 }
 
 /**
- *rcb_get_sset_count - rcb ring regs count
+ *hns_rcb_get_ring_regs_count - rcb ring regs count
  *return regs count
  */
 int hns_rcb_get_ring_regs_count(void)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
index be52acd448f9..401fef5f1d07 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
@@ -104,7 +104,7 @@ static void hns_xgmac_rx_enable(struct mac_driver *drv, u32 value)
 }
 
 /**
- * hns_xgmac_tx_lf_rf_insert - insert lf rf control about xgmac
+ * hns_xgmac_lf_rf_insert - insert lf rf control about xgmac
  * @mac_drv: mac driver
  * @mode: inserf rf or lf
  */
@@ -115,7 +115,7 @@ static void hns_xgmac_lf_rf_insert(struct mac_driver *mac_drv, u32 mode)
 }
 
 /**
- * hns_xgmac__lf_rf_control_init - initial the lf rf control register
+ * hns_xgmac_lf_rf_control_init - initial the lf rf control register
  * @mac_drv: mac driver
  */
 static void hns_xgmac_lf_rf_control_init(struct mac_driver *mac_drv)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
index 5e349c0bdecc..ad534f9e41ab 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -770,7 +770,7 @@ static u32 smooth_alg(u32 new_param, u32 old_param)
 }
 
 /**
- * hns_nic_adp_coalesce - self adapte coalesce according to rx rate
+ * hns_nic_adpt_coalesce - self adapte coalesce according to rx rate
  * @ring_data: pointer to hns_nic_ring_data
  **/
 static void hns_nic_adpt_coalesce(struct hns_nic_ring_data *ring_data)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
index da48c05435ea..7e62dcff2426 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
@@ -192,7 +192,7 @@ static int hns_nic_get_link_ksettings(struct net_device *net_dev,
 }
 
 /**
- *hns_nic_set_link_settings - implement ethtool set link ksettings
+ *hns_nic_set_link_ksettings - implement ethtool set link ksettings
  *@net_dev: net_device
  *@cmd: ethtool_link_ksettings
  *retuen 0 - success , negative --fail
@@ -827,7 +827,7 @@ hns_get_channels(struct net_device *net_dev, struct ethtool_channels *ch)
 }
 
 /**
- * get_ethtool_stats - get detail statistics.
+ * hns_get_ethtool_stats - get detail statistics.
  * @netdev: net device
  * @stats: statistics info.
  * @data: statistics data.
@@ -885,7 +885,7 @@ static void hns_get_ethtool_stats(struct net_device *netdev,
 }
 
 /**
- * get_strings: Return a set of strings that describe the requested objects
+ * hns_get_strings: Return a set of strings that describe the requested objects
  * @netdev: net device
  * @stringset: string set ID.
  * @data: objects data.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* Re: [PATCH v2 17/24] net: netronome: nfp: Fix wrong function name in comments
  2021-05-17  4:45 ` [PATCH v2 17/24] net: netronome: nfp: " Yang Shen
@ 2021-05-17 10:00   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2021-05-17 10:00 UTC (permalink / raw)
  To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel

On Mon, May 17, 2021 at 12:45:28PM +0800, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/ethernet/netronome/nfp/ccm_mbox.c:52: warning: expecting prototype for struct nfp_ccm_mbox_skb_cb. Prototype was for struct nfp_ccm_mbox_cmsg_cb instead
>  drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:35: warning: expecting prototype for struct nfp_tun_pre_run_rule. Prototype was for struct nfp_tun_pre_tun_rule instead
>  drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c:38: warning: expecting prototype for NFFW_INFO_VERSION history(). Prototype was for NFFW_INFO_VERSION_CURRENT() instead
> 
> Cc: Simon Horman <simon.horman@netronome.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>

Reviewed-by: Simon Horman <simon.horman@netronome.com>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH v2 00/24] Rid W=1 warnings in net
  2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
                   ` (23 preceding siblings ...)
  2021-05-17  4:45 ` [PATCH v2 24/24] net: hisilicon: hns: Fix wrong function name in comments Yang Shen
@ 2021-05-17 21:20 ` patchwork-bot+netdevbpf
  24 siblings, 0 replies; 28+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-17 21:20 UTC (permalink / raw)
  To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Mon, 17 May 2021 12:45:11 +0800 you wrote:
> This is 1 of 2 sets to fully clean drivers/net.
> 
> Changes since v1:
>  - add some warnings missed in v1
>  - move the patches about drivers/net/wireless into another series
> 
> Yang Shen (24):
>   net: arc: Demote non-compliant kernel-doc headers
>   net: atheros: atl1c: Fix wrong function name in comments
>   net: atheros: atl1e: Fix wrong function name in comments
>   net: atheros: atl1x: Fix wrong function name in comments
>   net: broadcom: bnx2x: Fix wrong function name in comments
>   net: brocade: bna: Fix wrong function name in comments
>   net: cadence: Demote non-compliant kernel-doc headers
>   net: calxeda: Fix wrong function name in comments
>   net: chelsio: cxgb3: Fix wrong function name in comments
>   net: chelsio: cxgb4: Fix wrong function name in comments
>   net: chelsio: cxgb4vf: Fix wrong function name in comments
>   net: huawei: hinic: Fix wrong function name in comments
>   net: micrel: Fix wrong function name in comments
>   net: microchip: Demote non-compliant kernel-doc headers
>   net: neterion: Fix wrong function name in comments
>   net: neterion: vxge: Fix wrong function name in comments
>   net: netronome: nfp: Fix wrong function name in comments
>   net: calxeda: Fix wrong function name in comments
>   net: samsung: sxgbe: Fix wrong function name in comments
>   net: socionext: Demote non-compliant kernel-doc headers
>   net: ti: Fix wrong struct name in comments
>   net: via: Fix wrong function name in comments
>   net: phy: Demote non-compliant kernel-doc headers
>   net: hisilicon: hns: Fix wrong function name in comments
> 
> [...]

Here is the summary with links:
  - [v2,01/24] net: arc: Demote non-compliant kernel-doc headers
    https://git.kernel.org/netdev/net-next/c/1d7f7ecadc5a
  - [v2,02/24] net: atheros: atl1c: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/8965c1c535b1
  - [v2,03/24] net: atheros: atl1e: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/b43e1554a7cf
  - [v2,04/24] net: atheros: atl1x: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/c706c75aaee2
  - [v2,05/24] net: broadcom: bnx2x: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/76d85049173b
  - [v2,06/24] net: brocade: bna: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/5a02bf4fefd5
  - [v2,07/24] net: cadence: Demote non-compliant kernel-doc headers
    https://git.kernel.org/netdev/net-next/c/c1167cee462d
  - [v2,08/24] net: calxeda: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/2e45d961a6a8
  - [v2,09/24] net: chelsio: cxgb3: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/aeed744a49ba
  - [v2,10/24] net: chelsio: cxgb4: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/e0333b1bb174
  - [v2,11/24] net: chelsio: cxgb4vf: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/1eb00ff517f4
  - [v2,12/24] net: huawei: hinic: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/d6174870c0f1
  - [v2,13/24] net: micrel: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/229fd41f6447
  - [v2,14/24] net: microchip: Demote non-compliant kernel-doc headers
    https://git.kernel.org/netdev/net-next/c/331a3219d3b6
  - [v2,15/24] net: neterion: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/dc432f5acb86
  - [v2,16/24] net: neterion: vxge: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/146c91e2bc9a
  - [v2,17/24] net: netronome: nfp: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/a507b1644524
  - [v2,18/24] net: calxeda: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/9f2e6fb63413
  - [v2,19/24] net: samsung: sxgbe: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/61633d71a71c
  - [v2,20/24] net: socionext: Demote non-compliant kernel-doc headers
    https://git.kernel.org/netdev/net-next/c/40d9fca8b3fd
  - [v2,21/24] net: ti: Fix wrong struct name in comments
    https://git.kernel.org/netdev/net-next/c/85ead77dc3d5
  - [v2,22/24] net: via: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/03055a25213b
  - [v2,23/24] net: phy: Demote non-compliant kernel-doc headers
    https://git.kernel.org/netdev/net-next/c/1f2d109e8363
  - [v2,24/24] net: hisilicon: hns: Fix wrong function name in comments
    https://git.kernel.org/netdev/net-next/c/5a9594cf1d14

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 28+ messages in thread

* RE: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function name in comments
  2021-05-17  4:45 ` [PATCH v2 05/24] net: broadcom: bnx2x: " Yang Shen
@ 2021-05-19  9:30   ` Sudarsana Reddy Kalluru
  0 siblings, 0 replies; 28+ messages in thread
From: Sudarsana Reddy Kalluru @ 2021-05-19  9:30 UTC (permalink / raw)
  To: Yang Shen, davem, kuba
  Cc: netdev, linux-kernel, Ariel Elior, GR-everest-linux-l2

> -----Original Message-----
> From: Yang Shen <shenyang39@huawei.com>
> Sent: Monday, May 17, 2021 10:15 AM
> To: davem@davemloft.net; kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yang Shen
> <shenyang39@huawei.com>; Ariel Elior <aelior@marvell.com>; Sudarsana
> Reddy Kalluru <skalluru@marvell.com>; GR-everest-linux-l2 <GR-everest-
> linux-l2@marvell.com>
> Subject: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function
> name in comments
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13595: warning:
> expecting prototype for bnx2x_get_num_none_def_sbs(). Prototype was for
> bnx2x_get_num_non_def_sbs() instead
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4165: warning:
> expecting prototype for atomic_add_ifless(). Prototype was for
> __atomic_add_ifless() instead
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4193: warning:
> expecting prototype for atomic_dec_ifmoe(). Prototype was for
> __atomic_dec_ifmoe() instead
> 
> Cc: Ariel Elior <aelior@marvell.com>
> Cc: Sudarsana Kalluru <skalluru@marvell.com>
> Cc: GR-everest-linux-l2@marvell.com
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> index 281b1c2e04a7..2acbc73dcd18 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> @@ -13586,7 +13586,7 @@ static int bnx2x_set_qm_cid_count(struct bnx2x
> *bp)  }
> 
>  /**
> - * bnx2x_get_num_none_def_sbs - return the number of none default SBs
> + * bnx2x_get_num_non_def_sbs - return the number of none default SBs
>   * @pdev: pci device
>   * @cnic_cnt: count
>   *
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index 6cd1523ad9e5..542c69822649 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -4152,7 +4152,7 @@ void bnx2x_init_mcast_obj(struct bnx2x *bp,
>  /*************************** Credit handling
> **********************************/
> 
>  /**
> - * atomic_add_ifless - add if the result is less than a given value.
> + * __atomic_add_ifless - add if the result is less than a given value.
>   *
>   * @v:	pointer of type atomic_t
>   * @a:	the amount to add to v...
> @@ -4180,7 +4180,7 @@ static inline bool __atomic_add_ifless(atomic_t *v,
> int a, int u)  }
> 
>  /**
> - * atomic_dec_ifmoe - dec if the result is more or equal than a given value.
> + * __atomic_dec_ifmoe - dec if the result is more or equal than a given
> value.
>   *
>   * @v:	pointer of type atomic_t
>   * @a:	the amount to dec from v...
> --
> 2.17.1

Thanks for the changes.

Acked-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>

^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2021-05-19  9:31 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
2021-05-17  4:45 ` [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 02/24] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 03/24] net: atheros: atl1e: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 04/24] net: atheros: atl1x: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 05/24] net: broadcom: bnx2x: " Yang Shen
2021-05-19  9:30   ` [EXT] " Sudarsana Reddy Kalluru
2021-05-17  4:45 ` [PATCH v2 06/24] net: brocade: bna: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 07/24] net: cadence: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 08/24] net: calxeda: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 09/24] net: chelsio: cxgb3: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 10/24] net: chelsio: cxgb4: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 11/24] net: chelsio: cxgb4vf: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 12/24] net: huawei: hinic: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 13/24] net: micrel: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 14/24] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 15/24] net: neterion: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 16/24] net: neterion: vxge: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 17/24] net: netronome: nfp: " Yang Shen
2021-05-17 10:00   ` Simon Horman
2021-05-17  4:45 ` [PATCH v2 18/24] net: calxeda: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 19/24] net: samsung: sxgbe: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 20/24] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 21/24] net: ti: Fix wrong struct name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 22/24] net: via: Fix wrong function " Yang Shen
2021-05-17  4:45 ` [PATCH v2 23/24] net: phy: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 24/24] net: hisilicon: hns: Fix wrong function name in comments Yang Shen
2021-05-17 21:20 ` [PATCH v2 00/24] Rid W=1 warnings in net patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.