From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C9DC433B4 for ; Mon, 17 May 2021 12:24:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7AEC61242 for ; Mon, 17 May 2021 12:24:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7AEC61242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6561E6E944; Mon, 17 May 2021 12:24:47 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE5466E944 for ; Mon, 17 May 2021 12:24:45 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4CCB767373; Mon, 17 May 2021 14:24:42 +0200 (CEST) Date: Mon, 17 May 2021 14:24:41 +0200 From: "hch@lst.de" To: "Souza, Jose" Message-ID: <20210517122441.GB15150@lst.de> References: <20210513232841.147989-1-jose.souza@intel.com> <20210514054923.GA5323@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "hch@lst.de" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, May 15, 2021 at 12:23:04AM +0000, Souza, Jose wrote: > On Fri, 2021-05-14 at 07:49 +0200, Christoph Hellwig wrote: > > On Thu, May 13, 2021 at 04:28:41PM -0700, Jos=E9 Roberto de Souza wrote: > > > If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first > > > iteration, err is uninitialized causing a wrong call to zap_vma_ptes(= ). > > = > > But scatterlist must have at least one valid segment. So while the > > patch looks ok, please clearly mark that this is a false positive from > > the static checker in the commit log. > = > No static checker mentioned but yes it was caught by one. > Anyways better have this change and avoid possible reports from other sta= tic analyzers. Please also add the information I provided above to put this into context. > = > Can I add your Reviewed-by? With that: Reviewed-by: Christoph Hellwig _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx