From: Alan Stern <stern@rowland.harvard.edu>
To: Oliver Neukum <oneukum@suse.com>
Cc: Qiang Ma <maqianga@uniontech.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse
Date: Mon, 17 May 2021 09:32:47 -0400 [thread overview]
Message-ID: <20210517133247.GB1083813@rowland.harvard.edu> (raw)
In-Reply-To: <1327a9251c74587670970baa0f662cd61006f576.camel@suse.com>
On Mon, May 17, 2021 at 10:31:45AM +0200, Oliver Neukum wrote:
> Am Montag, den 17.05.2021, 14:01 +0800 schrieb Qiang Ma:
> > This patch enables remote wakeup by default for USB mouse
> > devices. Mouse in general are supposed to be wakeup devices, but
I disagree with that statement. Who decided that mice are supposed to
be wakeup devices?
> > the correct place to enable it depends on the device's bus; no single
> > approach will work for all mouse devices. In particular, this
> > covers only USB mouse (and then only those supporting the boot
> > protocol).
> >
>
> Hi,
>
> have you tested this? In my experience the issue with mice
> is that they wake up only when you press a mouse button, not when you
> move the mouse. Do we make a promise we cannot keep here?
Even worse, if a mouse is enabled for wakeup then the system may get
woken up at the wrong time. The example people often use is a laptop
with a USB mouse thrown into a backpack while it is asleep. Something
else inside the backpack may accidentally press against a mouse button,
causing the system to wake up even though the user wants it to remain
asleep.
Alan Stern
next prev parent reply other threads:[~2021-05-17 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 6:01 [PATCH] HID: usbhid: enable remote wakeup for mouse Qiang Ma
2021-05-17 8:31 ` Oliver Neukum
2021-05-17 13:32 ` Alan Stern [this message]
[not found] ` <1209199573.51584.1621492845444.JavaMail.xmail@bj-wm-cp-1>
2021-05-25 9:55 ` Oliver Neukum
2021-05-17 8:58 ` Greg KH
[not found] ` <1547909475.114060.1621244274064.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 9:46 ` Greg KH
[not found] ` <1781917892.119659.1621247946603.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 10:42 ` Greg KH
[not found] ` <440071991.120491.1621248757251.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 11:19 ` Greg KH
[not found] ` <671637326.122188.1621250895330.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 11:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517133247.GB1083813@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maqianga@uniontech.com \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.