From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC47C433ED for ; Mon, 17 May 2021 18:54:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 963B461057 for ; Mon, 17 May 2021 18:54:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 963B461057 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liiNl-0006vv-ND for qemu-devel@archiver.kernel.org; Mon, 17 May 2021 14:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lihlv-0006pi-Ih for qemu-devel@nongnu.org; Mon, 17 May 2021 14:15:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:48215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lihlZ-0004Xm-9z for qemu-devel@nongnu.org; Mon, 17 May 2021 14:15:19 -0400 Received: from quad ([82.142.31.78]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MQy0N-1m5aEY3SfH-00O0co; Mon, 17 May 2021 20:14:50 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 45/59] linux-user/s390x: Add build asserts for sigset sizes Date: Mon, 17 May 2021 20:14:10 +0200 Message-Id: <20210517181424.8093-46-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517181424.8093-1-laurent@vivier.eu> References: <20210517181424.8093-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:R6HjJXjyG1ZInBrhVPsshMwqybr4sLAVUEny48o6ZhIf1mi7PzT +PZTF1WmyhaFwMNsvATMX0RKeFdOEhokugXuGupyd/cFeQnOUBpIxVxGELitlxUc7fbUP8o 4aAHZY3ae0iN60PbQewzm9o+v7mfqUD9DhpNot1aFloecxBhuIDbhedXFNn075sbeqFaTMr 6efYBRbsHc4FEEbNN7ZbQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Z9d6FwXX8vc=:1PwEbhzYXdRekt/aMv7H+Q XRy473ldfFu+pAVKNpeN//U4oez2RfzHHX/8QpcibWXWnbV66guC5rX0VdePq0NCUymdnN2mk 5w4DUga+ApS2eRvM7bXt8kOW6HBNaTBtaFAsdQqQTuL356V9RyMnMF3uf1Cm3ik3NZZw0D7Wy 3sOPfyy7gm16ToHVQRg3O24U/kMUlKOvrWSNvRxypzfsK8gRWMzNAASf1Qi0nbfOQ6pH08gYb rvMWx1bOGajXtx6vrnOJM1CYQlJUei23cK+bPgiQzIl6OvCzQ9KjX4lytjp89BPwK8obeRj7Z 43ODrKnCFXI95qouhGInUCfOp6zu+TnI/BuKEvZc85toaoq3j0fkvBYHuJU5OhEEdvoyJZreL zsSGQA8ed59Hy/jObXoplGNH6P3ElU5zQcW/Ig/Ab/eNsHmkmRkMQevSuKIU3JgfaVr58pVMp 71jWx7rPN85YjC+DXNQJluSL2PVu6CTztBTk6+p0qAvWqU1s3yMFTcmAlaYOF5StAzw/Eabl8 AaNAoafOf3Se+GyuDD4isU= Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Laurent Vivier , David Hildenbrand Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson At point of usage, it's not immediately obvious that we don't need a loop to copy these arrays. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-14-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 81ba59b46af5..839a7ae4b3d6 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -141,6 +141,8 @@ void setup_frame(int sig, struct target_sigaction *ka, return; } + /* Make sure that we're initializing all of oldmask. */ + QEMU_BUILD_BUG_ON(ARRAY_SIZE(frame->sc.oldmask) != 1); __put_user(set->sig[0], &frame->sc.oldmask[0]); save_sigregs(env, &frame->sregs); @@ -266,6 +268,9 @@ long do_sigreturn(CPUS390XState *env) force_sig(TARGET_SIGSEGV); return -TARGET_QEMU_ESIGRETURN; } + + /* Make sure that we're initializing all of target_set. */ + QEMU_BUILD_BUG_ON(ARRAY_SIZE(target_set.sig) != 1); __get_user(target_set.sig[0], &frame->sc.oldmask[0]); target_to_host_sigset_internal(&set, &target_set); -- 2.31.1