From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEBB071 for ; Mon, 17 May 2021 20:34:05 +0000 (UTC) Received: by mail-qv1-f46.google.com with SMTP id v18so3813438qvx.10 for ; Mon, 17 May 2021 13:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZxYJhTuM2LR07AUba1x1umGGRXOkQsAno3p7Ab7UDtI=; b=K4hTWOrvhYSxkFOXjGlNnlb1np9ZZdlEjAiyZWxAIPdJJE1JTnXoXGA1GlpvscCDEg CypLl+Soj7ZlizZV/i0oV7ooCJUdUdNsjE7q+qEehJAnnZ858Dg9oWP3JhLI6U6BBwc0 FxcGGVaxbooOsDPdysss/JLMgfP+f6GY8Iw+C+D+T6nznilyIh+hhs8x/KyWtTR8flta YVGQFauXN0cCK3eY/9Vchhxldac41XBaZmkWuB4NVt7OojPKdVPMVqEwkZC8Tm78yJcG cUSOMc5+B9M5ru6EjtrxgqNc/HufyXaxv4LlDNMJiCULRIV8W69xesCfuua+U9YGTvWQ wFeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=ZxYJhTuM2LR07AUba1x1umGGRXOkQsAno3p7Ab7UDtI=; b=aYhcx5W74w4lAtnUgUTFaLqSHfgfrWHTG3E2uxj76AbVqqq9dZJM6IrzWr/k7v+FG6 wnNEwaLK8B/KDydVWSMHdD/k/M+Vlndh64FwptVmKFqudHL4eV5BBCBP1HVLGyiictd7 e3leF+QJOT+PEkXP2huj4OJnX4bjbZqn0W/2wLNuTnwUHp8KlUq8xmn5pR1OHZo4d4Cu kIniQKoYNvgGUetVhx37Lsm30BoKOMeAquiDe37BIPFJnQVLKpwVlZEWMDbxT9mMAZNT vxCdphm8hG/fD2BKSdWmv12SgDDZ2oLCYmlwf7So0EwHr4Tj3sKabx/2x1G7kWocxU9q vHag== X-Gm-Message-State: AOAM530HXSvP7STZSXwq19eMx9xPPKWW+zqfN7EpVzFdqhO1JdOWL/lI zY6TKMsGNKu13DT7knphAW4= X-Google-Smtp-Source: ABdhPJxXDD9sg2F9fb/HUA86Sm3Lc7DoFByJMnFcUpoGHe7g4MwnuYf2eWKkhVRFvS2m7yf7Bnx3ow== X-Received: by 2002:ad4:5f87:: with SMTP id jp7mr1586579qvb.46.1621283644817; Mon, 17 May 2021 13:34:04 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id o26sm11206336qkm.4.2021.05.17.13.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 13:34:04 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 17 May 2021 13:34:03 -0700 From: Guenter Roeck To: Martin Kaiser Cc: Larry Finger , Greg Kroah-Hartman , Christophe JAILLET , Dan Carpenter , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/6] staging: rtl8188eu: use safe iterator in rtw_acl_remove_sta Message-ID: <20210517203403.GD3620180@roeck-us.net> References: <20210516160613.30489-1-martin@kaiser.cx> <20210517201826.25150-1-martin@kaiser.cx> <20210517201826.25150-4-martin@kaiser.cx> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517201826.25150-4-martin@kaiser.cx> On Mon, May 17, 2021 at 10:18:24PM +0200, Martin Kaiser wrote: > Use list_for_each_entry_safe, we may delete list items while iterating > over the list. > > Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers") > Signed-off-by: Martin Kaiser Reviewed-by: Guenter Roeck > --- > v2: > - use list_for_each_entry_safe > > drivers/staging/rtl8188eu/core/rtw_ap.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c > index 6d7c96f1aa42..d297d5301153 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_ap.c > +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c > @@ -1068,8 +1068,8 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr) > > int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr) > { > - struct list_head *plist, *phead; > - struct rtw_wlan_acl_node *paclnode; > + struct list_head *phead; > + struct rtw_wlan_acl_node *paclnode, *temp; > struct sta_priv *pstapriv = &padapter->stapriv; > struct wlan_acl_pool *pacl_list = &pstapriv->acl_list; > struct __queue *pacl_node_q = &pacl_list->acl_node_q; > @@ -1079,9 +1079,7 @@ int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr) > spin_lock_bh(&pacl_node_q->lock); > > phead = get_list_head(pacl_node_q); > - list_for_each(plist, phead) { > - paclnode = list_entry(plist, struct rtw_wlan_acl_node, list); > - > + list_for_each_entry_safe(paclnode, temp, phead, list) { > if (!memcmp(paclnode->addr, addr, ETH_ALEN)) { > if (paclnode->valid) { > paclnode->valid = false; > -- > 2.20.1 >