From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04CFFC43462 for ; Tue, 18 May 2021 14:13:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D338F611BF for ; Tue, 18 May 2021 14:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349802AbhEROOU (ORCPT ); Tue, 18 May 2021 10:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349844AbhEROOH (ORCPT ); Tue, 18 May 2021 10:14:07 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F3C8C061573 for ; Tue, 18 May 2021 07:12:49 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id q2so7461798pfh.13 for ; Tue, 18 May 2021 07:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heitbaum.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SPfPtCLbzkmNg1kSYw7mvxQUWmbeLInogT4WAGPjSVM=; b=nO7TWl3baJhp4LD8iNn0IfBKlXcwmSHmTgGg+shGfU2jyyksQ5FI9s9g2+ZJ7dBpHK 9oiWLxbhMVp9mCqqNzfaun6OOo1IwVP5ttnL4/UBwotFAeO1v6pOC0KXuRd3mLS7TWCO KTknXiAPPWQlrnoPg2kpCtFMBHQa7B3rkCJdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SPfPtCLbzkmNg1kSYw7mvxQUWmbeLInogT4WAGPjSVM=; b=M2IEBtdbDdECHiS60PXIl+bzlbvvUzVaIKmScBZsqRAYxyH+o4SqnvGpF/E3SB40RZ LiOyror3nDeVlz1/QETsYFW7x0Zmmkf0YLjaL9KbWo69r7j19WAFUC9UaZhk3G2ESMSm /vkAIRLVjHPYVZSWdVKfpIGa0m1rgdpPC3ZNgQKmfx8jWDzzM7aOWsLr7t3fq8Nq6gnG imlBSlg+CRFGw+aV6PvJqRY+M72Rzm9wXWeMPb9PqGDFUzom2kvOrfukTxf2/7VoCG/V x/wB9uHXqkj9hAIAW+ZqnDD2mwKtR9vxe2T+svdFVseEmjJINAl4jtyfQXaqK2dJBbnX 8v0g== X-Gm-Message-State: AOAM532AANDCWoZLVdKvOo4wt4LNwzx+gPfs7eKrKBHgEVqtzO7hbQbN iLIYJ8yXn5r2IYPTbgO4r33gRA== X-Google-Smtp-Source: ABdhPJxT5F2/6+OjX9ZFD2Wd8LwQ9UtJtdyI+2KeJSeu0ns9RtNDermYQJTnW/il3ApxTCadVWasww== X-Received: by 2002:a63:f65:: with SMTP id 37mr5256201pgp.239.1621347168722; Tue, 18 May 2021 07:12:48 -0700 (PDT) Received: from 416f1e4b4f0c (110-175-118-133.tpgi.com.au. [110.175.118.133]) by smtp.gmail.com with ESMTPSA id c6sm12092568pfo.192.2021.05.18.07.12.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 May 2021 07:12:48 -0700 (PDT) Date: Tue, 18 May 2021 14:12:42 +0000 From: Rudi Heitbaum To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.12 081/363] net: bridge: propagate error code and extack from br_mc_disabled_update Message-ID: <20210518141238.GA20@416f1e4b4f0c> References: <20210517140302.508966430@linuxfoundation.org> <20210517140305.339768334@linuxfoundation.org> <20210518122449.GA65@ec3d6f83b95b> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 02:39:43PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 18, 2021 at 12:24:57PM +0000, Rudi Heitbaum wrote: > > On Mon, May 17, 2021 at 03:59:07PM +0200, Greg Kroah-Hartman wrote: > > > From: Florian Fainelli > > > > > > [ Upstream commit ae1ea84b33dab45c7b6c1754231ebda5959b504c ] > > > > > > Some Ethernet switches might only be able to support disabling multicast > > > snooping globally, which is an issue for example when several bridges > > > span the same physical device and request contradictory settings. > > > > > > Propagate the return value of br_mc_disabled_update() such that this > > > limitation is transmitted correctly to user-space. > > > > > > Signed-off-by: Florian Fainelli > > > Signed-off-by: Vladimir Oltean > > > Signed-off-by: David S. Miller > > > Signed-off-by: Sasha Levin > > > --- > > > net/bridge/br_multicast.c | 28 +++++++++++++++++++++------- > > > net/bridge/br_netlink.c | 4 +++- > > > net/bridge/br_private.h | 3 ++- > > > net/bridge/br_sysfs_br.c | 8 +------- > > > 4 files changed, 27 insertions(+), 16 deletions(-) > > > > This patch results in docker failing to start, and a regression between > > 5.12.4 and 5.12.5-rc1 > > > > A working dmesg output is like: > > > > [ 11.545255] device eth0 entered promiscuous mode > > [ 11.693848] process 'docker/tmp/qemu-check643160757/check' started with executable stack > > [ 17.233059] br-92020c7e3aea: port 1(veth17a0552) entered blocking state > > [ 17.233065] br-92020c7e3aea: port 1(veth17a0552) entered disabled state > > [ 17.233098] device veth17a0552 entered promiscuous mode > > [ 17.292839] docker0: port 2(veth9d227f5) entered blocking state > > [ 17.292848] docker0: port 2(veth9d227f5) entered disabled state > > [ 17.292946] device veth9d227f5 entered promiscuous mode > > [ 17.293070] docker0: port 2(veth9d227f5) entered blocking state > > [ 17.293075] docker0: port 2(veth9d227f5) entered forwarding state > > > > with this patch "device veth17a0552 entered promiscuous mode" never > > shows up. > > > > the docker error itself is: > > > > docker: Error response from daemon: failed to create endpoint > > sleepy_dijkstra on network bridge: adding interface veth8cbd8f9 to > > bridge docker0 failed: operation not supported. > > Ick. > > Does 5.13-rc1 also show this same problem? > > And thanks for testing! > > greg k-h Hi Greg, I can confirm that docker starts correctly with 5.13-rc1 # dmesg | head [ 0.000000] Linux version 5.13.0-rc1 (rudi@0e5f93d4a8a2) (x86_64-libreelec-linux-gnu-gcc-10.3.0 (GCC) 10.3.0, GNU ld (GNU Binutils) 2.36.1) #1 SMP Tue May 18 14:00:41 UTC 2021 [ 0.000000] Command line: BOOT_IMAGE=/KERNEL boot=LABEL=LIBREELEC disk=LABEL=STORAGE i915.enable_guc=2 quiet ... [ 11.214582] docker0: port 1(veth2b37ac4) entered blocking state [ 11.214589] docker0: port 1(veth2b37ac4) entered disabled state [ 11.214649] device veth2b37ac4 entered promiscuous mode [ 11.214752] docker0: port 1(veth2b37ac4) entered blocking state [ 11.214755] docker0: port 1(veth2b37ac4) entered forwarding state Regards Rudi