From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python3-six: add python3 variant
Date: Wed, 19 May 2021 14:00:15 +0200 [thread overview]
Message-ID: <20210519120015.GU2268078@scaer> (raw)
In-Reply-To: <1621370634009.93154@lab126.com>
Chan, All,
On 2021-05-18 20:43 +0000, Chan, Donald spake thusly:
> On 2021-05-12 20:59 +0000, Chan, Donald via buildroot spake thusly:
> >> Signed-off-by: Donald Chan <hoiho@lab126.com>
> >Why do you need a python3-specific version of six?
> This was for the host side Python packages
Your patch was adding both the target and the host variants, though.
> - I see the same patterns
> for other python packages like
> - python3-requests/python3-requests.mk
> - python3-mako/python3-mako.mk
Ah, but those were added because we have a need for them: in some
situations, we need to have both the python2 and python3 modules for
those installed at the same time.
For example:
$ git grep -E 'host-python3?-mako'
package/gnuradio/gnuradio.mk:# host-python-mako and host-python-six are needed for volk to compile
package/gnuradio/gnuradio.mk: host-python-mako \
package/jailhouse/jailhouse.mk: host-python-mako \
package/mesa3d/mesa3d.mk: host-python3-mako \
package/piglit/piglit.mk: host-python-mako \
package/sdbusplus/sdbusplus.mk: host-python-mako \
package/uhd/uhd.mk: host-python-mako
So, as you can see, we have packages that need the python2 host mako,
and others (one, really) that needs the python3 host mako. The situation
is similar for the other python3-specific packages.
> Let me me know if this makes sense.
Yeah, I see the reasoning, but we are only adding the python3-specific
variant when there is an actual need for it.
If you can provide such an example that a specific host-python3-six
is needed, do not hesitate to resend your patch with such an explanation
in your commit log.
Thanks again for your contribution!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-05-19 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 20:59 [Buildroot] [PATCH 1/1] package/python3-six: add python3 variant Chan, Donald
2021-05-18 15:00 ` Yann E. MORIN
2021-05-18 20:43 ` Chan, Donald
2021-05-19 12:00 ` Yann E. MORIN [this message]
2021-05-19 21:00 ` Chan, Donald
2021-05-19 21:08 ` Yann E. MORIN
2021-05-20 1:50 ` Chan, Donald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519120015.GU2268078@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.