All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3
Date: Wed, 19 May 2021 14:39:39 +0200	[thread overview]
Message-ID: <20210519123939.GV2268078@scaer> (raw)
In-Reply-To: <20210519141910.0af4f949@windsurf.orange-hotspot>

Thomas, Eugen, All,

On 2021-05-19 14:19 +0200, Thomas Petazzoni spake thusly:
> On Wed, 19 May 2021 11:29:23 +0000
> <Eugen.Hristev@microchip.com> wrote:
> > > diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
> > > index 18301a0dc0..966e393db5 100644
> > > --- a/boot/at91bootstrap3/Config.in
> > > +++ b/boot/at91bootstrap3/Config.in
> > > @@ -101,3 +101,11 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_CONFIG_FILE
> > >            Path to the at91bootstrap3 configuration file
> > > 
> > >   endif # BR2_TARGET_AT91BOOTSTRAP3
> > > +
> > > +config BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3
> > > +       bool "needs host-python3"  
> > This prompt that appears in menuconfig is a bit unfriendly : it does not 
> > say who needs the host-python3, and it does not appear to be in the 
> > at91bootstrap3 -related options.
> > It is at the same indentation level as the other bootloaders, like 
> > Barebox, Grub, etc. So I think it's misleading and should be aligned 
> > with the other At91bootstrap options
> 
> Crap, you're entirely right, it is misplaced: it should have been just
> two line above, within the if BR2_TARGET_AT91BOOTSTRAP3 ... endif block.
> 
> Unless someone beats me at it, I'll send a patch fixing that.

I've just pushed the fix.

> Thanks for spotting this!

Yes, thanks for spotting it! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-05-19 12:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 21:37 [Buildroot] [PATCH 0/3] My take on the at91bootstrap 4.x story Thomas Petazzoni
2021-05-18 21:37 ` [Buildroot] [PATCH 1/3] boot/at91bootstrap3: add support for at91bootstrap 4.x series Thomas Petazzoni
2021-05-19  9:33   ` Yann E. MORIN
2021-05-19 10:02     ` Thomas Petazzoni
2021-05-19 11:36       ` Eugen.Hristev at microchip.com
2021-05-19 12:20         ` Thomas Petazzoni
2021-05-19 12:29           ` Eugen.Hristev at microchip.com
2021-06-14  9:01             ` Eugen.Hristev at microchip.com
2021-06-14 12:28               ` Thomas Petazzoni
2021-06-14 19:25               ` Arnout Vandecappelle
2021-07-07 10:29                 ` Eugen.Hristev at microchip.com
2021-05-19 19:44       ` Edgar Bonet
2021-05-18 21:37 ` [Buildroot] [PATCH 2/3] boot/at91bootstrap3: bump 3.x series to 3.10.2 Thomas Petazzoni
2021-05-18 21:37 ` [Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3 Thomas Petazzoni
2021-05-19 11:29   ` Eugen.Hristev at microchip.com
2021-05-19 12:19     ` Thomas Petazzoni
2021-05-19 12:39       ` Yann E. MORIN [this message]
2021-05-19  9:34 ` [Buildroot] [PATCH 0/3] My take on the at91bootstrap 4.x story Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519123939.GV2268078@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.