* [Bluez PATCH] lib/uuid: Fix string to uuid32 conversion
@ 2021-05-19 8:21 Archie Pusaka
2021-05-19 8:45 ` [Bluez] " bluez.test.bot
2021-05-23 16:24 ` [Bluez PATCH] " Archie Pusaka
0 siblings, 2 replies; 4+ messages in thread
From: Archie Pusaka @ 2021-05-19 8:21 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz
Cc: CrosBT Upstreaming, Archie Pusaka, Yun-Hao Chung
From: Archie Pusaka <apusaka@chromium.org>
Use strtoul to prevent 32 bit overflow
Reviewed-by: Yun-Hao Chung <howardchung@chromium.org>
---
lib/uuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/uuid.c b/lib/uuid.c
index a09321dc6e..3d97dc8359 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -209,7 +209,7 @@ static int bt_string_to_uuid32(bt_uuid_t *uuid, const char *string)
uint32_t u32;
char *endptr = NULL;
- u32 = strtol(string, &endptr, 16);
+ u32 = strtoul(string, &endptr, 16);
if (endptr && *endptr == '\0') {
bt_uuid32_create(uuid, u32);
return 0;
--
2.31.1.751.gd2f1c929bd-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [Bluez] lib/uuid: Fix string to uuid32 conversion
2021-05-19 8:21 [Bluez PATCH] lib/uuid: Fix string to uuid32 conversion Archie Pusaka
@ 2021-05-19 8:45 ` bluez.test.bot
2021-05-23 16:24 ` [Bluez PATCH] " Archie Pusaka
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2021-05-19 8:45 UTC (permalink / raw)
To: linux-bluetooth, apusaka
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=484827
---Test result---
Test Summary:
CheckPatch PASS 0.30 seconds
GitLint PASS 0.11 seconds
Prep - Setup ELL PASS 41.04 seconds
Build - Prep PASS 0.10 seconds
Build - Configure PASS 7.18 seconds
Build - Make PASS 176.76 seconds
Make Check PASS 9.02 seconds
Make Distcheck PASS 210.36 seconds
Build w/ext ELL - Configure PASS 7.24 seconds
Build w/ext ELL - Make PASS 166.42 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bluez PATCH] lib/uuid: Fix string to uuid32 conversion
2021-05-19 8:21 [Bluez PATCH] lib/uuid: Fix string to uuid32 conversion Archie Pusaka
2021-05-19 8:45 ` [Bluez] " bluez.test.bot
@ 2021-05-23 16:24 ` Archie Pusaka
2021-05-24 20:18 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 4+ messages in thread
From: Archie Pusaka @ 2021-05-23 16:24 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz
Cc: CrosBT Upstreaming, Archie Pusaka, Yun-Hao Chung
Hi Luiz,
A friendly ping to review this patch. Thanks!
Cheers,
Archie
On Wed, 19 May 2021 at 16:21, Archie Pusaka <apusaka@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> Use strtoul to prevent 32 bit overflow
>
> Reviewed-by: Yun-Hao Chung <howardchung@chromium.org>
> ---
>
> lib/uuid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/uuid.c b/lib/uuid.c
> index a09321dc6e..3d97dc8359 100644
> --- a/lib/uuid.c
> +++ b/lib/uuid.c
> @@ -209,7 +209,7 @@ static int bt_string_to_uuid32(bt_uuid_t *uuid, const char *string)
> uint32_t u32;
> char *endptr = NULL;
>
> - u32 = strtol(string, &endptr, 16);
> + u32 = strtoul(string, &endptr, 16);
> if (endptr && *endptr == '\0') {
> bt_uuid32_create(uuid, u32);
> return 0;
> --
> 2.31.1.751.gd2f1c929bd-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bluez PATCH] lib/uuid: Fix string to uuid32 conversion
2021-05-23 16:24 ` [Bluez PATCH] " Archie Pusaka
@ 2021-05-24 20:18 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-24 20:18 UTC (permalink / raw)
To: Archie Pusaka
Cc: linux-bluetooth, CrosBT Upstreaming, Archie Pusaka, Yun-Hao Chung
Hi Archie,
On Sun, May 23, 2021 at 9:24 AM Archie Pusaka <apusaka@google.com> wrote:
>
> Hi Luiz,
>
> A friendly ping to review this patch. Thanks!
>
> Cheers,
> Archie
>
> On Wed, 19 May 2021 at 16:21, Archie Pusaka <apusaka@google.com> wrote:
> >
> > From: Archie Pusaka <apusaka@chromium.org>
> >
> > Use strtoul to prevent 32 bit overflow
> >
> > Reviewed-by: Yun-Hao Chung <howardchung@chromium.org>
> > ---
> >
> > lib/uuid.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/uuid.c b/lib/uuid.c
> > index a09321dc6e..3d97dc8359 100644
> > --- a/lib/uuid.c
> > +++ b/lib/uuid.c
> > @@ -209,7 +209,7 @@ static int bt_string_to_uuid32(bt_uuid_t *uuid, const char *string)
> > uint32_t u32;
> > char *endptr = NULL;
> >
> > - u32 = strtol(string, &endptr, 16);
> > + u32 = strtoul(string, &endptr, 16);
> > if (endptr && *endptr == '\0') {
> > bt_uuid32_create(uuid, u32);
> > return 0;
> > --
> > 2.31.1.751.gd2f1c929bd-goog
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-24 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 8:21 [Bluez PATCH] lib/uuid: Fix string to uuid32 conversion Archie Pusaka
2021-05-19 8:45 ` [Bluez] " bluez.test.bot
2021-05-23 16:24 ` [Bluez PATCH] " Archie Pusaka
2021-05-24 20:18 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.