From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA82EC433B4 for ; Wed, 19 May 2021 19:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B159061355 for ; Wed, 19 May 2021 19:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbhEST3h (ORCPT ); Wed, 19 May 2021 15:29:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:55356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhEST3g (ORCPT ); Wed, 19 May 2021 15:29:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B05376112F; Wed, 19 May 2021 19:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621452496; bh=Lk3jBXuZ1fbFKB/aRqyOiK+TZ31lR6R/DqCsZCHeyEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q/MjRkDkEUJHWvk6moJrajtdTG8RF0swjf0bCI4Vdb4EmT6ylLtmd0iZsVEWtUaez N0zDtwsciGX9NKoSSWIW9vXCnlFYTucJ041dkBmZ7e1rJTw6V6L9o1eO4NJoZcwYev qS3DSPd1FpvaSI6Sfiz7ZEO3R3iPhp4J4g+F5HAeK6ySmSFrKH3HtotHWnMZnC7Gx6 2tqNDQ5LHLPzEaEYmljAv0QvToq85+lyXOSOCfWls5vVeu302LIjsvszYSWAjCNW6K zEJ5dAIT8tkn2H3SmKz0NmdocR/BdTeZ71PtnhnxszAR309iQRJbOn9qXlzHOWKguW DeYimFe9qtJbA== Date: Wed, 19 May 2021 20:27:30 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v4 2/2] arm64: Create a list of SYM_CODE functions, blacklist them in the unwinder Message-ID: <20210519192730.GI4224@sirena.org.uk> References: <68eeda61b3e9579d65698a884b26c8632025e503> <20210516040018.128105-1-madvenka@linux.microsoft.com> <20210516040018.128105-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MPkR1dXiUZqK+927" Content-Disposition: inline In-Reply-To: <20210516040018.128105-3-madvenka@linux.microsoft.com> X-Cookie: There's no time like the pleasant. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MPkR1dXiUZqK+927 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 15, 2021 at 11:00:18PM -0500, madvenka@linux.microsoft.com wrot= e: > From: "Madhavan T. Venkataraman" >=20 > The unwinder should check if the return PC falls in any function that > is considered unreliable from an unwinding perspective. If it does, > mark the stack trace unreliable. Other than the naming issue this makes sense to me, I'll try to go through the first patch properly in the next few days. --MPkR1dXiUZqK+927 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmClZqEACgkQJNaLcl1U h9B77Qf+M9+zHwxJNPl/vKY7Sle87Tgz3CrLIzIALiGlYZoKR6GmoGp1x+pA8XGw M/yVldVJE3DfEwBe5mPKLX+35CbSSyoAzAC00+KV66IwxaDbiAIFAMCtDfMh0tCr QFaglXXmWV6g4viO/v2+kpFY9PIhmUzyp3VtFFmaVaIdTmRiLx4+1UAGcmqMMopB CRIgjuaf0wsvwnXFQNqMxjrCx1ndY3XTHwRkxX5+06b8vUoIsqbZ1kvhNQz/cu39 DWSn9OE2R1mIFwhG26yeONdeRUGXSYt7AmyRt7lcXX94v4J77FzrWfxJ5WaJPhz1 MzcC6sZOVksed1e2vOwEpcDz53Y/gg== =+c7T -----END PGP SIGNATURE----- --MPkR1dXiUZqK+927-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BB5C433ED for ; Wed, 19 May 2021 19:33:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 521DE6112F for ; Wed, 19 May 2021 19:33:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 521DE6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hpAAPBjCuNPVZZ4o60vH7q5b5/PL4oL0KL4GJaoKl0Y=; b=K3ENC2G3cXZThSl+U3GU1d51o ymZMv1/fa2U6elH3fcmRt3tUk37Tl7z+e060If/yxrESf7y3AyHRJvIcUPD98dxIN4cpf1Zl2HE47 q+tNlIWI0lq2iH3kLiz5FgQwqjXI3sAOAFpsDgTmJaL5VyUcLwA1JWsdV1h4j55/oQhDuankNHh3V s7k5H2vxpEzQVbTx0w23MP2sWrMdEwEUYNMGeLJzXPh9GeKP8xoUDgV9pcAK/qCcRLFKfd7xqWxwF HHE0peJ2xlhKvTvIqpob/IyQl9Y8Kx7NrIcF4FlnZ+ez2L7ftrvgVsr2LBXhiSmMKth2v/CSUqI+4 UasqLWlMg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljRv8-004u0v-5x; Wed, 19 May 2021 19:31:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljRrh-004tDv-61 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 19:28:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lk3jBXuZ1fbFKB/aRqyOiK+TZ31lR6R/DqCsZCHeyEM=; b=bhA/9RQMQ8qXZhA6L1L+SXT+Zg e1tjCSGLg/4R8QNq+jONPv1bscsRAV8cIRcGJoQo+qk6mwyfxrFYAAioFrj2FXCLr0YNUyL/GZVUP LMbGbjNeVnR7grBk1U5Y4/rc3CjMgWY5Wtt9CeX2b6Jo/L5NfXRqnAWEJhApd2z97pHsLXWMutNbZ Ba4fAvJLMZOKNktzNXIQcJUpMsRAaA+Hf/qB+K/J8iDx3MmcVwlO0Zyeh/MNFGkNLQYQfcnI0P0Sr bg+eHIHGwoEfPISPBZG3PHXsr7L9SGYorMSYURwqGYxVWG1mmhKG9mZPj2CRAkbR1reO7NCmzlZDx Yls4yOsw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljRrc-00FjgT-Lv for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 19:28:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B05376112F; Wed, 19 May 2021 19:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621452496; bh=Lk3jBXuZ1fbFKB/aRqyOiK+TZ31lR6R/DqCsZCHeyEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q/MjRkDkEUJHWvk6moJrajtdTG8RF0swjf0bCI4Vdb4EmT6ylLtmd0iZsVEWtUaez N0zDtwsciGX9NKoSSWIW9vXCnlFYTucJ041dkBmZ7e1rJTw6V6L9o1eO4NJoZcwYev qS3DSPd1FpvaSI6Sfiz7ZEO3R3iPhp4J4g+F5HAeK6ySmSFrKH3HtotHWnMZnC7Gx6 2tqNDQ5LHLPzEaEYmljAv0QvToq85+lyXOSOCfWls5vVeu302LIjsvszYSWAjCNW6K zEJ5dAIT8tkn2H3SmKz0NmdocR/BdTeZ71PtnhnxszAR309iQRJbOn9qXlzHOWKguW DeYimFe9qtJbA== Date: Wed, 19 May 2021 20:27:30 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v4 2/2] arm64: Create a list of SYM_CODE functions, blacklist them in the unwinder Message-ID: <20210519192730.GI4224@sirena.org.uk> References: <68eeda61b3e9579d65698a884b26c8632025e503> <20210516040018.128105-1-madvenka@linux.microsoft.com> <20210516040018.128105-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <20210516040018.128105-3-madvenka@linux.microsoft.com> X-Cookie: There's no time like the pleasant. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_122816_756748_B0258A41 X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3967763201602129069==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3967763201602129069== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MPkR1dXiUZqK+927" Content-Disposition: inline --MPkR1dXiUZqK+927 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 15, 2021 at 11:00:18PM -0500, madvenka@linux.microsoft.com wrot= e: > From: "Madhavan T. Venkataraman" >=20 > The unwinder should check if the return PC falls in any function that > is considered unreliable from an unwinding perspective. If it does, > mark the stack trace unreliable. Other than the naming issue this makes sense to me, I'll try to go through the first patch properly in the next few days. --MPkR1dXiUZqK+927 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmClZqEACgkQJNaLcl1U h9B77Qf+M9+zHwxJNPl/vKY7Sle87Tgz3CrLIzIALiGlYZoKR6GmoGp1x+pA8XGw M/yVldVJE3DfEwBe5mPKLX+35CbSSyoAzAC00+KV66IwxaDbiAIFAMCtDfMh0tCr QFaglXXmWV6g4viO/v2+kpFY9PIhmUzyp3VtFFmaVaIdTmRiLx4+1UAGcmqMMopB CRIgjuaf0wsvwnXFQNqMxjrCx1ndY3XTHwRkxX5+06b8vUoIsqbZ1kvhNQz/cu39 DWSn9OE2R1mIFwhG26yeONdeRUGXSYt7AmyRt7lcXX94v4J77FzrWfxJ5WaJPhz1 MzcC6sZOVksed1e2vOwEpcDz53Y/gg== =+c7T -----END PGP SIGNATURE----- --MPkR1dXiUZqK+927-- --===============3967763201602129069== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3967763201602129069==--