* [PATCH] staging: greybus: spi: add blank line after variable declaration
@ 2021-05-19 19:39 Philippe Dixon
2021-05-19 19:53 ` Alex Elder
2021-05-20 3:49 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Dixon @ 2021-05-19 19:39 UTC (permalink / raw)
To: vireshk
Cc: rmfrfs, johan, elder, gregkh, greybus-dev, linux-staging, linux-kernel
This patch fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Philippe Dixon <philippesdixon@gmail.com>
---
drivers/staging/greybus/spilib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
index 30655153df6a..ad0700a0bb81 100644
--- a/drivers/staging/greybus/spilib.c
+++ b/drivers/staging/greybus/spilib.c
@@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
xfer = spi->first_xfer;
while (msg->state != GB_SPI_STATE_OP_DONE) {
int xfer_delay;
+
if (xfer == spi->last_xfer)
xfer_len = spi->last_xfer_size;
else
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: spi: add blank line after variable declaration
2021-05-19 19:39 [PATCH] staging: greybus: spi: add blank line after variable declaration Philippe Dixon
@ 2021-05-19 19:53 ` Alex Elder
2021-05-20 3:49 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2021-05-19 19:53 UTC (permalink / raw)
To: Philippe Dixon, vireshk
Cc: rmfrfs, johan, elder, gregkh, greybus-dev, linux-staging, linux-kernel
On 5/19/21 2:39 PM, Philippe Dixon wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Philippe Dixon <philippesdixon@gmail.com>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/staging/greybus/spilib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
> index 30655153df6a..ad0700a0bb81 100644
> --- a/drivers/staging/greybus/spilib.c
> +++ b/drivers/staging/greybus/spilib.c
> @@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
> xfer = spi->first_xfer;
> while (msg->state != GB_SPI_STATE_OP_DONE) {
> int xfer_delay;
> +
> if (xfer == spi->last_xfer)
> xfer_len = spi->last_xfer_size;
> else
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: spi: add blank line after variable declaration
2021-05-19 19:39 [PATCH] staging: greybus: spi: add blank line after variable declaration Philippe Dixon
2021-05-19 19:53 ` Alex Elder
@ 2021-05-20 3:49 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2021-05-20 3:49 UTC (permalink / raw)
To: Philippe Dixon
Cc: vireshk, rmfrfs, johan, elder, gregkh, greybus-dev,
linux-staging, linux-kernel
On 19-05-21, 12:39, Philippe Dixon wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Philippe Dixon <philippesdixon@gmail.com>
> ---
> drivers/staging/greybus/spilib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
> index 30655153df6a..ad0700a0bb81 100644
> --- a/drivers/staging/greybus/spilib.c
> +++ b/drivers/staging/greybus/spilib.c
> @@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
> xfer = spi->first_xfer;
> while (msg->state != GB_SPI_STATE_OP_DONE) {
> int xfer_delay;
> +
> if (xfer == spi->last_xfer)
> xfer_len = spi->last_xfer_size;
> else
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-20 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 19:39 [PATCH] staging: greybus: spi: add blank line after variable declaration Philippe Dixon
2021-05-19 19:53 ` Alex Elder
2021-05-20 3:49 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.