All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Tomlin <atomlin@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz,
	mhocko@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_alloc: bail out on fatal signal during reclaim/compaction retry attempt
Date: Wed, 19 May 2021 20:48:29 +0100	[thread overview]
Message-ID: <20210519194829.sess6lhfzlmccpdu@ava.usersys.com> (raw)
In-Reply-To: <YKVn69o1UizH0kJD@casper.infradead.org>

On Wed 2021-05-19 20:32 +0100, Matthew Wilcox wrote:
> On Wed, May 19, 2021 at 08:23:21PM +0100, Aaron Tomlin wrote:
> > +++ b/mm/page_alloc.c
> > @@ -4252,6 +4252,9 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags,
> >  	if (!order)
> >  		return false;
> >  
> > +	if (fatal_signal_pending(current))
> > +		goto out;
> 
> I think 'goto out' will be confusing.  It'll output a tracepoint, which
> isn't going to record that a fatal signal is pending, so it'll cause
> some head scratching for someone looking through the traces.  I
> think we should just return false here and skip the tracepoint.

I agree. Having said this, I do plan to send a patch to illustrate why
compaction should not retry to avoid possible confusion. Nevertheless, I am
happy to modify as per your request.


Kind regards,

-- 
Aaron Tomlin


  reply	other threads:[~2021-05-19 19:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 19:23 [PATCH v2] mm/page_alloc: bail out on fatal signal during reclaim/compaction retry attempt Aaron Tomlin
2021-05-19 19:32 ` Matthew Wilcox
2021-05-19 19:48   ` Aaron Tomlin [this message]
2021-05-19 20:17   ` [PATCH v3] " Aaron Tomlin
2021-05-20  4:34     ` Andrew Morton
2021-05-20 10:20       ` Vlastimil Babka
2021-05-20 11:42         ` Aaron Tomlin
2021-05-20 11:56           ` Matthew Wilcox
2021-05-20 13:30             ` Aaron Tomlin
2021-05-20 14:29             ` [PATCH v4] " Aaron Tomlin
2021-05-28 12:53               ` Vlastimil Babka
2021-05-31 11:33               ` Michal Hocko
2021-05-31 11:35                 ` Vlastimil Babka
2021-05-31 13:21                   ` Michal Hocko
2021-05-20 11:09       ` [PATCH v3] " Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519194829.sess6lhfzlmccpdu@ava.usersys.com \
    --to=atomlin@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.