From: Andrew Morton <akpm@linux-foundation.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: osalvador@suse.de, mike.kravetz@oracle.com, mhocko@suse.com,
david@redhat.com, willy@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com,
zhengqi.arch@bytedance.com, fam.zheng@bytedance.com,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH] mm: migrate: fix missing update page_private to hugetlb_page_subpool
Date: Wed, 19 May 2021 21:24:12 -0700 [thread overview]
Message-ID: <20210519212412.5653163f94904b141d5d74ce@linux-foundation.org> (raw)
In-Reply-To: <20210520025949.1866-1-songmuchun@bytedance.com>
On Thu, 20 May 2021 10:59:49 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
> Since commit d6995da31122 ("hugetlb: use page.private for hugetlb specific
> page flags") converts page.private for hugetlb specific page flags. We
> should use hugetlb_page_subpool() to get the subpool pointer instead of
> page_private(). The commit forgot to update it in the page migration
> routine. So fix it.
>
> ...
>
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1290,7 +1290,7 @@ static int unmap_and_move_huge_page(new_page_t get_new_page,
> * page_mapping() set, hugetlbfs specific move page routine will not
> * be called and we could leak usage counts for subpools.
> */
> - if (page_private(hpage) && !page_mapping(hpage)) {
> + if (hugetlb_page_subpool(hpage) && !page_mapping(hpage)) {
> rc = -EBUSY;
> goto out_unlock;
> }
So it uses the wrong page*, so this isn't just a cosmetic fix. One
cannot tell from this changelog.
Please describe the runtime effects of this bug. Please always include
this information when fixing bugs. And when adding them.
next prev parent reply other threads:[~2021-05-20 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 2:59 [PATCH] mm: migrate: fix missing update page_private to hugetlb_page_subpool Muchun Song
2021-05-20 3:34 ` Mike Kravetz
2021-05-20 4:24 ` Andrew Morton [this message]
2021-05-20 5:13 ` [External] " Muchun Song
2021-05-20 5:13 ` Muchun Song
2021-05-20 18:16 ` Mike Kravetz
2021-05-21 2:17 ` Muchun Song
2021-05-21 2:17 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519212412.5653163f94904b141d5d74ce@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.