From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B7FC433B4 for ; Thu, 20 May 2021 01:03:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6964600D4 for ; Thu, 20 May 2021 01:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhETBET (ORCPT ); Wed, 19 May 2021 21:04:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbhETBER (ORCPT ); Wed, 19 May 2021 21:04:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0854D6100A; Thu, 20 May 2021 01:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621472576; bh=Lf/8QEJNwE3bPrrZVsNXjplajFp91+e38C42i8jmbkY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYRVfyZJgvP4rPI60P5gD5ZZ+BRhfvGLBaXVXfbHFkavmRgl0cJlE+NNkh1WPTfVI hl6AKVwglJM6trM6ENDCxCZsePwO4D96kNoCQZrtGMaspqSZ4WpzysTUWTWrNDLl0R RzlV+MCk0QlhoPpSxcVsVDuONM/I4ZzFTxh8zH7xYqr6LudXdEp5+BAvCZXsWavEpU h+qx9wUezjOS8ZNxCmK3FqBI56fk+tFQBppaKo7CPyrfWWh/yz1PVZfIkY2gVew1+H D/9sFf8smHmMqCS9gsvvc0LRoZ6Va8n1bdekZ7qgk9okaccmtkOcRgFvHw//ou+nZH l42vYhivFGCOw== Date: Thu, 20 May 2021 03:02:54 +0200 From: Frederic Weisbecker To: "Paul E. McKenney" Cc: LKML , rcu@vger.kernel.org Subject: Re: [PATCH 1/3] rcu/nocb: Start moving nocb code to its own plugin file Message-ID: <20210520010254.GC22836@lothringen> References: <20210519000930.15702-1-frederic@kernel.org> <20210519000930.15702-2-frederic@kernel.org> <20210519155508.GX4441@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519155508.GX4441@paulmck-ThinkPad-P17-Gen-1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 08:55:08AM -0700, Paul E. McKenney wrote: > On Wed, May 19, 2021 at 02:09:28AM +0200, Frederic Weisbecker wrote: > > tree_plugin.h is now gathering not only the (no)preempt-rcu specifics > > but also other features like NO_CB. As the latter has grown quite in > > complexity and volume, it's may be a good idea to start moving the > > related code to its own file so we don't need to browse thousand lines > > to find what we need. > > > > Suggested-by: Paul E. McKenney > > Signed-off-by: Frederic Weisbecker > > Applied with the usual wordsmithing, thank you! > > But for consistency with the other similar files included by > kernel/rcu/tree.c, should the name instead be kernel/rcu/tree_nocb.h? Ah yes, I hesitated but tree_nocb.h is indeed more consistent. Can I let you do the rename? > Also, if Ingo and I are one the author list, shouldn't you be as well? ;-) Heh, alright feel free to add the following as a fixup :-) diff --git a/kernel/rcu/nocb.h b/kernel/rcu/nocb.h index a7783923833e..bf2690ca5d2b 100644 --- a/kernel/rcu/nocb.h +++ b/kernel/rcu/nocb.h @@ -6,9 +6,11 @@ * * Copyright Red Hat, 2009 * Copyright IBM Corporation, 2009 + * Copyright SUSE, 2021 * * Author: Ingo Molnar * Paul E. McKenney + * Frederic Weisbecker */ #ifdef CONFIG_RCU_NOCB_CPU Or perhaps you prefer a separate patch? Thanks!