From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6C5C433B4 for ; Thu, 20 May 2021 05:23:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2F58611AE for ; Thu, 20 May 2021 05:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2F58611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljb9y-0001bR-Qo for qemu-devel@archiver.kernel.org; Thu, 20 May 2021 01:23:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljb2V-0003TB-NA; Thu, 20 May 2021 01:16:07 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:44984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljb2Q-0002bD-7D; Thu, 20 May 2021 01:16:07 -0400 Received: by mail-wr1-x42e.google.com with SMTP id i17so16164596wrq.11; Wed, 19 May 2021 22:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mcAunA11//sOCKzq7CO3/y2yGuInMfq776cnfd5eSQU=; b=TsDEf1u9CG1+cYkqPoVDdeXsrLXMbD9IG6YmCWu+UKOxBalK1Oc9XSLCW1xJ0cUldK NVhhMFLKCknoh+ih01EDDv6pkDxpw3F6b6Hj88q9M6UlowuyfaM4uakFnqFIfrUoqbhR WKZn1h1M4hmGOHDhbcf2Mg3ufiTe4NWjJ3Z1XWo/J8/OPct4v382tcfTWR6jUt+JvyIO XK2mySBf3vuMAjpMIgIPShPhoeMDOzb/tS+F3yadDH7PaaSJsT4ZqLYyEFeg082KoCPP gpgMN06BYOm9+OWaQodVROSG+zhvw9eXFjMMqu5UI+W5IYCh1Lprt9oSkd09zh2aMoPS FFoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mcAunA11//sOCKzq7CO3/y2yGuInMfq776cnfd5eSQU=; b=NhYPZ56kW0Hcd/xv/rvpZ7/8sH0FQKiYUABnmpM+TQOSzKP0m+tKPflRxfQgBh7gBc ONZ3yX6XhoK05vOcNItSiwpQYTv9+jlgeMYzkg4UhF3Qz0zKBZpdCpNRvMcNKj86G7mC Q6T/OnjI0BhpldxV4/FPAIQBXcAHyUU4j3tJ+ohq7Z6068FqBm0H3aDhtMTd+3oJoycI T595jBxOMgjO0/GaIbZIMsC7pDAKSA+eQKO39mrxEuYvvxQ6zr712nGCUC9YfHdTR/28 uUjxnkkFPhYlEa5p2VI9vLghKDM256stX0E30T9Do81dlr/rbMdtL+cdIOjbT3eMst07 A7Hg== X-Gm-Message-State: AOAM5328tkjwUwBxdHndFO8sEihwoSqf3APouhL607WVObauSHHCKlWC Nfo7HjG3JPWh3rbSrlt1nnh470vlNDR+TQ== X-Google-Smtp-Source: ABdhPJwfLv98WFvrQLDPk3/XAbIEiMwoocDNyG+9ri0d2AiuYPhT7Pp/yIC5QRyDV0vFBaRorVMvTw== X-Received: by 2002:adf:f80f:: with SMTP id s15mr2148251wrp.341.1621487759624; Wed, 19 May 2021 22:15:59 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id p10sm1567272wrr.58.2021.05.19.22.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 22:15:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 3/3] hw/core/loader: Warn if we fail to load ROM regions at reset Date: Thu, 20 May 2021 07:15:42 +0200 Message-Id: <20210520051542.2378774-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210520051542.2378774-1-f4bug@amsat.org> References: <20210520051542.2378774-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" If the user provides an ELF file that's been linked to a wrong address, we try to load it, fails, and keep going silently. Instead, Display a warning instead, but keep going to not disrupt users accidentally relying on this 'continues-anyway' behaviour. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/loader.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index b3c4a654b45..37a2f2c4959 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -1147,8 +1147,16 @@ static void rom_reset(void *unused) void *host = memory_region_get_ram_ptr(rom->mr); memcpy(host, rom->data, rom->datasize); } else { - address_space_write_rom(rom->as, rom->addr, MEMTXATTRS_UNSPECIFIED, - rom->data, rom->datasize); + MemTxResult res; + + res = address_space_write_rom(rom->as, rom->addr, + MEMTXATTRS_UNSPECIFIED, + rom->data, rom->datasize); + if (res != MEMTX_OK) { + warn_report("rom: unable to write data (file '%s', " + "addr=0x" TARGET_FMT_plx ", size=0x%zu)", + rom->name, rom->addr, rom->datasize); + } } if (rom->isrom) { /* rom needs to be written only once */ -- 2.26.3