From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>
Subject: [PATCH 13/16] char: agp: generic: Place braces around optimised out function in if()
Date: Thu, 20 May 2021 13:13:44 +0100 [thread overview]
Message-ID: <20210520121347.3467794-14-lee.jones@linaro.org> (raw)
In-Reply-To: <20210520121347.3467794-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/char/agp/generic.c: In function ‘agp_generic_destroy_page’:
drivers/char/agp/generic.c:1265:28: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/char/agp/generic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index 3ffbb1c80c5c7..37a07676da6ff 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -1261,8 +1261,9 @@ void agp_generic_destroy_page(struct page *page, int flags)
if (page == NULL)
return;
- if (flags & AGP_PAGE_DESTROY_UNMAP)
+ if (flags & AGP_PAGE_DESTROY_UNMAP) {
unmap_page_from_agp(page);
+ }
if (flags & AGP_PAGE_DESTROY_FREE) {
put_page(page);
--
2.31.1
next prev parent reply other threads:[~2021-05-20 12:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones
2021-05-20 12:13 ` Lee Jones
2021-05-20 12:13 ` [PATCH 01/16] char: pcmcia: cm4000_cs: Remove unused variable 'tmp' Lee Jones
2021-05-20 12:13 ` [PATCH 02/16] char: pcmcia: cm4040_cs: Remove unused variable 'uc' Lee Jones
2021-05-20 12:13 ` [PATCH 03/16] char: random: Include header containing our prototypes Lee Jones
2021-05-20 12:13 ` [PATCH 04/16] char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues Lee Jones
2021-05-20 12:13 ` [PATCH 05/16] " Lee Jones
2021-05-21 8:09 ` Greg Kroah-Hartman
2021-05-21 8:17 ` Lee Jones
2021-05-20 12:13 ` [PATCH 06/16] char: applicom: Remove 3 unused variables 'ret' and 2 instances of 'byte_reset_it' Lee Jones
2021-05-20 12:27 ` Arnd Bergmann
2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones
2021-05-20 16:41 ` Jarkko Sakkinen
2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones
2021-05-20 16:43 ` Jarkko Sakkinen
2021-05-20 12:13 ` [PATCH 09/16] char: agp: backend: Demote some non-conformant kernel-doc headers Lee Jones
2021-06-17 9:52 ` Lee Jones
2021-05-20 12:13 ` [PATCH 10/16] char: agp: frontend: Include header file containing our prototypes Lee Jones
2021-05-20 12:13 ` [PATCH 11/16] char: agp: via-agp: Remove unused variable 'current_size' Lee Jones
2021-05-20 12:13 ` [PATCH 12/16] char: hpet: Remove unused variable 'm' Lee Jones
2021-05-20 12:13 ` Lee Jones [this message]
2021-05-20 12:13 ` [PATCH 14/16] char: agp: uninorth-agp: Remove unused variable 'size' Lee Jones
2021-05-20 12:13 ` [PATCH 15/16] char: hw_random: pseries-rng: Demote non-conformant kernel-doc header Lee Jones
2021-05-20 12:13 ` Lee Jones
2021-05-20 12:13 ` [PATCH 16/16] char: mem: Provide local prototype for non-static function Lee Jones
2021-05-20 12:32 ` Arnd Bergmann
2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann
2021-05-20 12:56 ` Arnd Bergmann
2021-05-21 7:22 ` Lee Jones
2021-05-21 7:22 ` Lee Jones
2021-05-21 7:42 ` Greg Kroah-Hartman
2021-05-21 7:42 ` Greg Kroah-Hartman
2021-05-21 7:44 ` Greg Kroah-Hartman
2021-05-21 7:44 ` Greg Kroah-Hartman
2021-05-21 7:56 ` Lee Jones
2021-05-21 7:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520121347.3467794-14-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=airlied@linux.ie \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.