From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43941C433ED for ; Thu, 20 May 2021 12:55:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CB626101D for ; Thu, 20 May 2021 12:55:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CB626101D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pi7lmNQ9+YA7R1usxRtTUQAhm4OdcBo3tlqT+4Lqgmo=; b=ndkd86Nsb8mJRzL7/AUcM6JJSX lG2hKSDre3aX2ffw9L0F5+v4R7c9ihAF8nmYBzvWFRNTXCKb3sVIO7Mc+riGPuSAELuU4cziWFZew jz0/jt3NXVwSs/ESu71U15wyIL6oKwZhF2tcL4G7jWjELSsTlmszuK5y5/2YqbaLGzfr8YKeXLFAp d0zMjQ/un3t+ReidTs0lUt1vGftohpcT2XJoOjsHZKZ7O74zQtrW8p3vkiamxlQRUJJVHp+pt/Rr8 3XN02cznPM0wrYyNFZYJE2zeVJ/INIQursPy17Mj+8Hrc6aNmZxHpva6MtblwoQQh+bHlctgn3CCT IWuUTTmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljiBU-0010al-Li; Thu, 20 May 2021 12:53:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lji4t-000vi8-PF for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 12:47:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aA2tjF/hBzI97cD/b5PUAncKg4SffmsMZePzN4GIIDA=; b=sx3jOXLpM8iK9yvPwlvbC0s9sc JjRFu8reyh9w7sYnjkj2EQ1hVho9MrSx0vQj0K2p8sPomZ/QUAtJkodOGvMR6KVr0PTxRblNZRBT1 0Bi8CHqhsraFYQnPpOBZuhbaeBv34EEcIO5Fy6iLiMFkUVwXTOLeUfiob5OLBwE/M+5NH7Du4BQkK Qw9MlbDUTDhCis8CtPGJJkDCYlzdJ2Gmf+4MX+lPUzNXehPxlQadIcBDH5NTh2O0o/ixH8A4VYxf/ Znv7G3Q00a15s3IPYpGkHIY9APwz5zaoJldIF9SbZqq0kdqfJdAZiijG1sJf6jdzS5F+BoknWEXml Aufctl9Q==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lji4r-00GKq9-2o for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 12:47:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A3D1211D4; Thu, 20 May 2021 05:46:58 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.7.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 495B63F73B; Thu, 20 May 2021 05:46:56 -0700 (PDT) Date: Thu, 20 May 2021 13:46:53 +0100 From: Mark Rutland To: Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, ardb@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, robin.murphy@arm.com Subject: Re: [PATCH v3 03/18] arm64: Apply errata to swsusp_arch_suspend_exit Message-ID: <20210520124653.GE17233@C02TD0UTHF1T.local> References: <20210520124406.2731873-1-tabba@google.com> <20210520124406.2731873-4-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520124406.2731873-4-tabba@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_054701_190294_C4224FA1 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 01:43:51PM +0100, Fuad Tabba wrote: > The Arm errata covered by ARM64_WORKAROUND_CLEAN_CACHE require > that "dc cvau" instructions get promoted to "dc civac". > > Reported-by: Mark Rutland > Signed-off-by: Fuad Tabba Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/hibernate-asm.S | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/hibernate-asm.S b/arch/arm64/kernel/hibernate-asm.S > index 8ccca660034e..0ed2f72a6b94 100644 > --- a/arch/arm64/kernel/hibernate-asm.S > +++ b/arch/arm64/kernel/hibernate-asm.S > @@ -91,7 +91,8 @@ SYM_CODE_START(swsusp_arch_suspend_exit) > raw_dcache_line_size x2, x3 > sub x3, x2, #1 > bic x4, x10, x3 > -2: dc cvau, x4 /* clean D line / unified line */ > +2: /* clean D line / unified line */ > +alternative_insn "dc cvau, x4", "dc civac, x4", ARM64_WORKAROUND_CLEAN_CACHE > add x4, x4, x2 > cmp x4, x1 > b.lo 2b > -- > 2.31.1.751.gd2f1c929bd-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel