From: Daniel Scally <djrscally@gmail.com> To: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Daniel Scally <djrscally@gmail.com>, Wolfram Sang <wsa@kernel.org>, Lee Jones <lee.jones@linaro.org>, Hans de Goede <hdegoede@redhat.com>, Maximilian Luz <luzmaximilian@gmail.com>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@acpica.org Cc: Len Brown <lenb@kernel.org>, Mika Westerberg <mika.westerberg@linux.intel.com>, Russell King <linux@armlinux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Mark Gross <mgross@linux.intel.com>, Robert Moore <robert.moore@intel.com>, Erik Kaneda <erik.kaneda@intel.com>, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com Subject: [PATCH v4 5/8] clkdev: Make clkdev_drop() null aware Date: Thu, 20 May 2021 15:09:25 +0100 [thread overview] Message-ID: <20210520140928.3252671-6-djrscally@gmail.com> (raw) In-Reply-To: <20210520140928.3252671-1-djrscally@gmail.com> To simplify error handling paths, many functions are no-ops when passed NULL pointers, for example gpiod_remove_lookup_table(). Mirror that behaviour for clkdev_drop(). Signed-off-by: Daniel Scally <djrscally@gmail.com> --- Changes since v3: - Patch introduced drivers/clk/clkdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index 0f2e3fcf0f19..c082720f8ade 100644 --- a/drivers/clk/clkdev.c +++ b/drivers/clk/clkdev.c @@ -286,6 +286,9 @@ EXPORT_SYMBOL(clk_add_alias); */ void clkdev_drop(struct clk_lookup *cl) { + if (!cl) + return; + mutex_lock(&clocks_mutex); list_del(&cl->node); mutex_unlock(&clocks_mutex); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Scally <djrscally@gmail.com> To: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Daniel Scally <djrscally@gmail.com>, Wolfram Sang <wsa@kernel.org>, Lee Jones <lee.jones@linaro.org>, Hans de Goede <hdegoede@redhat.com>, Maximilian Luz <luzmaximilian@gmail.com>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@acpica.org Cc: Len Brown <lenb@kernel.org>, Mika Westerberg <mika.westerberg@linux.intel.com>, Russell King <linux@armlinux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Mark Gross <mgross@linux.intel.com>, Robert Moore <robert.moore@intel.com>, Erik Kaneda <erik.kaneda@intel.com>, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com Subject: [PATCH v4 5/8] clkdev: Make clkdev_drop() null aware Date: Thu, 20 May 2021 15:09:25 +0100 [thread overview] Message-ID: <20210520140928.3252671-6-djrscally@gmail.com> (raw) In-Reply-To: <20210520140928.3252671-1-djrscally@gmail.com> To simplify error handling paths, many functions are no-ops when passed NULL pointers, for example gpiod_remove_lookup_table(). Mirror that behaviour for clkdev_drop(). Signed-off-by: Daniel Scally <djrscally@gmail.com> --- Changes since v3: - Patch introduced drivers/clk/clkdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index 0f2e3fcf0f19..c082720f8ade 100644 --- a/drivers/clk/clkdev.c +++ b/drivers/clk/clkdev.c @@ -286,6 +286,9 @@ EXPORT_SYMBOL(clk_add_alias); */ void clkdev_drop(struct clk_lookup *cl) { + if (!cl) + return; + mutex_lock(&clocks_mutex); list_del(&cl->node); mutex_unlock(&clocks_mutex); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-20 14:12 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-20 14:09 [PATCH v4 0/8] Introduce intel_skl_int3472 module Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-20 14:09 ` [PATCH v4 1/8] ACPI: scan: Extend acpi_walk_dep_device_list() Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-20 17:15 ` Maximilian Luz 2021-05-20 17:15 ` Maximilian Luz 2021-05-20 18:22 ` Rafael J. Wysocki 2021-05-20 18:22 ` [Devel] " Rafael J. Wysocki 2021-05-20 18:22 ` Rafael J. Wysocki 2021-05-20 21:03 ` Hans de Goede 2021-05-20 21:03 ` Hans de Goede 2021-05-21 12:59 ` Andy Shevchenko 2021-05-21 12:59 ` Andy Shevchenko 2021-05-20 14:09 ` [PATCH v4 2/8] ACPI: scan: Add function to fetch dependent of acpi device Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-20 18:33 ` Rafael J. Wysocki 2021-05-20 18:33 ` [Devel] " Rafael J. Wysocki 2021-05-20 18:33 ` Rafael J. Wysocki 2021-05-20 18:55 ` Rafael J. Wysocki 2021-05-20 18:55 ` [Devel] " Rafael J. Wysocki 2021-05-20 18:55 ` Rafael J. Wysocki 2021-05-21 19:25 ` Daniel Scally 2021-05-21 19:25 ` Daniel Scally 2021-05-20 14:09 ` [PATCH v4 3/8] i2c: core: Add a format macro for I2C device names Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-20 14:09 ` [PATCH v4 4/8] gpiolib: acpi: Export acpi_get_gpiod() Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-20 14:09 ` Daniel Scally [this message] 2021-05-20 14:09 ` [PATCH v4 5/8] clkdev: Make clkdev_drop() null aware Daniel Scally 2021-05-20 14:09 ` [PATCH v4 6/8] gpiolib: acpi: Add acpi_gpio_get_io_resource() Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-21 12:05 ` Andy Shevchenko 2021-05-21 12:05 ` Andy Shevchenko 2021-05-25 22:30 ` Daniel Scally 2021-05-25 22:30 ` Daniel Scally 2021-05-20 14:09 ` [PATCH v4 7/8] platform/x86: Add intel_skl_int3472 driver Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-21 12:57 ` Andy Shevchenko 2021-05-21 12:57 ` Andy Shevchenko 2021-05-25 22:53 ` Daniel Scally 2021-05-25 22:53 ` Daniel Scally 2021-05-26 7:54 ` Andy Shevchenko 2021-05-26 7:54 ` Andy Shevchenko 2021-05-20 14:09 ` [PATCH v4 8/8] mfd: tps68470: Remove tps68470 MFD driver Daniel Scally 2021-05-20 14:09 ` Daniel Scally 2021-05-25 13:10 ` [PATCH v4 0/8] Introduce intel_skl_int3472 module Hans de Goede 2021-05-25 13:10 ` Hans de Goede 2021-05-25 13:12 ` Hans de Goede 2021-05-25 13:12 ` Hans de Goede 2021-05-25 13:23 ` Andy Shevchenko 2021-05-25 13:23 ` Andy Shevchenko 2021-05-25 23:03 ` Daniel Scally 2021-05-25 23:03 ` Daniel Scally 2021-05-26 7:55 ` Andy Shevchenko 2021-05-26 7:55 ` Andy Shevchenko 2021-05-26 12:36 ` Hans de Goede 2021-05-26 12:36 ` Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210520140928.3252671-6-djrscally@gmail.com \ --to=djrscally@gmail.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bgolaszewski@baylibre.com \ --cc=devel@acpica.org \ --cc=erik.kaneda@intel.com \ --cc=hdegoede@redhat.com \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=lee.jones@linaro.org \ --cc=lenb@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=luzmaximilian@gmail.com \ --cc=mgross@linux.intel.com \ --cc=mika.westerberg@linux.intel.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rafael.j.wysocki@intel.com \ --cc=robert.moore@intel.com \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.