From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF24C433ED for ; Thu, 20 May 2021 14:19:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A52E610A8 for ; Thu, 20 May 2021 14:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A52E610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BT6tWev8iSWlUAk8bGK5FPeVSpM/ixcWhF1cSz35+E8=; b=E/kbM8ix5/qffg1B9noNA8QbpG +wv/tvp1uthNaIQydT6hn9K8gwWzlMdilhQKyktWgHPMKyjrbUr0zBAudOboqTkwqMNjT+nQXO/tc 8jUlPGcp02SIV78Ntr4lmQMXR6IbftiqUZGa2rPtcROrEwV87hf+2KVOZHRtpwsFOWi3HcOncqKPI 1nom71Sya9Bj2R2N3lAR8yYmSzJAXhUdPaM4BSieYDnO6PvegMGYZIK2WtKpUMvfC6IJ57nrjtcNh v7pIUzfadD+yCAfwxvgxVdEbd7XNaLsyOMq3yZiahPU83Zv+HNmut1lRsl2r/HVWdY+xnGu9qBiDl sit+x0HA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljjUa-001QsH-7z; Thu, 20 May 2021 14:17:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljjUS-001QqE-9Q for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 14:17:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vliUGd5vIy9GHJ0nU0Jqsg1+naa4og8U6HsUEr96NX8=; b=vQR/+1K/XgjAVo1W2JXsujJXij QZcf8ks2jv9F34+GbdFxpiYDsLmWnr1q7W8OryXzkTAW32jFyAOEYcSDdZbeQUorhziSgsGG/VnJ/ CSLWJXd3j2mhCP7+e9QcPVuQy9ex6wKhv9SAtAZHkj2G9aCW2nx2hnqOvdF1hNikWzNSHJCbmshF/ YFXp0orc9Uoa3g4IGwKU0Gd4YSgOootlW5g6qJYNRhYlI++VuhLLJEr8m3FE8v4bNkUeVnYaKRTXs PgpXMBCZo3xMoO3HNRMlml0icPapwbgOqatgG5cBjeoJ9BeQGZEACduYIrk3b0z2gV1HzXVDfWfrI mG80Tbyg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljjUP-00GPv5-BS for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 14:17:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7185511D4; Thu, 20 May 2021 07:17:28 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.7.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B90E03F73B; Thu, 20 May 2021 07:17:26 -0700 (PDT) Date: Thu, 20 May 2021 15:17:24 +0100 From: Mark Rutland To: Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, ardb@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, robin.murphy@arm.com Subject: Re: [PATCH v3 08/18] arm64: Move documentation of dcache_by_line_op Message-ID: <20210520141724.GK17233@C02TD0UTHF1T.local> References: <20210520124406.2731873-1-tabba@google.com> <20210520124406.2731873-9-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520124406.2731873-9-tabba@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_071729_458177_3DE86E3A X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 01:43:56PM +0100, Fuad Tabba wrote: > The comment describing the macro dcache_by_line_op is placed > right before the previous macro of the one it describes, which is > a bit confusing. Move it to the macro it describes (dcache_by_line_op). > > No functional change intended. > > Signed-off-by: Fuad Tabba Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/assembler.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h > index 0a276b46ef50..ced791124b28 100644 > --- a/arch/arm64/include/asm/assembler.h > +++ b/arch/arm64/include/asm/assembler.h > @@ -387,6 +387,14 @@ alternative_cb_end > bfi \tcr, \tmp0, \pos, #3 > .endm > > + .macro __dcache_op_workaround_clean_cache, op, addr > +alternative_if_not ARM64_WORKAROUND_CLEAN_CACHE > + dc \op, \addr > +alternative_else > + dc civac, \addr > +alternative_endif > + .endm > + > /* > * Macro to perform a data cache maintenance for the interval > * [addr, addr + size) > @@ -398,14 +406,6 @@ alternative_cb_end > * fixup: optional label to branch to on user fault > * Corrupts: addr, size, tmp1, tmp2 > */ > - .macro __dcache_op_workaround_clean_cache, op, addr > -alternative_if_not ARM64_WORKAROUND_CLEAN_CACHE > - dc \op, \addr > -alternative_else > - dc civac, \addr > -alternative_endif > - .endm > - > .macro dcache_by_line_op op, domain, addr, size, tmp1, tmp2, fixup > dcache_line_size \tmp1, \tmp2 > add \size, \addr, \size > -- > 2.31.1.751.gd2f1c929bd-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel