From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2259C433ED for ; Thu, 20 May 2021 17:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87FE56108C for ; Thu, 20 May 2021 17:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233620AbhETR2p (ORCPT ); Thu, 20 May 2021 13:28:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:44120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231680AbhETR2n (ORCPT ); Thu, 20 May 2021 13:28:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 75DE860240; Thu, 20 May 2021 17:27:18 +0000 (UTC) Date: Thu, 20 May 2021 18:27:16 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210520172713.GF12251@arm.com> References: <20210517123239.8025-1-steven.price@arm.com> <20210517123239.8025-8-steven.price@arm.com> <20210520120556.GC12251@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 04:58:01PM +0100, Steven Price wrote: > On 20/05/2021 13:05, Catalin Marinas wrote: > > On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote: > >> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >> index e89a5e275e25..4b6c83beb75d 100644 > >> --- a/arch/arm64/kvm/arm.c > >> +++ b/arch/arm64/kvm/arm.c > >> @@ -1309,6 +1309,65 @@ static int kvm_vm_ioctl_set_device_addr(struct kvm *kvm, > >> } > >> } > >> > >> +static int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > >> + struct kvm_arm_copy_mte_tags *copy_tags) > >> +{ > >> + gpa_t guest_ipa = copy_tags->guest_ipa; > >> + size_t length = copy_tags->length; > >> + void __user *tags = copy_tags->addr; > >> + gpa_t gfn; > >> + bool write = !(copy_tags->flags & KVM_ARM_TAGS_FROM_GUEST); > >> + int ret = 0; > >> + > >> + if (copy_tags->reserved[0] || copy_tags->reserved[1]) > >> + return -EINVAL; > >> + > >> + if (copy_tags->flags & ~KVM_ARM_TAGS_FROM_GUEST) > >> + return -EINVAL; > >> + > >> + if (length & ~PAGE_MASK || guest_ipa & ~PAGE_MASK) > >> + return -EINVAL; > >> + > >> + gfn = gpa_to_gfn(guest_ipa); > >> + > >> + mutex_lock(&kvm->slots_lock); > >> + > >> + while (length > 0) { > >> + kvm_pfn_t pfn = gfn_to_pfn_prot(kvm, gfn, write, NULL); > >> + void *maddr; > >> + unsigned long num_tags = PAGE_SIZE / MTE_GRANULE_SIZE; > >> + > >> + if (is_error_noslot_pfn(pfn)) { > >> + ret = -EFAULT; > >> + goto out; > >> + } > >> + > >> + maddr = page_address(pfn_to_page(pfn)); > >> + > >> + if (!write) { > >> + num_tags = mte_copy_tags_to_user(tags, maddr, num_tags); > >> + kvm_release_pfn_clean(pfn); > > > > Do we need to check if PG_mte_tagged is set? If the page was not faulted > > into the guest address space but the VMM has the page, does the > > gfn_to_pfn_prot() guarantee that a kvm_set_spte_gfn() was called? If > > not, this may read stale tags. > > Ah, I hadn't thought about that... No I don't believe gfn_to_pfn_prot() > will fault it into the guest. It doesn't indeed. What it does is a get_user_pages() but it's not of much help since the VMM pte wouldn't be tagged (we would have solved lots of problems if we required PROT_MTE in the VMM...) > >> + } else { > >> + num_tags = mte_copy_tags_from_user(maddr, tags, > >> + num_tags); > >> + kvm_release_pfn_dirty(pfn); > >> + } > > > > Same question here, if the we can't guarantee the stage 2 pte being set, > > we'd need to set PG_mte_tagged. > > This is arguably worse as we'll be writing tags into the guest but > without setting PG_mte_tagged - so they'll be lost when the guest then > faults the pages in. Which sounds like it should break migration. > > I think the below should be safe, and avoids the overhead of setting the > flag just for reads. > > Thanks, > > Steve > > ----8<---- > page = pfn_to_page(pfn); > maddr = page_address(page); > > if (!write) { > if (test_bit(PG_mte_tagged, &page->flags)) > num_tags = mte_copy_tags_to_user(tags, maddr, > MTE_GRANULES_PER_PAGE); > else > /* No tags in memory, so write zeros */ > num_tags = MTE_GRANULES_PER_PAGE - > clear_user(tag, MTE_GRANULES_PER_PAGE); > kvm_release_pfn_clean(pfn); For ptrace we return a -EOPNOTSUPP if the address doesn't have VM_MTE but I don't think it makes sense here, so I'm fine with clearing the destination and assuming that the tags are zero (as they'd be on faulting into the guest. Another thing I forgot to ask, what's guaranteeing that the page supports tags? Does this ioctl ensure that it would attempt the tag copying from some device mapping? Do we need some kvm_is_device_pfn() check? I guess ZONE_DEVICE memory we just refuse to map in an earlier patch. > } else { > num_tags = mte_copy_tags_from_user(maddr, tags, > MTE_GRANULES_PER_PAGE); > kvm_release_pfn_dirty(pfn); > } > > if (num_tags != MTE_GRANULES_PER_PAGE) { > ret = -EFAULT; > goto out; > } > > if (write) > test_and_set_bit(PG_mte_tagged, &page->flags); I think a set_bit() would do, I doubt it's any more efficient. But why not add it in the 'else' block above where we actually wrote the tags? The copy function may have failed part-way through. Maybe your logic is correct though, there are invalid tags in the page. Just add a comment. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B3E8C433B4 for ; Thu, 20 May 2021 17:28:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81AA66105A for ; Thu, 20 May 2021 17:28:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81AA66105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljmSn-0006PB-Jh for qemu-devel@archiver.kernel.org; Thu, 20 May 2021 13:28:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljmSE-0005js-JY for qemu-devel@nongnu.org; Thu, 20 May 2021 13:27:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:32826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljmSC-0008Pk-B8 for qemu-devel@nongnu.org; Thu, 20 May 2021 13:27:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 75DE860240; Thu, 20 May 2021 17:27:18 +0000 (UTC) Date: Thu, 20 May 2021 18:27:16 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210520172713.GF12251@arm.com> References: <20210517123239.8025-1-steven.price@arm.com> <20210517123239.8025-8-steven.price@arm.com> <20210520120556.GC12251@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 20, 2021 at 04:58:01PM +0100, Steven Price wrote: > On 20/05/2021 13:05, Catalin Marinas wrote: > > On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote: > >> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >> index e89a5e275e25..4b6c83beb75d 100644 > >> --- a/arch/arm64/kvm/arm.c > >> +++ b/arch/arm64/kvm/arm.c > >> @@ -1309,6 +1309,65 @@ static int kvm_vm_ioctl_set_device_addr(struct kvm *kvm, > >> } > >> } > >> > >> +static int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > >> + struct kvm_arm_copy_mte_tags *copy_tags) > >> +{ > >> + gpa_t guest_ipa = copy_tags->guest_ipa; > >> + size_t length = copy_tags->length; > >> + void __user *tags = copy_tags->addr; > >> + gpa_t gfn; > >> + bool write = !(copy_tags->flags & KVM_ARM_TAGS_FROM_GUEST); > >> + int ret = 0; > >> + > >> + if (copy_tags->reserved[0] || copy_tags->reserved[1]) > >> + return -EINVAL; > >> + > >> + if (copy_tags->flags & ~KVM_ARM_TAGS_FROM_GUEST) > >> + return -EINVAL; > >> + > >> + if (length & ~PAGE_MASK || guest_ipa & ~PAGE_MASK) > >> + return -EINVAL; > >> + > >> + gfn = gpa_to_gfn(guest_ipa); > >> + > >> + mutex_lock(&kvm->slots_lock); > >> + > >> + while (length > 0) { > >> + kvm_pfn_t pfn = gfn_to_pfn_prot(kvm, gfn, write, NULL); > >> + void *maddr; > >> + unsigned long num_tags = PAGE_SIZE / MTE_GRANULE_SIZE; > >> + > >> + if (is_error_noslot_pfn(pfn)) { > >> + ret = -EFAULT; > >> + goto out; > >> + } > >> + > >> + maddr = page_address(pfn_to_page(pfn)); > >> + > >> + if (!write) { > >> + num_tags = mte_copy_tags_to_user(tags, maddr, num_tags); > >> + kvm_release_pfn_clean(pfn); > > > > Do we need to check if PG_mte_tagged is set? If the page was not faulted > > into the guest address space but the VMM has the page, does the > > gfn_to_pfn_prot() guarantee that a kvm_set_spte_gfn() was called? If > > not, this may read stale tags. > > Ah, I hadn't thought about that... No I don't believe gfn_to_pfn_prot() > will fault it into the guest. It doesn't indeed. What it does is a get_user_pages() but it's not of much help since the VMM pte wouldn't be tagged (we would have solved lots of problems if we required PROT_MTE in the VMM...) > >> + } else { > >> + num_tags = mte_copy_tags_from_user(maddr, tags, > >> + num_tags); > >> + kvm_release_pfn_dirty(pfn); > >> + } > > > > Same question here, if the we can't guarantee the stage 2 pte being set, > > we'd need to set PG_mte_tagged. > > This is arguably worse as we'll be writing tags into the guest but > without setting PG_mte_tagged - so they'll be lost when the guest then > faults the pages in. Which sounds like it should break migration. > > I think the below should be safe, and avoids the overhead of setting the > flag just for reads. > > Thanks, > > Steve > > ----8<---- > page = pfn_to_page(pfn); > maddr = page_address(page); > > if (!write) { > if (test_bit(PG_mte_tagged, &page->flags)) > num_tags = mte_copy_tags_to_user(tags, maddr, > MTE_GRANULES_PER_PAGE); > else > /* No tags in memory, so write zeros */ > num_tags = MTE_GRANULES_PER_PAGE - > clear_user(tag, MTE_GRANULES_PER_PAGE); > kvm_release_pfn_clean(pfn); For ptrace we return a -EOPNOTSUPP if the address doesn't have VM_MTE but I don't think it makes sense here, so I'm fine with clearing the destination and assuming that the tags are zero (as they'd be on faulting into the guest. Another thing I forgot to ask, what's guaranteeing that the page supports tags? Does this ioctl ensure that it would attempt the tag copying from some device mapping? Do we need some kvm_is_device_pfn() check? I guess ZONE_DEVICE memory we just refuse to map in an earlier patch. > } else { > num_tags = mte_copy_tags_from_user(maddr, tags, > MTE_GRANULES_PER_PAGE); > kvm_release_pfn_dirty(pfn); > } > > if (num_tags != MTE_GRANULES_PER_PAGE) { > ret = -EFAULT; > goto out; > } > > if (write) > test_and_set_bit(PG_mte_tagged, &page->flags); I think a set_bit() would do, I doubt it's any more efficient. But why not add it in the 'else' block above where we actually wrote the tags? The copy function may have failed part-way through. Maybe your logic is correct though, there are invalid tags in the page. Just add a comment. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1017BC433B4 for ; Thu, 20 May 2021 17:27:30 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 867F760240 for ; Thu, 20 May 2021 17:27:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 867F760240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D97C54B4F7; Thu, 20 May 2021 13:27:28 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ysoBmWdzRzX9; Thu, 20 May 2021 13:27:27 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 902734B538; Thu, 20 May 2021 13:27:27 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 444054B4F7 for ; Thu, 20 May 2021 13:27:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35+-usjULW3D for ; Thu, 20 May 2021 13:27:25 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id F03AB4B4F2 for ; Thu, 20 May 2021 13:27:24 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 75DE860240; Thu, 20 May 2021 17:27:18 +0000 (UTC) Date: Thu, 20 May 2021 18:27:16 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210520172713.GF12251@arm.com> References: <20210517123239.8025-1-steven.price@arm.com> <20210517123239.8025-8-steven.price@arm.com> <20210520120556.GC12251@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, May 20, 2021 at 04:58:01PM +0100, Steven Price wrote: > On 20/05/2021 13:05, Catalin Marinas wrote: > > On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote: > >> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >> index e89a5e275e25..4b6c83beb75d 100644 > >> --- a/arch/arm64/kvm/arm.c > >> +++ b/arch/arm64/kvm/arm.c > >> @@ -1309,6 +1309,65 @@ static int kvm_vm_ioctl_set_device_addr(struct kvm *kvm, > >> } > >> } > >> > >> +static int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > >> + struct kvm_arm_copy_mte_tags *copy_tags) > >> +{ > >> + gpa_t guest_ipa = copy_tags->guest_ipa; > >> + size_t length = copy_tags->length; > >> + void __user *tags = copy_tags->addr; > >> + gpa_t gfn; > >> + bool write = !(copy_tags->flags & KVM_ARM_TAGS_FROM_GUEST); > >> + int ret = 0; > >> + > >> + if (copy_tags->reserved[0] || copy_tags->reserved[1]) > >> + return -EINVAL; > >> + > >> + if (copy_tags->flags & ~KVM_ARM_TAGS_FROM_GUEST) > >> + return -EINVAL; > >> + > >> + if (length & ~PAGE_MASK || guest_ipa & ~PAGE_MASK) > >> + return -EINVAL; > >> + > >> + gfn = gpa_to_gfn(guest_ipa); > >> + > >> + mutex_lock(&kvm->slots_lock); > >> + > >> + while (length > 0) { > >> + kvm_pfn_t pfn = gfn_to_pfn_prot(kvm, gfn, write, NULL); > >> + void *maddr; > >> + unsigned long num_tags = PAGE_SIZE / MTE_GRANULE_SIZE; > >> + > >> + if (is_error_noslot_pfn(pfn)) { > >> + ret = -EFAULT; > >> + goto out; > >> + } > >> + > >> + maddr = page_address(pfn_to_page(pfn)); > >> + > >> + if (!write) { > >> + num_tags = mte_copy_tags_to_user(tags, maddr, num_tags); > >> + kvm_release_pfn_clean(pfn); > > > > Do we need to check if PG_mte_tagged is set? If the page was not faulted > > into the guest address space but the VMM has the page, does the > > gfn_to_pfn_prot() guarantee that a kvm_set_spte_gfn() was called? If > > not, this may read stale tags. > > Ah, I hadn't thought about that... No I don't believe gfn_to_pfn_prot() > will fault it into the guest. It doesn't indeed. What it does is a get_user_pages() but it's not of much help since the VMM pte wouldn't be tagged (we would have solved lots of problems if we required PROT_MTE in the VMM...) > >> + } else { > >> + num_tags = mte_copy_tags_from_user(maddr, tags, > >> + num_tags); > >> + kvm_release_pfn_dirty(pfn); > >> + } > > > > Same question here, if the we can't guarantee the stage 2 pte being set, > > we'd need to set PG_mte_tagged. > > This is arguably worse as we'll be writing tags into the guest but > without setting PG_mte_tagged - so they'll be lost when the guest then > faults the pages in. Which sounds like it should break migration. > > I think the below should be safe, and avoids the overhead of setting the > flag just for reads. > > Thanks, > > Steve > > ----8<---- > page = pfn_to_page(pfn); > maddr = page_address(page); > > if (!write) { > if (test_bit(PG_mte_tagged, &page->flags)) > num_tags = mte_copy_tags_to_user(tags, maddr, > MTE_GRANULES_PER_PAGE); > else > /* No tags in memory, so write zeros */ > num_tags = MTE_GRANULES_PER_PAGE - > clear_user(tag, MTE_GRANULES_PER_PAGE); > kvm_release_pfn_clean(pfn); For ptrace we return a -EOPNOTSUPP if the address doesn't have VM_MTE but I don't think it makes sense here, so I'm fine with clearing the destination and assuming that the tags are zero (as they'd be on faulting into the guest. Another thing I forgot to ask, what's guaranteeing that the page supports tags? Does this ioctl ensure that it would attempt the tag copying from some device mapping? Do we need some kvm_is_device_pfn() check? I guess ZONE_DEVICE memory we just refuse to map in an earlier patch. > } else { > num_tags = mte_copy_tags_from_user(maddr, tags, > MTE_GRANULES_PER_PAGE); > kvm_release_pfn_dirty(pfn); > } > > if (num_tags != MTE_GRANULES_PER_PAGE) { > ret = -EFAULT; > goto out; > } > > if (write) > test_and_set_bit(PG_mte_tagged, &page->flags); I think a set_bit() would do, I doubt it's any more efficient. But why not add it in the 'else' block above where we actually wrote the tags? The copy function may have failed part-way through. Maybe your logic is correct though, there are invalid tags in the page. Just add a comment. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F994C433B4 for ; Thu, 20 May 2021 17:29:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E675D610A2 for ; Thu, 20 May 2021 17:29:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E675D610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WDgwQtcY45jNlLwnifSXTwjs1ja0MzZgEy5OaVDYLXU=; b=UR24l31wVtaPU35iSpRCs2oD2F 6NgGdUDXxVHCLmmoaeQtVpgNZl4fWLQOzjynAg4gyTT+afaNAghn+joiQ1/7nFjt9ZInrZuc1GtA4 SsXzrcjzuhxFV+vtJvPUIfexWbDqzEVz0EHO0eVjdDwKrlOyHpQfzF/3iO8RBspJJVxC3Ko9i9AK7 abRuVaw4ALO+5U3BbtYQlkzIH4dNCQLadSQd8QQwlcT5AZ5szdG7MW4KIirS04zdyfEVKDwUvJgaM mb5o8y2yzo/jFnoA3zRpksSa2hodd7drOoMPuhJhSurMqSMDBfODlRl3av5oTkGO2g/FdQMUEWyv9 H68RLKqA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljmSF-0025uU-Kw; Thu, 20 May 2021 17:27:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljmSD-0025uO-QY for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 17:27:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RqODIgxmafjSSNmBDoRHH/MtvzEd0P2GBj/0G4G0Z68=; b=YLSgg1ATXI9Nu2RwTzWGYJ39AS MNYD46eGjGuEscjzlxoeQET7rnDLHEHrg3IqbnYK+AkynMBi3TuGgD4LUUo/tCibXuLqxK2eCtiB4 cHanv2Ia8asyVopQFwhbfk1oEW8I33/a4gD9f8+YqGkeoonc20E2/SR1T1ndTbsk3ATkvr+EKTE8y DbiAG4CY9FlbSOOZyqEpb/KveIDZVtCKj2gjM71fBOLf0coalrYivcWjIoy0cmti8xjJfwACA2nDA vrkoQg1HcjpLX21+y5Erio11kIU0H3aZ3liFPlR7Q9kXZJ2nN7ZmCEti9pMOA0uAXxREzp1py/i+M eEoSzMLg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljmSA-00GXdo-S7 for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 17:27:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 75DE860240; Thu, 20 May 2021 17:27:18 +0000 (UTC) Date: Thu, 20 May 2021 18:27:16 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210520172713.GF12251@arm.com> References: <20210517123239.8025-1-steven.price@arm.com> <20210517123239.8025-8-steven.price@arm.com> <20210520120556.GC12251@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_102722_974372_E9EBC6ED X-CRM114-Status: GOOD ( 34.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 04:58:01PM +0100, Steven Price wrote: > On 20/05/2021 13:05, Catalin Marinas wrote: > > On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote: > >> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >> index e89a5e275e25..4b6c83beb75d 100644 > >> --- a/arch/arm64/kvm/arm.c > >> +++ b/arch/arm64/kvm/arm.c > >> @@ -1309,6 +1309,65 @@ static int kvm_vm_ioctl_set_device_addr(struct kvm *kvm, > >> } > >> } > >> > >> +static int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > >> + struct kvm_arm_copy_mte_tags *copy_tags) > >> +{ > >> + gpa_t guest_ipa = copy_tags->guest_ipa; > >> + size_t length = copy_tags->length; > >> + void __user *tags = copy_tags->addr; > >> + gpa_t gfn; > >> + bool write = !(copy_tags->flags & KVM_ARM_TAGS_FROM_GUEST); > >> + int ret = 0; > >> + > >> + if (copy_tags->reserved[0] || copy_tags->reserved[1]) > >> + return -EINVAL; > >> + > >> + if (copy_tags->flags & ~KVM_ARM_TAGS_FROM_GUEST) > >> + return -EINVAL; > >> + > >> + if (length & ~PAGE_MASK || guest_ipa & ~PAGE_MASK) > >> + return -EINVAL; > >> + > >> + gfn = gpa_to_gfn(guest_ipa); > >> + > >> + mutex_lock(&kvm->slots_lock); > >> + > >> + while (length > 0) { > >> + kvm_pfn_t pfn = gfn_to_pfn_prot(kvm, gfn, write, NULL); > >> + void *maddr; > >> + unsigned long num_tags = PAGE_SIZE / MTE_GRANULE_SIZE; > >> + > >> + if (is_error_noslot_pfn(pfn)) { > >> + ret = -EFAULT; > >> + goto out; > >> + } > >> + > >> + maddr = page_address(pfn_to_page(pfn)); > >> + > >> + if (!write) { > >> + num_tags = mte_copy_tags_to_user(tags, maddr, num_tags); > >> + kvm_release_pfn_clean(pfn); > > > > Do we need to check if PG_mte_tagged is set? If the page was not faulted > > into the guest address space but the VMM has the page, does the > > gfn_to_pfn_prot() guarantee that a kvm_set_spte_gfn() was called? If > > not, this may read stale tags. > > Ah, I hadn't thought about that... No I don't believe gfn_to_pfn_prot() > will fault it into the guest. It doesn't indeed. What it does is a get_user_pages() but it's not of much help since the VMM pte wouldn't be tagged (we would have solved lots of problems if we required PROT_MTE in the VMM...) > >> + } else { > >> + num_tags = mte_copy_tags_from_user(maddr, tags, > >> + num_tags); > >> + kvm_release_pfn_dirty(pfn); > >> + } > > > > Same question here, if the we can't guarantee the stage 2 pte being set, > > we'd need to set PG_mte_tagged. > > This is arguably worse as we'll be writing tags into the guest but > without setting PG_mte_tagged - so they'll be lost when the guest then > faults the pages in. Which sounds like it should break migration. > > I think the below should be safe, and avoids the overhead of setting the > flag just for reads. > > Thanks, > > Steve > > ----8<---- > page = pfn_to_page(pfn); > maddr = page_address(page); > > if (!write) { > if (test_bit(PG_mte_tagged, &page->flags)) > num_tags = mte_copy_tags_to_user(tags, maddr, > MTE_GRANULES_PER_PAGE); > else > /* No tags in memory, so write zeros */ > num_tags = MTE_GRANULES_PER_PAGE - > clear_user(tag, MTE_GRANULES_PER_PAGE); > kvm_release_pfn_clean(pfn); For ptrace we return a -EOPNOTSUPP if the address doesn't have VM_MTE but I don't think it makes sense here, so I'm fine with clearing the destination and assuming that the tags are zero (as they'd be on faulting into the guest. Another thing I forgot to ask, what's guaranteeing that the page supports tags? Does this ioctl ensure that it would attempt the tag copying from some device mapping? Do we need some kvm_is_device_pfn() check? I guess ZONE_DEVICE memory we just refuse to map in an earlier patch. > } else { > num_tags = mte_copy_tags_from_user(maddr, tags, > MTE_GRANULES_PER_PAGE); > kvm_release_pfn_dirty(pfn); > } > > if (num_tags != MTE_GRANULES_PER_PAGE) { > ret = -EFAULT; > goto out; > } > > if (write) > test_and_set_bit(PG_mte_tagged, &page->flags); I think a set_bit() would do, I doubt it's any more efficient. But why not add it in the 'else' block above where we actually wrote the tags? The copy function may have failed part-way through. Maybe your logic is correct though, there are invalid tags in the page. Just add a comment. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel