From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C4FC433B4 for ; Thu, 20 May 2021 18:15:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 145E461073 for ; Thu, 20 May 2021 18:15:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 145E461073 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9F64F167F; Thu, 20 May 2021 20:14:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9F64F167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621534524; bh=xUF2reLMch0OWaTTmkSyWX2CPg/VOKxyR7J40IlPdX4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oQ5g3odxypLGyf/gnT6C7x4wreOAEwA/Xz+ckkGvnmhWzaVO19W6T+3laYQnyj01y W0/Pc//IoF+itUAyvgnMTqUj9BcMNX5/h9SxauTokIxzIRa4X0v5jvbTYb1njZBuMt hrGcrautYhWoKa9NhW4ITYSjMDrhlyjxWziywBpo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 43E52F8020B; Thu, 20 May 2021 20:14:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 884B4F80217; Thu, 20 May 2021 20:14:33 +0200 (CEST) Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BEC8CF80127 for ; Thu, 20 May 2021 20:14:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BEC8CF80127 Received: by m.b4.vu (Postfix, from userid 1000) id 0BDC4606DC8A; Fri, 21 May 2021 03:44:22 +0930 (ACST) Date: Fri, 21 May 2021 03:44:22 +0930 From: "Geoffrey D. Bennett" To: Geraldo Nascimento Subject: Re: [BUG] ALSA: usb-audio: Scarlett 2 mixer driver fails on ehci-pci Message-ID: <20210520181422.GB95348@m.b4.vu> References: <20210517172553.GA85102@m.b4.vu> <20210518183420.GA89090@m.b4.vu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, May 18, 2021 at 06:41:45PM -0300, Geraldo Nascimento wrote: [...] > Myself I'd hook printk()'s to both ehci_hcd and xhci_hcd to print > every possible variable involved and see if there's any relevant > mismatches. Oh and watch with the printk()'s what libusb seems to be > doing, too. > > When you subscribe to linux-usb you *may* want to Cc: Greg > Kroah-Hartman with your discoveries so far, he's the USB Subsystem > Maintainer and the best one to help you track this down. Thanks for the pointers! It turns out that usb_sndctrlpipe() is not short for "USB sound control pipe". diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c index 560c2ade829d..dcff3e3a49f3 100644 --- a/sound/usb/mixer_scarlett_gen2.c +++ b/sound/usb/mixer_scarlett_gen2.c @@ -635,7 +635,7 @@ static int scarlett2_usb( /* send a second message to get the response */ err = snd_usb_ctl_msg(mixer->chip->dev, - usb_sndctrlpipe(mixer->chip->dev, 0), + usb_rcvctrlpipe(mixer->chip->dev, 0), SCARLETT2_USB_VENDOR_SPECIFIC_CMD_RESP, USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN, 0, I'll properly submit the patch once I've got confirmation from someone else that this fixes the issue. Thanks again, Geoffrey.