From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6385AC433B4 for ; Thu, 20 May 2021 18:47:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 469F86121E for ; Thu, 20 May 2021 18:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236141AbhETSs4 (ORCPT ); Thu, 20 May 2021 14:48:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:39392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235880AbhETSss (ORCPT ); Thu, 20 May 2021 14:48:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 347AA6124C; Thu, 20 May 2021 18:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621536446; bh=tjZHOWaK+cFm3eDjHyyP9YNAx0VLERWMIXFQByYvbjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tm6u9YuLHKaS5VVmKkehR+QiJCQlNIvK0Rsy7A31iPDsEXalFnU13t2sUQayM0/Rl 2V7HSV1X3TsZITjTscWVqtHfe8lo5Oo0RczMu2RKUIrKIpRMtJz1Y23DOYwWo0nofg O9I1RRg8e+MkzIbusUwamXGpRhNsJmNgCSwpsCpebyfW+s45hHKi50Lj5O/51mwtSN fiBsYS99NpEVjw2SD3lCoxst7iW44ChWXowyc/S5uL6BXroUSbWIHMrqcH7gtunoIn 5atbfOPzcS12lvBg/VVPVj3ec0/PIMxQzOj5Uml/7Jw2VRmXmtHnB/lNxxJUF3YaiI GzYMtg/ARv7vg== From: Will Deacon To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Will Deacon , Frederic Weisbecker , Thomas Gleixner , Marc Zyngier , Lorenzo Colitti , John Stultz , Stephen Boyd , kernel-team@android.com Subject: [PATCH 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper Date: Thu, 20 May 2021 19:47:02 +0100 Message-Id: <20210520184705.10845-3-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210520184705.10845-1-will@kernel.org> References: <20210520184705.10845-1-will@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation for adding support for per-cpu wakeup timers, split _tick_broadcast_oneshot_control() into a helper function which deals only with the broadcast timer management across idle transitions. Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Lorenzo Colitti Cc: John Stultz Cc: Stephen Boyd Signed-off-by: Will Deacon --- kernel/time/tick-broadcast.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index fb794ff4855e..f3f2f4ba4321 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -717,24 +717,16 @@ static void broadcast_shutdown_local(struct clock_event_device *bc, clockevents_switch_state(dev, CLOCK_EVT_STATE_SHUTDOWN); } -int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) +static int ___tick_broadcast_oneshot_control(enum tick_broadcast_state state, + struct tick_device *td, + int cpu) { - struct clock_event_device *bc, *dev; - int cpu, ret = 0; + struct clock_event_device *bc, *dev = td->evtdev; + int ret = 0; ktime_t now; - /* - * If there is no broadcast device, tell the caller not to go - * into deep idle. - */ - if (!tick_broadcast_device.evtdev) - return -EBUSY; - - dev = this_cpu_ptr(&tick_cpu_device)->evtdev; - raw_spin_lock(&tick_broadcast_lock); bc = tick_broadcast_device.evtdev; - cpu = smp_processor_id(); if (state == TICK_BROADCAST_ENTER) { /* @@ -863,6 +855,21 @@ int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) return ret; } +int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) +{ + struct tick_device *td = this_cpu_ptr(&tick_cpu_device); + int cpu = smp_processor_id(); + + if (tick_broadcast_device.evtdev) + return ___tick_broadcast_oneshot_control(state, td, cpu); + + /* + * If there is no broadcast device, tell the caller not + * to go into deep idle. + */ + return -EBUSY; +} + /* * Reset the one shot broadcast for a cpu * -- 2.31.1.818.g46aad6cb9e-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61465C433B4 for ; Thu, 20 May 2021 18:49:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8E22606A5 for ; Thu, 20 May 2021 18:49:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8E22606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V8LFcH1sPwJ9/IT4OKBkGEdkfdhQP6yc9q6O/YPm7i8=; b=iQAeDs9naHt9eNV+pnBuSzAgBd 0juIZBm1hLITUVFqiPlTBOkBVy6EwgRcBwCx4UiRpHVbYg+m0f5rIaZYTWlSWCjYuWPkdsOq3UjyP DI0Ozb3JBs9w04EaTbtbggRaxWFVPKnrKe9U1k/A1dZXtROf2M1kXp/eWPzkSFFXYIoRRUG+8dPRN CB7iRjQl2ZOFQ/qoRaON5f2zjJbImeMT0cD7k5buvivHTWdI7jKER5QxwsFwDkUC1mhQAh8E3nVm3 dbI/SpkS25RWR+lmg6UGDhfaD2gcvNWWZdMHl7dNUFF589hUbVUmif1spofaB0+LD2sJ1HTDtAz9p PsE799ww==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljni7-002JuB-6x; Thu, 20 May 2021 18:47:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljnhh-002Jlv-Re for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 18:47:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=e6zYO/sPTUDLqD9hiiGJ6bcs1v6q1JrvnlL1diG7gAU=; b=FFgtYmP/zyyRCR40jg0+Ov2Pc7 NqISApH6tdxb7IBxfrlz1gCORw3nVd5U7bY7LOy96Kyz50b5QoFuDDs5sehbT5+W87upjAP6xWDsI ESWXxmDQ3WjGoBdPMnklbSBFydpOz+L0y52kbmjRt6YMwvoohnbLfAMZJ44egBM4XtREJw8XWureE 0y1SfMjpvpu9dlouDYxzIE2EpY0Tvjz1Ky//jFTjo1ulUb6G05q/ycSLSS6Bs7jet2YKFfgYLAzlT LUTIB/IYN1vXEzmxG9cyTjwFNBDPluk61R+3ODJOwy24KDk9WAdS1duLC7eU4oMIvKSL0ZEbww33U iaCXI0/A==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljnhf-00GaE2-81 for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 18:47:28 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 347AA6124C; Thu, 20 May 2021 18:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621536446; bh=tjZHOWaK+cFm3eDjHyyP9YNAx0VLERWMIXFQByYvbjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tm6u9YuLHKaS5VVmKkehR+QiJCQlNIvK0Rsy7A31iPDsEXalFnU13t2sUQayM0/Rl 2V7HSV1X3TsZITjTscWVqtHfe8lo5Oo0RczMu2RKUIrKIpRMtJz1Y23DOYwWo0nofg O9I1RRg8e+MkzIbusUwamXGpRhNsJmNgCSwpsCpebyfW+s45hHKi50Lj5O/51mwtSN fiBsYS99NpEVjw2SD3lCoxst7iW44ChWXowyc/S5uL6BXroUSbWIHMrqcH7gtunoIn 5atbfOPzcS12lvBg/VVPVj3ec0/PIMxQzOj5Uml/7Jw2VRmXmtHnB/lNxxJUF3YaiI GzYMtg/ARv7vg== From: Will Deacon To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Will Deacon , Frederic Weisbecker , Thomas Gleixner , Marc Zyngier , Lorenzo Colitti , John Stultz , Stephen Boyd , kernel-team@android.com Subject: [PATCH 2/5] tick/broadcast: Split __tick_broadcast_oneshot_control() into a helper Date: Thu, 20 May 2021 19:47:02 +0100 Message-Id: <20210520184705.10845-3-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210520184705.10845-1-will@kernel.org> References: <20210520184705.10845-1-will@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_114727_322927_A22E260F X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In preparation for adding support for per-cpu wakeup timers, split _tick_broadcast_oneshot_control() into a helper function which deals only with the broadcast timer management across idle transitions. Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Lorenzo Colitti Cc: John Stultz Cc: Stephen Boyd Signed-off-by: Will Deacon --- kernel/time/tick-broadcast.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index fb794ff4855e..f3f2f4ba4321 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -717,24 +717,16 @@ static void broadcast_shutdown_local(struct clock_event_device *bc, clockevents_switch_state(dev, CLOCK_EVT_STATE_SHUTDOWN); } -int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) +static int ___tick_broadcast_oneshot_control(enum tick_broadcast_state state, + struct tick_device *td, + int cpu) { - struct clock_event_device *bc, *dev; - int cpu, ret = 0; + struct clock_event_device *bc, *dev = td->evtdev; + int ret = 0; ktime_t now; - /* - * If there is no broadcast device, tell the caller not to go - * into deep idle. - */ - if (!tick_broadcast_device.evtdev) - return -EBUSY; - - dev = this_cpu_ptr(&tick_cpu_device)->evtdev; - raw_spin_lock(&tick_broadcast_lock); bc = tick_broadcast_device.evtdev; - cpu = smp_processor_id(); if (state == TICK_BROADCAST_ENTER) { /* @@ -863,6 +855,21 @@ int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) return ret; } +int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) +{ + struct tick_device *td = this_cpu_ptr(&tick_cpu_device); + int cpu = smp_processor_id(); + + if (tick_broadcast_device.evtdev) + return ___tick_broadcast_oneshot_control(state, td, cpu); + + /* + * If there is no broadcast device, tell the caller not + * to go into deep idle. + */ + return -EBUSY; +} + /* * Reset the one shot broadcast for a cpu * -- 2.31.1.818.g46aad6cb9e-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel