From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58048C433B4 for ; Fri, 21 May 2021 07:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 384B9613BF for ; Fri, 21 May 2021 07:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232814AbhEUHMU (ORCPT ); Fri, 21 May 2021 03:12:20 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:55492 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233208AbhEUHMU (ORCPT ); Fri, 21 May 2021 03:12:20 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1ljzJ8-0003vW-KB; Fri, 21 May 2021 15:10:54 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1ljzJ8-0005lF-Gv; Fri, 21 May 2021 15:10:54 +0800 Date: Fri, 21 May 2021 15:10:54 +0800 From: Herbert Xu To: Linus Walleij Cc: Matt Mackall , Deepak Saxena , linux-crypto@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 3/5] hw_random: ixp4xx: Turn into a module Message-ID: <20210521071054.atwfnd25olyvrer6@gondor.apana.org.au> References: <20210511132928.814697-1-linus.walleij@linaro.org> <20210511132928.814697-3-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511132928.814697-3-linus.walleij@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, May 11, 2021 at 03:29:26PM +0200, Linus Walleij wrote: > Instead of just initializing always, which will invariably > create problems on multiplatform builds, turn this driver into > a module and pass a resource with the memory location. > The device only exist on the IXP46x so we only register > the device for the IXP46x SoC. > > Cc: Deepak Saxena > Signed-off-by: Linus Walleij > --- > The idea is to apply this through the ARM SoC tree along > with other IXP4xx refactorings. > Please tell me if you prefer another solution. > --- > arch/arm/mach-ixp4xx/common.c | 24 ++++++++++++++++++- > drivers/char/hw_random/ixp4xx-rng.c | 37 +++++++++++++---------------- > 2 files changed, 40 insertions(+), 21 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt