All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <p.yadav@ti.com>
To: Petr Malat <oss@malat.biz>
Cc: <linux-mtd@lists.infradead.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH] spi-nor: sfdp: Allow configuring unknown flashes using SFDP
Date: Fri, 21 May 2021 15:25:05 +0530	[thread overview]
Message-ID: <20210521095503.qw3aivg4zklupwcj@ti.com> (raw)
In-Reply-To: <20210520160701.28176-1-oss@malat.biz>

On 20/05/21 06:07PM, Petr Malat wrote:
> This change allows adding a support for flashes with correct SFDP
> without recompilation of the kernel by setting sfdp-compatible property
> in their node. Alternatively, sfdp_compatible module option can be used
> to list JEDEC IDs of flashes, whose SFDP can be trusted. Star "*" can
> be used to match all JEDEC IDs.

I have skimmed through the patch. Before I look at it more closely, I 
want to understand the use case for this patch. Why would you not want 
to recompile the kernel when adding support for new hardware? Do you 
want the ability to support flashes on devices that have already been 
deployed in the field? Is it something that comes up frequently?

Then comes the question of how do you get the flash to probe if it is 
not present in device tree? And if you are able to update the device 
tree then you should also be able to update the kernel.

Have you tested this with any flash? If so, with which one?

> 
> Signed-off-by: Petr Malat <oss@malat.biz>
> ---
>  .../devicetree/bindings/mtd/jedec,spi-nor.txt |  3 +

This file has been converted to yaml since at least 5.12-rc1. Please 
update your kernel sources and rebase your patches.

>  drivers/mtd/spi-nor/core.c                    | 86 +++++++++++--------
>  drivers/mtd/spi-nor/core.h                    |  4 +
>  drivers/mtd/spi-nor/sfdp.c                    | 66 ++++++++++++++
>  drivers/mtd/spi-nor/sfdp.h                    |  2 +
>  5 files changed, 126 insertions(+), 35 deletions(-)

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-05-21  9:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 16:07 [PATCH] spi-nor: sfdp: Allow configuring unknown flashes using SFDP Petr Malat
2021-05-21  9:55 ` Pratyush Yadav [this message]
2021-05-21 11:53   ` Petr Malat
2021-05-27 13:52     ` Vignesh Raghavendra
2021-05-27 13:54       ` Pratyush Yadav
2021-05-27 15:45       ` Petr Malat
2021-05-28 11:56         ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521095503.qw3aivg4zklupwcj@ti.com \
    --to=p.yadav@ti.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=oss@malat.biz \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.