From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D1BC433ED for ; Fri, 21 May 2021 10:23:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAB57613BD for ; Fri, 21 May 2021 10:23:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAB57613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk2JC-0006Mi-Ng for qemu-devel@archiver.kernel.org; Fri, 21 May 2021 06:23:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk2HP-0003Wf-5q for qemu-devel@nongnu.org; Fri, 21 May 2021 06:21:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk2HG-0007o4-HB for qemu-devel@nongnu.org; Fri, 21 May 2021 06:21:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621592469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qqCgV1Hb8/rvGDYJPEDunY57u+xWkHFJ+EyrW/tbKRw=; b=NQEFC9OmKCcsjoDSZEyA9G3CeUvx3bwgsnyx26kKfd0T1SXIuWuBEghLxwhVOvtxDxLtRJ cCg+HxkP83btthaobIDW6GqTUw/E981ZQdfRS4EkLht5ovM9PLuWpb6E1zbkG+MGsEoWaF yG8BNW+IDAEMe1p6aYo8nTDyrkgLtQY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-MQ_dlxoVNxCf9wBe6hG-Pg-1; Fri, 21 May 2021 06:21:06 -0400 X-MC-Unique: MQ_dlxoVNxCf9wBe6hG-Pg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 448D7107ACE4; Fri, 21 May 2021 10:21:05 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAE1870581; Fri, 21 May 2021 10:21:04 +0000 (UTC) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH v3 0/3] vl: add -object support back into -readconfig Date: Fri, 21 May 2021 06:21:01 -0400 Message-Id: <20210521102104.3271053-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, armbru@redhat.com, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" LXD developers have reported that [object] stanzas have stopped working in configuration files. The problem is that QEMU 6.0 switched the creation of objects from qemu_opts_foreach to a bespoke QTAILQ, in preparation for supporting JSON syntax in -object. Entries from the configuration file however do not go through object_option_parse, and are thus lost. Of the many fixes that are possible, I chose one that is slightly more invasive but more consistent with the plans for keyval-ification of options such as -M and -accel. -set was also broken by the same change. For simplicity I chose not to add it back yet, however this series will report the breakage instead of failing silently. The first two patches of this series are thus a reduced version of https://patchew.org/QEMU/20210513162901.1310239-1-pbonzini@redhat.com/ ([PATCH 00/14] vl: compound properties for machines and accelerators), with the -set infrastructure removed. The third is very simple and uses the newly-provided hooks to parse objects from configuration files. Paolo Based-on: <20210518131542.2941207-1-pbonzini@redhat.com> Paolo Bonzini (3): qemu-config: parse configuration files to a QDict vl: plumb keyval-based options into -readconfig vl: plug -object back into -readconfig include/block/qdict.h | 2 - include/qapi/qmp/qdict.h | 3 ++ include/qemu/config-file.h | 7 ++- softmmu/vl.c | 105 +++++++++++++++++++++++++++---------- util/qemu-config.c | 98 +++++++++++++++++++++++----------- 5 files changed, 153 insertions(+), 62 deletions(-) -- 2.27.0