From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A65C43461 for ; Fri, 21 May 2021 10:25:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD8EB613D6 for ; Fri, 21 May 2021 10:25:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232759AbhEUK1H (ORCPT ); Fri, 21 May 2021 06:27:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233336AbhEUK0v (ORCPT ); Fri, 21 May 2021 06:26:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 427FE613CB; Fri, 21 May 2021 10:25:26 +0000 (UTC) Date: Fri, 21 May 2021 11:25:23 +0100 From: Catalin Marinas To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 02/21] arm64: Allow mismatched 32-bit EL0 support Message-ID: <20210521102523.GB6675@arm.com> References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-3-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518094725.7701-3-will@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 10:47:06AM +0100, Will Deacon wrote: > +static bool has_32bit_el0(const struct arm64_cpu_capabilities *entry, int scope) > +{ > + if (!has_cpuid_feature(entry, scope)) > + return allow_mismatched_32bit_el0; > + > + if (scope == SCOPE_SYSTEM) > + pr_info("detected: 32-bit EL0 Support\n"); > + > + return true; > +} We may have discussed this before: AFAICT this will print 32-bit EL0 detected even if there's no 32-bit EL0 on any CPU. Should we instead print 32-bit EL0 detected on CPU X when allow_mismatched_32bit_el0 is passed? It would also give us an indication of the system configuration when people start reporting bugs. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920BDC433ED for ; Fri, 21 May 2021 10:28:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6040A613BD for ; Fri, 21 May 2021 10:28:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6040A613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D2evAxb/UlBxU2s+ZdngEtMbeJ9RlyJ0XwF91ib5XmM=; b=pw4dsMx0bu5ToOaSiyqDiQp/z1 YUXdflsQIa/DvpTC1TycPimIZdIVAV17JrYfZVVX5pcU0PORUtwVaR4f8F78niXjAsRrEQP8Bu7Nv 5e2pz4jHZyh7Y2msMERL7o37xPKmyg8Ig5UGOk35q+8ifbMMzN/XsadiSoJc4FSkcE7heKN+t+iWu SAzfaT3QdSnnLwZzMMTKijgY+iEhLpNq9Sx0dYiD9+yzif0dN6t0NLu9fAdQdVzIxcVt6KiWh7laa EJYa0BAfo5jrevdDgTEfWQ4ahbDD82/2w1r0BmsqEkoVXF6oNqxwm2aAJiG7SusR3CCxhigOEPvXb +2hU73Ig==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk2LX-004tcN-7u; Fri, 21 May 2021 10:25:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk2LU-004tbX-2W for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 10:25:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lovZSN/4R5T6RobN4xb4yh4MpBh+C1rWEKBT1wWgmRg=; b=oIZ97Re8jzjcSecSMhoknGXqTU gCMIymZaF1kTduhZkd8pKIzrN+CVJby9tSzxtZKwlBz0sOIHGqzIPOyzGGmlBmAGsnxYioQaoGkWX 9uPY4AR750r8WhVvBIMAbPqkrCzo9vc/SY/Jc7wKZ0jcM0NeF/yNDPAVvDG7pftGHSpkQ8TgNSK/J a9SS8lRLqE22yCdj8KGvIlSxAGhRY/X8ZuHUxyJ4IYz3CZKPrm5rAQbXcK2vffNsHzX/pFg2xPYbU nKyS2O4g0fxZTHYWQBaUvfOTiC4rnPJ6NRGQFm3kLGz8cdjQvvcTSz/rJUa/FyBlpZMoQ6rznq9v0 0yeqayoA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk2LR-00H1uG-Iu for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 10:25:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 427FE613CB; Fri, 21 May 2021 10:25:26 +0000 (UTC) Date: Fri, 21 May 2021 11:25:23 +0100 From: Catalin Marinas To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 02/21] arm64: Allow mismatched 32-bit EL0 support Message-ID: <20210521102523.GB6675@arm.com> References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210518094725.7701-3-will@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_032529_661411_35F59F86 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 18, 2021 at 10:47:06AM +0100, Will Deacon wrote: > +static bool has_32bit_el0(const struct arm64_cpu_capabilities *entry, int scope) > +{ > + if (!has_cpuid_feature(entry, scope)) > + return allow_mismatched_32bit_el0; > + > + if (scope == SCOPE_SYSTEM) > + pr_info("detected: 32-bit EL0 Support\n"); > + > + return true; > +} We may have discussed this before: AFAICT this will print 32-bit EL0 detected even if there's no 32-bit EL0 on any CPU. Should we instead print 32-bit EL0 detected on CPU X when allow_mismatched_32bit_el0 is passed? It would also give us an indication of the system configuration when people start reporting bugs. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel