All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS
Date: Fri, 21 May 2021 12:30:52 +0200	[thread overview]
Message-ID: <20210521103052.GK3208066@scaer> (raw)
In-Reply-To: <20210521095924.52527-1-mgliga@bitdefender.com>

Mircea, All,

On 2021-05-21 12:59 +0300, Mircea GLIGA spake thusly:
> Required for systems that do not have FUTEX support in kernel.
> Native POSIX Thread Library (NPTL) relies on futexes, so we need
> to use LinuxThreads instead on that systems.
> 
> Signed-off-by: Mircea GLIGA <mgliga@bitdefender.com>
> ---
>  package/uclibc/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index e59fef3c69..ae27bc18fb 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -53,7 +53,7 @@ config BR2_PTHREADS_NATIVE
>  
>  config BR2_PTHREADS
>  	bool "linuxthreads"
> -	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa
> +	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa || BR2_mips || BR2_mipsel

I was a bit annoyed by this very logn line, so I took the liberyty to
split it, but then I looked at uclibc-ng for the list of architectures
that still has LT support, and it turns out that almost all do, except:

  - AArch64 (both endianness)
  - riscv64
  - metag (irrelevant for Buildroot)

So I think it would be better to change the way we expose BR2_PTHREADS
for uClibc:

    config BR2_PTHREADS
        bool "linuxthreads"
        depends on !BR2_aarch64 && !BR2_aarch64_be
        depends on !BR2_RISCV_64

Could you please respin with this, please?

Regards,
Yann E. MORIN.

>  	select BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PTHREADS_NONE
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-05-21 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  9:59 [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS Mircea GLIGA
2021-05-21 10:30 ` Yann E. MORIN [this message]
2021-05-21 11:36   ` Mircea GLIGA
2021-05-21 13:41 ` [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures Mircea GLIGA
2021-05-21 16:53   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521103052.GK3208066@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.