All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS
@ 2021-05-21  9:59 Mircea GLIGA
  2021-05-21 10:30 ` Yann E. MORIN
  2021-05-21 13:41 ` [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures Mircea GLIGA
  0 siblings, 2 replies; 5+ messages in thread
From: Mircea GLIGA @ 2021-05-21  9:59 UTC (permalink / raw)
  To: buildroot

Required for systems that do not have FUTEX support in kernel.
Native POSIX Thread Library (NPTL) relies on futexes, so we need
to use LinuxThreads instead on that systems.

Signed-off-by: Mircea GLIGA <mgliga@bitdefender.com>
---
 package/uclibc/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
index e59fef3c69..ae27bc18fb 100644
--- a/package/uclibc/Config.in
+++ b/package/uclibc/Config.in
@@ -53,7 +53,7 @@ config BR2_PTHREADS_NATIVE
 
 config BR2_PTHREADS
 	bool "linuxthreads"
-	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa
+	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa || BR2_mips || BR2_mipsel
 	select BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PTHREADS_NONE
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS
  2021-05-21  9:59 [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS Mircea GLIGA
@ 2021-05-21 10:30 ` Yann E. MORIN
  2021-05-21 11:36   ` Mircea GLIGA
  2021-05-21 13:41 ` [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures Mircea GLIGA
  1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2021-05-21 10:30 UTC (permalink / raw)
  To: buildroot

Mircea, All,

On 2021-05-21 12:59 +0300, Mircea GLIGA spake thusly:
> Required for systems that do not have FUTEX support in kernel.
> Native POSIX Thread Library (NPTL) relies on futexes, so we need
> to use LinuxThreads instead on that systems.
> 
> Signed-off-by: Mircea GLIGA <mgliga@bitdefender.com>
> ---
>  package/uclibc/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index e59fef3c69..ae27bc18fb 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -53,7 +53,7 @@ config BR2_PTHREADS_NATIVE
>  
>  config BR2_PTHREADS
>  	bool "linuxthreads"
> -	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa
> +	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa || BR2_mips || BR2_mipsel

I was a bit annoyed by this very logn line, so I took the liberyty to
split it, but then I looked at uclibc-ng for the list of architectures
that still has LT support, and it turns out that almost all do, except:

  - AArch64 (both endianness)
  - riscv64
  - metag (irrelevant for Buildroot)

So I think it would be better to change the way we expose BR2_PTHREADS
for uClibc:

    config BR2_PTHREADS
        bool "linuxthreads"
        depends on !BR2_aarch64 && !BR2_aarch64_be
        depends on !BR2_RISCV_64

Could you please respin with this, please?

Regards,
Yann E. MORIN.

>  	select BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PTHREADS_NONE
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS
  2021-05-21 10:30 ` Yann E. MORIN
@ 2021-05-21 11:36   ` Mircea GLIGA
  0 siblings, 0 replies; 5+ messages in thread
From: Mircea GLIGA @ 2021-05-21 11:36 UTC (permalink / raw)
  To: buildroot

Hi Yann,

Your proposal looks good: it's cleaner + it covers everything supported
by uClibc-ng.
I also tested with my configuration and it seems fine.


Thanks and regards,
Mircea Gliga

On 5/21/21 1:30 PM, Yann E. MORIN wrote:
> CAUTION: This email originated from outside of our organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> Mircea, All,
> 
> On 2021-05-21 12:59 +0300, Mircea GLIGA spake thusly:
>> Required for systems that do not have FUTEX support in kernel.
>> Native POSIX Thread Library (NPTL) relies on futexes, so we need
>> to use LinuxThreads instead on that systems.
>>
>> Signed-off-by: Mircea GLIGA <mgliga@bitdefender.com>
>> ---
>>   package/uclibc/Config.in | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
>> index e59fef3c69..ae27bc18fb 100644
>> --- a/package/uclibc/Config.in
>> +++ b/package/uclibc/Config.in
>> @@ -53,7 +53,7 @@ config BR2_PTHREADS_NATIVE
>>
>>   config BR2_PTHREADS
>>        bool "linuxthreads"
>> -     depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa
>> +     depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa || BR2_mips || BR2_mipsel
> 
> I was a bit annoyed by this very logn line, so I took the liberyty to
> split it, but then I looked at uclibc-ng for the list of architectures
> that still has LT support, and it turns out that almost all do, except:
> 
>    - AArch64 (both endianness)
>    - riscv64
>    - metag (irrelevant for Buildroot)
> 
> So I think it would be better to change the way we expose BR2_PTHREADS
> for uClibc:
> 
>      config BR2_PTHREADS
>          bool "linuxthreads"
>          depends on !BR2_aarch64 && !BR2_aarch64_be
>          depends on !BR2_RISCV_64
> 
> Could you please respin with this, please?
> 
> Regards,
> Yann E. MORIN.
> 
>>        select BR2_TOOLCHAIN_HAS_THREADS
>>
>>   config BR2_PTHREADS_NONE
>> --
>> 2.31.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures
  2021-05-21  9:59 [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS Mircea GLIGA
  2021-05-21 10:30 ` Yann E. MORIN
@ 2021-05-21 13:41 ` Mircea GLIGA
  2021-05-21 16:53   ` Yann E. MORIN
  1 sibling, 1 reply; 5+ messages in thread
From: Mircea GLIGA @ 2021-05-21 13:41 UTC (permalink / raw)
  To: buildroot

Synchronize the list of architectures that have LinuxThreads support
with the ones from uClibc-ng.

Signed-off-by: Mircea GLIGA <mgliga@bitdefender.com>
---
Changes v1 -> v2:
  - enable linuxthreads for all supported architectures,
    not just MIPS (suggested by Yann E. MORIN)
---
 package/uclibc/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
index e59fef3c69..2091166b62 100644
--- a/package/uclibc/Config.in
+++ b/package/uclibc/Config.in
@@ -53,7 +53,8 @@ config BR2_PTHREADS_NATIVE
 
 config BR2_PTHREADS
 	bool "linuxthreads"
-	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa
+	depends on !BR2_aarch64 && !BR2_aarch64_be
+	depends on !BR2_RISCV_64
 	select BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PTHREADS_NONE
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures
  2021-05-21 13:41 ` [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures Mircea GLIGA
@ 2021-05-21 16:53   ` Yann E. MORIN
  0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2021-05-21 16:53 UTC (permalink / raw)
  To: buildroot

Mircea, All,

On 2021-05-21 16:41 +0300, Mircea GLIGA spake thusly:
> Synchronize the list of architectures that have LinuxThreads support
> with the ones from uClibc-ng.
> 
> Signed-off-by: Mircea GLIGA <mgliga@bitdefender.com>

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - enable linuxthreads for all supported architectures,
>     not just MIPS (suggested by Yann E. MORIN)
> ---
>  package/uclibc/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index e59fef3c69..2091166b62 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -53,7 +53,8 @@ config BR2_PTHREADS_NATIVE
>  
>  config BR2_PTHREADS
>  	bool "linuxthreads"
> -	depends on BR2_m68k || BR2_microblaze || BR2_or1k || BR2_arm || BR2_armeb || BR2_xtensa
> +	depends on !BR2_aarch64 && !BR2_aarch64_be
> +	depends on !BR2_RISCV_64
>  	select BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PTHREADS_NONE
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-21 16:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21  9:59 [Buildroot] [PATCH 1/1] package/uclibc: enable linuxthreads for MIPS Mircea GLIGA
2021-05-21 10:30 ` Yann E. MORIN
2021-05-21 11:36   ` Mircea GLIGA
2021-05-21 13:41 ` [Buildroot] [PATCH v2] package/uclibc: enable linuxthreads for all supported architectures Mircea GLIGA
2021-05-21 16:53   ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.