All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: abort in rename_exchange if we fail to insert the second ref
Date: Fri, 21 May 2021 15:12:51 +0200	[thread overview]
Message-ID: <20210521131251.GL7604@twin.jikos.cz> (raw)
In-Reply-To: <b14ab16d2685978c2d0b1dce7c1a2bb3ad8aa00a.1621447454.git.josef@toxicpanda.com>

On Wed, May 19, 2021 at 02:04:21PM -0400, Josef Bacik wrote:
> Error injection stress uncovered a problem where we'd leave a dangling
> inode ref if we failed during a rename_exchange.  This happens because
> we insert the inode ref for one side of the rename, and then for the
> other side.  If this second inode ref insert fails we'll leave the first
> one dangling and leave a corrupt file system behind.  Fix this by
> aborting if we did the insert for the first inode ref.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Added to misc-next, thanks.

      reply	other threads:[~2021-05-21 13:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 18:04 [PATCH] btrfs: abort in rename_exchange if we fail to insert the second ref Josef Bacik
2021-05-21 13:12 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521131251.GL7604@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.