From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AC1C43461 for ; Fri, 21 May 2021 13:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBBA5613EB for ; Fri, 21 May 2021 13:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235404AbhEUN1V (ORCPT ); Fri, 21 May 2021 09:27:21 -0400 Received: from foss.arm.com ([217.140.110.172]:47306 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbhEUN05 (ORCPT ); Fri, 21 May 2021 09:26:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 55B3811B3; Fri, 21 May 2021 06:25:34 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.33.243]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 795FC3F73B; Fri, 21 May 2021 06:25:28 -0700 (PDT) Date: Fri, 21 May 2021 14:25:19 +0100 From: Mark Rutland To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Sasha Levin , "Chang S. Bae" , Andi Kleen , Lei Cao , Peter Xu , Daniel Lezcano , Ulf Hansson , "Rafael J. Wysocki" , Jean-Philippe Brucker , Zaibo Xu , Kenneth Lee , Greg Kroah-Hartman , Hans Verkuil , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH v2 3/7] drivers: firmware: psci: Use _BITUL() macro in UAPI headers Message-ID: <20210521132519.GA7325@C02TD0UTHF1T.local> References: <20210520104343.317119-1-joerichey94@gmail.com> <20210521085849.37676-1-joerichey94@gmail.com> <20210521085849.37676-4-joerichey94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521085849.37676-4-joerichey94@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 01:58:44AM -0700, Joe Richey wrote: > From: Joe Richey > > Replace BIT() in psci's UPAI header with _BITUL(). BIT() is not defined > in the UAPI headers and its usage may cause userspace build errors. > > Fixes: 60dd1ead65e8 ("drivers: firmware: psci: Announce support for OS initiated suspend mode") > Signed-off-by: Joe Richey Acked-by: Mark Rutland Mark. > --- > include/uapi/linux/psci.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h > index 2fcad1dd0b0e..87afdeb95096 100644 > --- a/include/uapi/linux/psci.h > +++ b/include/uapi/linux/psci.h > @@ -12,6 +12,8 @@ > #ifndef _UAPI_LINUX_PSCI_H > #define _UAPI_LINUX_PSCI_H > > +#include > + > /* > * PSCI v0.1 interface > * > @@ -100,7 +102,7 @@ > #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK \ > (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT) > > -#define PSCI_1_0_OS_INITIATED BIT(0) > +#define PSCI_1_0_OS_INITIATED _BITUL(0) > #define PSCI_1_0_SUSPEND_MODE_PC 0 > #define PSCI_1_0_SUSPEND_MODE_OSI 1 > > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC10C433B4 for ; Fri, 21 May 2021 13:27:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB95461261 for ; Fri, 21 May 2021 13:27:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB95461261 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IdJyisUbcWB/LCZbu6J6R12yFS49UeKLXALVL3sHQz8=; b=nY5IM+bQaHSgez1Uo8kGbwotxE B3qqW9xGN1Zt4sfR8p65I42i0Wcg8ymFt5LHr+pjH48bhFR0AplzthsNqfrjJA3JtTO2rIPXHWS8H +Q8h+aRoCK9HY7eWtAqbX+jPpMplA7ljNcN43qYC2HQqhDK+UFz1VZcE/i+fXGssmfkaKGND6fqak ERwVX6XTd82Z7TXwS1hU4KPO3lHyzC4cMMyOaeKMyQL6sEr0tjs8fOAqjQiEVqW17gpJGEkhMPCIC EJ+VU/FlJEDTzigEEGALht8wLiMey+hRKqPVrtURNkkAao/z/h9swPLGOoXghJWY+nr/nBhhPcOUR nyc0yveA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk59r-005VEE-57; Fri, 21 May 2021 13:25:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk59m-005VCz-MS for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 13:25:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BrMuO8zKUQZXiZMl4byp5s4jBNUfKWjrCHGRQ2C5rBg=; b=TRgFsQKxod3I8adZoRHDSZMN+m iKM9IKU84pqoaQEiDGcpKDfp3ZkLYWjtfh2TSc7OLeEaMYjDJF8hBrqKc6VOEOEOXPgKQ5veYAvDA Sjdoea0PIq8m5C/u2C3vePAbUpk6zF2MawkpLqKSBw9xHprGg8GsSR8azXkZO1ZHKAqGCW2CCK1Uk FMYymGmi2QbHi+1WTtZeoxrxLjVYNpFj2QIlZ8yGzmgXc+jJ8Y6bX/DtmnmUOQ+Yc6vGrzJU/poXO k4mfQ/1PUZKnjhtSxNKdZEGeK4RVc0ifu7k7Ko+DbvupOJCaEVkO6ojF2bRNyoSy/3fEnHAligq8J Z9lKofHg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lk59k-00H8mq-53 for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 13:25:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 55B3811B3; Fri, 21 May 2021 06:25:34 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.33.243]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 795FC3F73B; Fri, 21 May 2021 06:25:28 -0700 (PDT) Date: Fri, 21 May 2021 14:25:19 +0100 From: Mark Rutland To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Sasha Levin , "Chang S. Bae" , Andi Kleen , Lei Cao , Peter Xu , Daniel Lezcano , Ulf Hansson , "Rafael J. Wysocki" , Jean-Philippe Brucker , Zaibo Xu , Kenneth Lee , Greg Kroah-Hartman , Hans Verkuil , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH v2 3/7] drivers: firmware: psci: Use _BITUL() macro in UAPI headers Message-ID: <20210521132519.GA7325@C02TD0UTHF1T.local> References: <20210520104343.317119-1-joerichey94@gmail.com> <20210521085849.37676-1-joerichey94@gmail.com> <20210521085849.37676-4-joerichey94@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521085849.37676-4-joerichey94@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_062536_284796_AB3EF5C7 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 01:58:44AM -0700, Joe Richey wrote: > From: Joe Richey > > Replace BIT() in psci's UPAI header with _BITUL(). BIT() is not defined > in the UAPI headers and its usage may cause userspace build errors. > > Fixes: 60dd1ead65e8 ("drivers: firmware: psci: Announce support for OS initiated suspend mode") > Signed-off-by: Joe Richey Acked-by: Mark Rutland Mark. > --- > include/uapi/linux/psci.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h > index 2fcad1dd0b0e..87afdeb95096 100644 > --- a/include/uapi/linux/psci.h > +++ b/include/uapi/linux/psci.h > @@ -12,6 +12,8 @@ > #ifndef _UAPI_LINUX_PSCI_H > #define _UAPI_LINUX_PSCI_H > > +#include > + > /* > * PSCI v0.1 interface > * > @@ -100,7 +102,7 @@ > #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK \ > (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT) > > -#define PSCI_1_0_OS_INITIATED BIT(0) > +#define PSCI_1_0_OS_INITIATED _BITUL(0) > #define PSCI_1_0_SUSPEND_MODE_PC 0 > #define PSCI_1_0_SUSPEND_MODE_OSI 1 > > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel