linux-next: Signed-off-by missing for commit in the nfsd tree

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi all,

Commit

  ff78b9442926 ("NFSD add vfs_fsync after async copy is done")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
> 
> is missing a Signed-off-by from its author.

Olga, can I add

	Signed-off-by: Olga Kornievskaia <kolga@netapp.com>

?

--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[Kornievskaia, Olga]

On 5/21/21, 9:51 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:

    NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.




    On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
    > Hi all,
    >
    > Commit
    >
    >   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
    >
    > is missing a Signed-off-by from its author.

    Olga, can I add

            Signed-off-by: Olga Kornievskaia <kolga@netapp.com>

    ?

[olga] But the post/patch contains that? I don’t understand. Even attached file has it. I think what trips these system is that I use gmail to submit patches but signed-off-by is from my netapp email. Unfortunately, I have no way of submitting them from netapp. So the patch is correct the automated system is let's say is "too strict"?

    --b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Fri, May 21, 2021 at 01:55:03PM +0000, Kornievskaia, Olga wrote:
> 
> 
> On 5/21/21, 9:51 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> 
>     NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> 
> 
>     On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
>     > Hi all,
>     >
>     > Commit
>     >
>     >   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
>     >
>     > is missing a Signed-off-by from its author.
> 
>     Olga, can I add
> 
>             Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> 
>     ?
> 
> [olga] But the post/patch contains that?

Whoops, you're right.

> I don’t understand. Even attached file has it. I think what trips
> these system is that I use gmail to submit patches but signed-off-by
> is from my netapp email. Unfortunately, I have no way of submitting
> them from netapp. So the patch is correct the automated system is
> let's say is "too strict"?

I'm using "git am -s" and that's not picking up your Signed-off-by line
for some reason.  Looking at the mail....

Oh, I see, your mail looked in part like:

  However, in order to save the client doing a COMMIT as a separate
  rpc, the server can reply back with NFS_FILE_SYNC copy. This patch
  proposed to add vfs_fsync() call at the end of the async copy.
  
  --- v2: moved the committed argument into the nfsd4_copy structure
  
  Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
  ---
   fs/nfsd/nfs4proc.c | 14 +++++++++++++-
    fs/nfsd/xdr4.h     |  1 +
     2 files changed, 14 insertions(+), 1 deletion(-)

But git uses "---" to mark the end of the changelog.  That allows you to
include the diffstat, or any other notes that you want included in the
mail but not in the final changelog.

That "v2:" note is probably also something that belongs in the mail but
not the changelog, so in future if you just move that kind of thing to
after the Signed-off-by line, git-am will do the right thing.

--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[Kornievskaia, Olga]

On 5/21/21, 10:01 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:

    NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.




    On Fri, May 21, 2021 at 01:55:03PM +0000, Kornievskaia, Olga wrote:
    >
    >
    > On 5/21/21, 9:51 AM, "J. Bruce Fields" <bfields@fieldses.org> wrote:
    >
    >     NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.
    >
    >
    >
    >
    >     On Fri, May 21, 2021 at 08:04:16AM +1000, Stephen Rothwell wrote:
    >     > Hi all,
    >     >
    >     > Commit
    >     >
    >     >   ff78b9442926 ("NFSD add vfs_fsync after async copy is done")
    >     >
    >     > is missing a Signed-off-by from its author.
    >
    >     Olga, can I add
    >
    >             Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
    >
    >     ?
    >
    > [olga] But the post/patch contains that?

    Whoops, you're right.

    > I don’t understand. Even attached file has it. I think what trips
    > these system is that I use gmail to submit patches but signed-off-by
    > is from my netapp email. Unfortunately, I have no way of submitting
    > them from netapp. So the patch is correct the automated system is
    > let's say is "too strict"?

    I'm using "git am -s" and that's not picking up your Signed-off-by line
    for some reason.  Looking at the mail....

    Oh, I see, your mail looked in part like:

      However, in order to save the client doing a COMMIT as a separate
      rpc, the server can reply back with NFS_FILE_SYNC copy. This patch
      proposed to add vfs_fsync() call at the end of the async copy.

      --- v2: moved the committed argument into the nfsd4_copy structure

      Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
      ---
       fs/nfsd/nfs4proc.c | 14 +++++++++++++-
        fs/nfsd/xdr4.h     |  1 +
         2 files changed, 14 insertions(+), 1 deletion(-)

    But git uses "---" to mark the end of the changelog.  That allows you to
    include the diffstat, or any other notes that you want included in the
    mail but not in the final changelog.

    That "v2:" note is probably also something that belongs in the mail but
    not the changelog, so in future if you just move that kind of thing to
    after the Signed-off-by line, git-am will do the right thing.

[olga] Ah, thank you for figuring it out. Do you need another version or can you move the line?

    --b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Fri, May 21, 2021 at 02:42:53PM +0000, Kornievskaia, Olga wrote:
> [olga] Ah, thank you for figuring it out. Do you need another version
> or can you move the line?

I've fixed it, thanks.

--b.

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Hi all,

Commit

  52e66ccaa3ca ("debug")

is missing a Signed-off-by from its author and commiter.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi all,

Commit

  bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Mon, Nov 09, 2020 at 08:20:32AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")
> 
> is missing a Signed-off-by from its author.

I split the original patch in 2 and fixed a bug in this second patch,
but unless I hear otherwise I'll assume Dan's OK with his Signed-off-by
staying on both....

--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[Dan Carpenter]

On Sun, Nov 08, 2020 at 04:29:36PM -0500, J. Bruce Fields wrote:
> On Mon, Nov 09, 2020 at 08:20:32AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   bfb5aa1685d5 ("net/sunrpc: fix useless comparison in proc_do_xprt()")
> > 
> > is missing a Signed-off-by from its author.
> 
> I split the original patch in 2 and fixed a bug in this second patch,
> but unless I hear otherwise I'll assume Dan's OK with his Signed-off-by
> staying on both....

Yep.  Thanks!

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi all,

Commit

  51100d2b87cb ("NFSD generalize nfsd4_compound_state flag names")

is missing a Signed-off-by from its author.

Commits

  ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy")
  b9e8638e3d9e ("NFSD: allow inter server COPY to have a STALE source server fh")
  51100d2b87cb ("NFSD generalize nfsd4_compound_state flag names")
  b7342204253a ("NFSD check stateids against copy stateids")
  624322f1adc5 ("NFSD add COPY_NOTIFY operation")
  51911868fc62 ("NFSD COPY_NOTIFY xdr")
  84e1b21d5ec4 ("NFSD add ca_source_server<> to COPY")
  af76fc6c158d ("NFSD fill-in netloc4 structure")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  dd4320a29d65 ("NFSD generalize nfsd4_compound_state flag names")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

Hi,

Commit

  35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Thu, Feb 22, 2018 at 06:39:43AM +0000, James Ettle wrote:
> I only really posted this as a demo of a fix. I was hoping someone who actually knows what they're doing in the kernel would pick it up and make it proper.

Whoops, sorry, I didn't realize that.

But I don't see a problem with the patch as it is.  Are you OK with me
adding your signed-off-by?

--b.

> 
> Thanks,
> James.
> 
> 
> On 22 February 2018 04:17:23 GMT+00:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >Hi,
> >
> >Commit
> >
> >  35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")
> >
> >is missing a Signed-off-by from its author.
> >
> >-- 
> >Cheers,
> >Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[James Ettle]

Hello,

I'm OK with that. (This is the first time I've ventured into kernel space so I thought it better to at least sketch a solution and let the experts do it correctly ;) Glad it's passed the review!)

Thanks,
James.

On 23 February 2018 01:05:45 GMT+00:00, "J. Bruce Fields" <bfields@fieldses.org> wrote:
>On Thu, Feb 22, 2018 at 06:39:43AM +0000, James Ettle wrote:
>> I only really posted this as a demo of a fix. I was hoping someone
>who actually knows what they're doing in the kernel would pick it up
>and make it proper.
>
>Whoops, sorry, I didn't realize that.
>
>But I don't see a problem with the patch as it is.  Are you OK with me
>adding your signed-off-by?
>
>--b.
>
>> 
>> Thanks,
>> James.
>> 
>> 
>> On 22 February 2018 04:17:23 GMT+00:00, Stephen Rothwell
><sfr@canb.auug.org.au> wrote:
>> >Hi,
>> >
>> >Commit
>> >
>> >  35da1ba8af70 ("sunrpc: Fix unaligned access on sparc64")
>> >
>> >is missing a Signed-off-by from its author.
>> >
>> >-- 
>> >Cheers,
>> >Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Fri, Feb 23, 2018 at 12:41:05PM +0000, James Ettle wrote:
> I'm OK with that. (This is the first time I've ventured into kernel space so I thought it better to at least sketch a solution and let the experts do it correctly ;) Glad it's passed the review!)

OK, thanks!--b.

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

Hi Bruce,

Commit

  64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Tue, Nov 28, 2017 at 09:52:56AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
> 
> Commit
> 
>   64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")
> 
> is missing a Signed-off-by from its author.

Previously:

	http://lkml.kernel.org/r/20171109200609.GM8773@fieldses.org

	It fixes a typo in two lines in pretty much the only way
	possible, so there should not be copyright concerns.

	Naofumi Honda is as far as I know a one-time contributor, and
	I'd prefer not to burden such folks with unnecessary
	bureaucracy.

I rebased (probably unnecessarily, sorry), so your scripts probably
caught this as a new commit.

--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

Hi Bruce,

On Mon, 27 Nov 2017 20:38:40 -0500 "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> I rebased (probably unnecessarily, sorry), so your scripts probably
> caught this as a new commit.

Ah, OK, sorry for the noise.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

Hi,

Commit

  988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Fri, Nov 10, 2017 at 06:51:35AM +1100, Stephen Rothwell wrote:
> Hi,
> 
> Commit
> 
>   988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from nfs4_laundromat")
> 
> is missing a Signed-off-by from its author.

It fixes a typo in two lines in pretty much the only way possible, so
there should not be copyright concerns.

Naofumi Honda is as far as I know a one-time contributor, and I'd prefer
not to burden such folks with unnecessary bureaucracy.

--b.

linux-next: Signed-off-by missing for commit in the nfsd tree

[Stephen Rothwell]

Hi Bruce,

Commit

  1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> Hi Bruce,
> 
> Commit
> 
>   1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
> 
> is missing a Signed-off-by from its author and committer.

Fixed, thanks.--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

[J. Bruce Fields]

On Thu, Aug 24, 2017 at 10:21:41PM -0400, J. Bruce Fields wrote:
> On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> > Hi Bruce,
> > 
> > Commit
> > 
> >   1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
> > 
> > is missing a Signed-off-by from its author and committer.
> 
> Fixed, thanks.--b.

And, sorry, somehow I lost your other message, but: the compiler errors
should also have been fixed.  (As should be the testing error that let
them slip through--I thought I had CONFIG_NFSD_PNFS turned on in my
testing, but I didn't.)

--b.