From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF664C433ED for ; Fri, 21 May 2021 14:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A023B613D8 for ; Fri, 21 May 2021 14:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235057AbhEUOTm (ORCPT ); Fri, 21 May 2021 10:19:42 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:59660 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhEUOTk (ORCPT ); Fri, 21 May 2021 10:19:40 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14LE2Inb024640; Fri, 21 May 2021 16:18:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=UfQOTLbkM5w8D/KIYvHVMy2nA0UDWziGT2f0VY3jfnw=; b=1PrZPjnbmfD9UoaN/jBRS2dPS1WLfEbMmPFiNsX2qW5sb5UnJuHtxa3insDI25ZQqsa6 o4ls9W74zw8jNslTFjaDy4aAB+t5k59P9vb0hGxDHhAIJgnlA8wLe5iDU0MJsI0Q7W8W p5PRX/lseHfQZPxXbKAoyOkRdN2fWzvCmzywlhZseH2+MKoUn0o9KQOfkEhgGPIwvVZB qbeX/ghSA2JyWPtgRkajzsjxwXkA6tagvTYRb0z5K/dtNjyXMffxouFMMNQIyD4SqByN rfJGBynx2DA1uOfI/n28aQNf7rsrBt9ouU1FmBFQP3LDeeCKR1nBLjlQ4TPxDvsEBHGp lA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38p3c53ehb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 May 2021 16:18:08 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E621810002A; Fri, 21 May 2021 16:18:05 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D964C226787; Fri, 21 May 2021 16:18:05 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 21 May 2021 16:18:05 +0200 Date: Fri, 21 May 2021 16:17:57 +0200 From: Alain Volmat To: Lee Jones CC: , Patrice Chotard , Maxime Coquelin , , Subject: Re: [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function misnaming issues Message-ID: <20210521141757.GA17641@gnbcxd0016.gnb.st.com> Mail-Followup-To: Lee Jones , linux-kernel@vger.kernel.org, Patrice Chotard , Maxime Coquelin , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org References: <20210520190105.3772683-1-lee.jones@linaro.org> <20210520190105.3772683-14-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210520190105.3772683-14-lee.jones@linaro.org> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-21_05:2021-05-20,2021-05-21 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the fix. I was about to propose it ;) On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead > drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead > > Cc: Patrice Chotard > Cc: Maxime Coquelin > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/i2c/busses/i2c-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c > index faa81a95551fe..30089b38044b5 100644 > --- a/drivers/i2c/busses/i2c-st.c > +++ b/drivers/i2c/busses/i2c-st.c > @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev) > } > > /** > - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read > + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read Could you also fix the typo enmpty -> empty at the same time ? > * @i2c_dev: Controller's private data > */ > static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > } > > /** > - * st_i2c_isr() - Interrupt routine > + * st_i2c_isr_thread() - Interrupt routine > * @irq: interrupt number > * @data: Controller's private data > */ > -- > 2.31.1 > Regards, Alain From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A98AC433B4 for ; Fri, 21 May 2021 14:20:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22737613D8 for ; Fri, 21 May 2021 14:20:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22737613D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GUFQIq7tvMpNRPn/ZAZucl0iC8uyZdFb/Bhc+Eh0lJE=; b=LOEzeebPRofBRbLbfLODoph+2d mcCUtWmI7zfSrcjWZC1wVtZ1DBhvtNoc3E3aMHB+0VIbJA6H7Gl+KKnSl7vSWosFITjybXNGs5unE b/SLYpuGLPUTJBX7iPy/QBsszx4tmyBkDOxw0vuqSM6PwqL4/Y2rypxUomohjhfQUJWF34/Ji8TfQ /+yBwDTpW2cMFdSAr6t611yQ2fPYdu/cHA2N48nYOxz8RMs72C8feHM88pHPTugP7FX3gpUhh1I03 g4PenqErFY+vyfi8qY9ojym2ixB42PixKyNSBiP5BwE4QzQRDaZeTCzjh5TuDvxEfIQqnFMIl+DIf 7zJ2PgoA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk5yn-005jyD-6Q; Fri, 21 May 2021 14:18:21 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk5yk-005jxu-IE for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 14:18:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UfQOTLbkM5w8D/KIYvHVMy2nA0UDWziGT2f0VY3jfnw=; b=HTTUd3tEej/44PYWGUGSwc0VXv nGSl93oypIlxY9sn3MHwaPq2SKV9p5WNDjfcnLexySgzfJZ9arRcq1ik8IlLFDSE2AkKV8l0NPzCc L+CeesrhJ7fOvDke8bNN9h1rrsJH76WsNUG8Je/qVUb92/wFhQ/LQNb2hZbsWJkAilPVJVYf2VD57 2mqLciA230q706HQBDHCjaKOLD+7wWrTUj3PJOL8Ks6bAHRjpO/gFS/VO2+6iIJ+nndjKaDFhReYu HIy8z0h8xtmHPudEcLZmkUS1xgLgaVv7EfDnqZiKRf57VfnMPyXer3trk/5Ip4bpkaDN0npYLI1uY y7M+EltA==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk5yg-00HBRd-Q8 for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 14:18:16 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14LE2Inb024640; Fri, 21 May 2021 16:18:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=UfQOTLbkM5w8D/KIYvHVMy2nA0UDWziGT2f0VY3jfnw=; b=1PrZPjnbmfD9UoaN/jBRS2dPS1WLfEbMmPFiNsX2qW5sb5UnJuHtxa3insDI25ZQqsa6 o4ls9W74zw8jNslTFjaDy4aAB+t5k59P9vb0hGxDHhAIJgnlA8wLe5iDU0MJsI0Q7W8W p5PRX/lseHfQZPxXbKAoyOkRdN2fWzvCmzywlhZseH2+MKoUn0o9KQOfkEhgGPIwvVZB qbeX/ghSA2JyWPtgRkajzsjxwXkA6tagvTYRb0z5K/dtNjyXMffxouFMMNQIyD4SqByN rfJGBynx2DA1uOfI/n28aQNf7rsrBt9ouU1FmBFQP3LDeeCKR1nBLjlQ4TPxDvsEBHGp lA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38p3c53ehb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 May 2021 16:18:08 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E621810002A; Fri, 21 May 2021 16:18:05 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D964C226787; Fri, 21 May 2021 16:18:05 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 21 May 2021 16:18:05 +0200 Date: Fri, 21 May 2021 16:17:57 +0200 From: Alain Volmat To: Lee Jones CC: , Patrice Chotard , Maxime Coquelin , , Subject: Re: [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function misnaming issues Message-ID: <20210521141757.GA17641@gnbcxd0016.gnb.st.com> Mail-Followup-To: Lee Jones , linux-kernel@vger.kernel.org, Patrice Chotard , Maxime Coquelin , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org References: <20210520190105.3772683-1-lee.jones@linaro.org> <20210520190105.3772683-14-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520190105.3772683-14-lee.jones@linaro.org> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-21_05:2021-05-20, 2021-05-21 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_071815_230552_E40C9DA8 X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for the fix. I was about to propose it ;) On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead > drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead > > Cc: Patrice Chotard > Cc: Maxime Coquelin > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/i2c/busses/i2c-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c > index faa81a95551fe..30089b38044b5 100644 > --- a/drivers/i2c/busses/i2c-st.c > +++ b/drivers/i2c/busses/i2c-st.c > @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev) > } > > /** > - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read > + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read Could you also fix the typo enmpty -> empty at the same time ? > * @i2c_dev: Controller's private data > */ > static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > } > > /** > - * st_i2c_isr() - Interrupt routine > + * st_i2c_isr_thread() - Interrupt routine > * @irq: interrupt number > * @data: Controller's private data > */ > -- > 2.31.1 > Regards, Alain _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel