From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754E4C433B4 for ; Fri, 21 May 2021 14:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 522B1613DD for ; Fri, 21 May 2021 14:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236687AbhEUOYi (ORCPT ); Fri, 21 May 2021 10:24:38 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:37302 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236338AbhEUOYf (ORCPT ); Fri, 21 May 2021 10:24:35 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14LE3Ijk029199; Fri, 21 May 2021 16:23:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=Qs5lu+rz1M3h2XolN2IhO6/pPCgYiG7nes1ykQCrdDg=; b=G7IYe8CAcQyv0ZsYvLKbjCOecP2QkpR0znTbMpA+394QAVyZukxN00aQAZ0+zJ2epaiF QKwRu9Hzp3l0Bu99NXxu0QPHxYhY6UYpdRqB2P+yX+kVcONiVB3zWTn8S7kWRZdCyZUs cCtsZzbNlTC/1hrSPieOI49hY1bAocMo2C+bBzHnurg8lvHOq9QsMlZRrM275ZH0siig /aELPK2prfmJqx3atS3TDlDyqGETeoqj2gR/mhKbgE3z8HdExChwvxK75jcUsM1juDBP jsHi5Cp1kdaWzDsKynEsBlKx3/P6szkireEy2iLVmsc0d+Id2wYxYckbezxz8mynZVbZ kw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38p2tc3m6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 May 2021 16:23:08 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 167A810002A; Fri, 21 May 2021 16:23:07 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0A501226792; Fri, 21 May 2021 16:23:07 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 21 May 2021 16:23:06 +0200 Date: Fri, 21 May 2021 16:23:05 +0200 From: Alain Volmat To: Lee Jones , , Patrice Chotard , Maxime Coquelin , , Subject: Re: [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function misnaming issues Message-ID: <20210521142305.GC17641@gnbcxd0016.gnb.st.com> Mail-Followup-To: Lee Jones , linux-kernel@vger.kernel.org, Patrice Chotard , Maxime Coquelin , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org References: <20210520190105.3772683-1-lee.jones@linaro.org> <20210520190105.3772683-14-lee.jones@linaro.org> <20210521141757.GA17641@gnbcxd0016.gnb.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210521141757.GA17641@gnbcxd0016.gnb.st.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-21_05:2021-05-20,2021-05-21 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oups, didn't notice the typo fix was done in another patch. All ok for me then. Reviewed-by: Alain Volmat On Fri, May 21, 2021 at 04:17:57PM +0200, Alain Volmat wrote: > Thanks for the fix. I was about to propose it ;) > > On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead > > drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead > > > > Cc: Patrice Chotard > > Cc: Maxime Coquelin > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-i2c@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/i2c/busses/i2c-st.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c > > index faa81a95551fe..30089b38044b5 100644 > > --- a/drivers/i2c/busses/i2c-st.c > > +++ b/drivers/i2c/busses/i2c-st.c > > @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev) > > } > > > > /** > > - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read > > + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read > > Could you also fix the typo enmpty -> empty at the same time ? > > > * @i2c_dev: Controller's private data > > */ > > static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > > @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > > } > > > > /** > > - * st_i2c_isr() - Interrupt routine > > + * st_i2c_isr_thread() - Interrupt routine > > * @irq: interrupt number > > * @data: Controller's private data > > */ > > -- > > 2.31.1 > > > > Regards, > Alain From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2141C433ED for ; Fri, 21 May 2021 14:24:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B4A0613DD for ; Fri, 21 May 2021 14:24:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B4A0613DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0G+Rm5qsX+8ehlD92s3rYbPV9RFJyyW2WxIIT52ijHA=; b=bZ7D9EgzhAml2uKX8MwvPcY/na yrXembVnMVW02UcvAvl/KT8D10V4lRZYrjXsSG0Dwek2BekiGnhRRS2XMeCD9Dxg4j2jA1IurMHjk 03VpcbqkjI+HWiqXxnsBI0BSDB8xBzIGMMRlt0iMeGBXznIllKc74JBCKIwracdsv68dilOTJJeHe GFEED/N+F+r68WFrwHRtSnsxf1H9u67pFAIr1GBQ0/eKM5/8PHB5fQ93mYXNmB3/hozirGem/dbgn gQBeSTj9mUgB6M7ghcNKMif7eXTLsspxZ+DOq9O6W/+ygKiAMe19TsNOyAvWkCs+osdT7nDS0VJYF 4nUsiLog==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk63Y-005kcb-KA; Fri, 21 May 2021 14:23:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk63V-005kcA-Pe for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 14:23:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qs5lu+rz1M3h2XolN2IhO6/pPCgYiG7nes1ykQCrdDg=; b=lfd0ok5Od4CmPSiGgdlgS4rFgP /59BRtxxhdXWNyUFxrj1mSmGw1nnBoCxi9NZLBH/YddNBRWfVi9OAp/sv1Idpc42JIZuNGvTiZ0Xh vAP0PyEPGmoC6VUCO9GAuU8Ojlf0FkDqH5co3PEucOlLnMLjincpenUw8xfNpO4eu7KOw4ZmXgi6K ULZpf2rKZ5t2Nj7l3G6h+CmTrF6mzRFoSE1n2gtRDbWiwZ6cxNWmBOQBaSgmt63eqKRZUkQUap18P jfNjaabcEDbpRETDuIVcHZJCJ3FzKdm16ViqGZAXxUqj5XfVdW1iNLEfG4jysMxs4vxu9qFPOR7Z2 DkB59QoQ==; Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk63R-00HBe4-Us for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 14:23:11 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14LE3Ijk029199; Fri, 21 May 2021 16:23:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=Qs5lu+rz1M3h2XolN2IhO6/pPCgYiG7nes1ykQCrdDg=; b=G7IYe8CAcQyv0ZsYvLKbjCOecP2QkpR0znTbMpA+394QAVyZukxN00aQAZ0+zJ2epaiF QKwRu9Hzp3l0Bu99NXxu0QPHxYhY6UYpdRqB2P+yX+kVcONiVB3zWTn8S7kWRZdCyZUs cCtsZzbNlTC/1hrSPieOI49hY1bAocMo2C+bBzHnurg8lvHOq9QsMlZRrM275ZH0siig /aELPK2prfmJqx3atS3TDlDyqGETeoqj2gR/mhKbgE3z8HdExChwvxK75jcUsM1juDBP jsHi5Cp1kdaWzDsKynEsBlKx3/P6szkireEy2iLVmsc0d+Id2wYxYckbezxz8mynZVbZ kw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38p2tc3m6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 May 2021 16:23:08 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 167A810002A; Fri, 21 May 2021 16:23:07 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0A501226792; Fri, 21 May 2021 16:23:07 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 21 May 2021 16:23:06 +0200 Date: Fri, 21 May 2021 16:23:05 +0200 From: Alain Volmat To: Lee Jones , , Patrice Chotard , Maxime Coquelin , , Subject: Re: [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function misnaming issues Message-ID: <20210521142305.GC17641@gnbcxd0016.gnb.st.com> Mail-Followup-To: Lee Jones , linux-kernel@vger.kernel.org, Patrice Chotard , Maxime Coquelin , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org References: <20210520190105.3772683-1-lee.jones@linaro.org> <20210520190105.3772683-14-lee.jones@linaro.org> <20210521141757.GA17641@gnbcxd0016.gnb.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521141757.GA17641@gnbcxd0016.gnb.st.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-21_05:2021-05-20, 2021-05-21 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_072310_299045_2188DB2E X-CRM114-Status: GOOD ( 22.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Oups, didn't notice the typo fix was done in another patch. All ok for me then. Reviewed-by: Alain Volmat On Fri, May 21, 2021 at 04:17:57PM +0200, Alain Volmat wrote: > Thanks for the fix. I was about to propose it ;) > > On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead > > drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead > > > > Cc: Patrice Chotard > > Cc: Maxime Coquelin > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-i2c@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/i2c/busses/i2c-st.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c > > index faa81a95551fe..30089b38044b5 100644 > > --- a/drivers/i2c/busses/i2c-st.c > > +++ b/drivers/i2c/busses/i2c-st.c > > @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev) > > } > > > > /** > > - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read > > + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read > > Could you also fix the typo enmpty -> empty at the same time ? > > > * @i2c_dev: Controller's private data > > */ > > static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > > @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > > } > > > > /** > > - * st_i2c_isr() - Interrupt routine > > + * st_i2c_isr_thread() - Interrupt routine > > * @irq: interrupt number > > * @data: Controller's private data > > */ > > -- > > 2.31.1 > > > > Regards, > Alain _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel