From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2026C4707A for ; Fri, 21 May 2021 17:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C521E61353 for ; Fri, 21 May 2021 17:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238368AbhEURrM (ORCPT ); Fri, 21 May 2021 13:47:12 -0400 Received: from foss.arm.com ([217.140.110.172]:52618 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235399AbhEURrL (ORCPT ); Fri, 21 May 2021 13:47:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 904FD1424; Fri, 21 May 2021 10:45:47 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 445AC3F73D; Fri, 21 May 2021 10:45:45 -0700 (PDT) Date: Fri, 21 May 2021 18:45:42 +0100 From: Qais Yousef To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 00/21] Add support for 32-bit tasks on asymmetric AArch32 systems Message-ID: <20210521174542.2kojxgzrgdl6nqpx@e107158-lin.cambridge.arm.com> References: <20210518094725.7701-1-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210518094725.7701-1-will@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will On 05/18/21 10:47, Will Deacon wrote: > Hi folks, > > This is the long-awaited v6 of these patches which I last posted at the > end of last year: > > v1: https://lore.kernel.org/r/20201027215118.27003-1-will@kernel.org > v2: https://lore.kernel.org/r/20201109213023.15092-1-will@kernel.org > v3: https://lore.kernel.org/r/20201113093720.21106-1-will@kernel.org > v4: https://lore.kernel.org/r/20201124155039.13804-1-will@kernel.org > v5: https://lore.kernel.org/r/20201208132835.6151-1-will@kernel.org > > There was also a nice LWN writeup in case you've forgotten what this is > about: > > https://lwn.net/Articles/838339/ > > It's taken me a while to get a v6 of this together, partly due to > addressing the review feedback on v5, but also because this has now seen > testing on real hardware which threw up some surprises in suspend/resume, > SCHED_DEADLINE and compat hwcap reporting. Thanks to Quentin for helping > me to debug those issues. > > The aim of this series is to allow 32-bit ARM applications to run on > arm64 SoCs where not all of the CPUs support the 32-bit instruction set. > Unfortunately, such SoCs are real and will continue to be productised > over the next few years at least. I can assure you that I'm not just > doing this for fun. > > Changes in v6 include: > > * Save/restore the affinity mask across execve() to 32-bit and back to > 64-bit again. > > * Allow 32-bit deadline tasks, but skip straight to fallback path when > determining new affinity mask on execve(). > > * Fixed resume-from-suspend path when the resuming CPU is 64-bit-only > by deferring wake-ups for 32-bit tasks until the secondary CPUs are > back online. > > * Bug fixes (compat hwcaps, memory leak, cpuset fallback path). > > * Documentation for arm64. It's in the divisive .rst format, but please > take a look anyway! > > I'm pretty happy with this now and it seems to do the right thing, > although the new patches in this revision would certainly benefit from > review. Series based on v5.13-rc1. It's late Fri and I'm off next week (I'm starting to sense an omen here, it's the 2nd or 3rd time the post syncs with my holiday), so a bit of a rushed review but the series looks good to me. Feel free to stick my Reviewed-by for the series, except patch 13 where I skipped it, given the few comments I had are addressed. I did test v5, but not this version. I think it had found better victims to test it now :-P Thanks! -- Qais Yousef From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10655C4707A for ; Fri, 21 May 2021 17:47:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 866F46135C for ; Fri, 21 May 2021 17:47:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 866F46135C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IkdGVvbpeW6YQz1xbsw6dNwV4XqkoHSdnOm1+Cke/n4=; b=jsRXRt2VA/l4NZ29MfACl+MITt UTMExxpDDI0D8StxXWIKDDHMUQlJKvG+LsM/BIMfE/aVvCVM6HLDfLMKF7fXm2coI4NJukD8BbzAk 9SSMAk/srpEbrLjJo3pxccBD8c/4uYXnviZTzKD6K4AOhdMA4Hv+IZRD6NuXk7WjNExW7BQEptpgD 2leaH2joJeNQ9cPxnmcfe7PAUt1ZV+TdExngWfqRQKvLm5kzUiNdVnfreQAS5ZNXKFBkbqbktyKZD PU+3QGyr1h8BUoBSVF8g9BN4CDQhHh6qc5KiVuFDKnrGlqt/wG9hYI2Ypc1/ewXTkroBjuse8ONrg L0ZvJ3+w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk9Dj-000a6z-OT; Fri, 21 May 2021 17:46:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk9Dc-000a59-JM for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 17:45:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6cPQ/N0jG+qayDgkrZ67Ss/D9s/9Tmm+xkKF3CU5GnA=; b=1cc+XvamPo6mefGRdMqVRLdsIg l3s47qm94YuOIQ3dNJsvm95t5RvnWfdPfr7LQgtQGsrENTydxPDa2xz+QgqVgkKIVxqRXH5Jx7rSW 2rOxXAMrxyxREDpdfSrkjN+Oxu9x//JBd5Jj6zP+Fa5c5uMnfgCe9W5JyXss/COuJEfJTbtND2/h4 WxoBcChYaFilcq99mMQaoD3Zlc0y7LIRcYeF2U3M4lWp5WZibWDA1SZFbEYZ0Tr/NCkKmXKCwE38d XQCG79jBO3rgzxUs/rhMsDFUrzy/8tXYtUxU/ODFRGfYDJm6449hEbAcAbhArXtHCMOEVUakFr+Lq qieSzV8A==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lk9DY-00HKDg-Ti for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 17:45:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 904FD1424; Fri, 21 May 2021 10:45:47 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 445AC3F73D; Fri, 21 May 2021 10:45:45 -0700 (PDT) Date: Fri, 21 May 2021 18:45:42 +0100 From: Qais Yousef To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 00/21] Add support for 32-bit tasks on asymmetric AArch32 systems Message-ID: <20210521174542.2kojxgzrgdl6nqpx@e107158-lin.cambridge.arm.com> References: <20210518094725.7701-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210518094725.7701-1-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_104549_074732_53716E7C X-CRM114-Status: GOOD ( 26.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will On 05/18/21 10:47, Will Deacon wrote: > Hi folks, > > This is the long-awaited v6 of these patches which I last posted at the > end of last year: > > v1: https://lore.kernel.org/r/20201027215118.27003-1-will@kernel.org > v2: https://lore.kernel.org/r/20201109213023.15092-1-will@kernel.org > v3: https://lore.kernel.org/r/20201113093720.21106-1-will@kernel.org > v4: https://lore.kernel.org/r/20201124155039.13804-1-will@kernel.org > v5: https://lore.kernel.org/r/20201208132835.6151-1-will@kernel.org > > There was also a nice LWN writeup in case you've forgotten what this is > about: > > https://lwn.net/Articles/838339/ > > It's taken me a while to get a v6 of this together, partly due to > addressing the review feedback on v5, but also because this has now seen > testing on real hardware which threw up some surprises in suspend/resume, > SCHED_DEADLINE and compat hwcap reporting. Thanks to Quentin for helping > me to debug those issues. > > The aim of this series is to allow 32-bit ARM applications to run on > arm64 SoCs where not all of the CPUs support the 32-bit instruction set. > Unfortunately, such SoCs are real and will continue to be productised > over the next few years at least. I can assure you that I'm not just > doing this for fun. > > Changes in v6 include: > > * Save/restore the affinity mask across execve() to 32-bit and back to > 64-bit again. > > * Allow 32-bit deadline tasks, but skip straight to fallback path when > determining new affinity mask on execve(). > > * Fixed resume-from-suspend path when the resuming CPU is 64-bit-only > by deferring wake-ups for 32-bit tasks until the secondary CPUs are > back online. > > * Bug fixes (compat hwcaps, memory leak, cpuset fallback path). > > * Documentation for arm64. It's in the divisive .rst format, but please > take a look anyway! > > I'm pretty happy with this now and it seems to do the right thing, > although the new patches in this revision would certainly benefit from > review. Series based on v5.13-rc1. It's late Fri and I'm off next week (I'm starting to sense an omen here, it's the 2nd or 3rd time the post syncs with my holiday), so a bit of a rushed review but the series looks good to me. Feel free to stick my Reviewed-by for the series, except patch 13 where I skipped it, given the few comments I had are addressed. I did test v5, but not this version. I think it had found better victims to test it now :-P Thanks! -- Qais Yousef _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel