From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A4DC2B9FB for ; Sat, 22 May 2021 10:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB30961182 for ; Sat, 22 May 2021 10:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbhEVKKq (ORCPT ); Sat, 22 May 2021 06:10:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:51574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230146AbhEVKKm (ORCPT ); Sat, 22 May 2021 06:10:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B95D61182; Sat, 22 May 2021 10:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621678158; bh=aFrt6ABG40tFAQSuyTdLlrinFx0PuyvgSdE1Yz010s8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FnMMGM9QgIf3/R3O3DhQeb36yjQi1k6zihs0111Ykftu0V6SQQiIkR3DOA8G9NMnB NuJwc8mlRpa3x+jkzDXk6TGS7dOQvvjtgV5Y1nIuWjqtCW+rV7rZcDWaQ1uzF6Naro vK2HOkTczyuY6qpbajDXrrHkxSJug3XuUC0VJibNLWyZqpcZiTRWheppW789qJKnrq O/aRh+k+Qqw3i9nvwKPCBtUMgyP2+5RbnPySebBXxf5z4rDonqkO0ZgMs0RSI1kagh flrGALVjUTBMyP+tSag8J7QSAdGaEc7jfy8J7GIBm1rTuAQBDiuGUxa6/igGcBbOwZ Emr5dPM06rlJw== Date: Sat, 22 May 2021 18:09:13 +0800 From: Peter Chen To: Sanket Parmar , pawell@cadence.com Cc: a-govindraju@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kurahul@cadence.com, gregkh@linuxfoundation.org, kishon@ti.com Subject: Re: [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep Message-ID: <20210522100913.GB12415@b29397-desktop> References: <1621263912-13175-1-git-send-email-sparmar@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621263912-13175-1-git-send-email-sparmar@cadence.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-05-17 17:05:12, Sanket Parmar wrote: > ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used > as TDL source for IN endpoints. To fix it, TDL_CHK is only > enabled for OUT endpoints. > > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") > Reported-by: Aswath Govindraju > Signed-off-by: Sanket Parmar > --- > drivers/usb/cdns3/cdns3-gadget.c | 8 +++----- > 1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c > index 105855a..f3c0276 100644 > --- a/drivers/usb/cdns3/cdns3-gadget.c > +++ b/drivers/usb/cdns3/cdns3-gadget.c > @@ -2007,7 +2007,7 @@ static void cdns3_configure_dmult(struct cdns3_device *priv_dev, > else > mask = BIT(priv_ep->num); > > - if (priv_ep->type != USB_ENDPOINT_XFER_ISOC) { > + if (priv_ep->type != USB_ENDPOINT_XFER_ISOC && !priv_ep->dir) { > cdns3_set_register_bit(®s->tdl_from_trb, mask); > cdns3_set_register_bit(®s->tdl_beh, mask); > cdns3_set_register_bit(®s->tdl_beh2, mask); > @@ -2046,15 +2046,13 @@ int cdns3_ep_config(struct cdns3_endpoint *priv_ep, bool enable) > case USB_ENDPOINT_XFER_INT: > ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_INT); > > - if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) || > - priv_dev->dev_ver > DEV_VER_V2) > + if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir) > ep_cfg |= EP_CFG_TDL_CHK; > break; > case USB_ENDPOINT_XFER_BULK: > ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_BULK); > > - if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) || > - priv_dev->dev_ver > DEV_VER_V2) > + if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir) > ep_cfg |= EP_CFG_TDL_CHK; > break; > default: > -- Sanket & Pawel, please confirm this behaviour could apply for DEV_VER_V3, that is TDL_CHK can't be used for bulk in for DEV_VER_V3? -- Thanks, Peter Chen