From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD0EC2B9F2 for ; Sat, 22 May 2021 18:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6F3E61177 for ; Sat, 22 May 2021 18:48:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbhEVSuD (ORCPT ); Sat, 22 May 2021 14:50:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:55232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231254AbhEVSuD (ORCPT ); Sat, 22 May 2021 14:50:03 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38B1C60FDC; Sat, 22 May 2021 18:48:35 +0000 (UTC) Date: Sat, 22 May 2021 19:49:57 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Hans de Goede , Liam Girdwood , Mark Brown , Lars-Peter Clausen , Jeremy Cline , linux-iio , Charles Keepax , patches@opensource.cirrus.com, ALSA Development Mailing List Subject: Re: [PATCH 0/8] iio: accel: bmc150: Add support for yoga's with dual accelerometers with an ACPI HID of DUAL250E Message-ID: <20210522194957.3002406c@jic23-huawei> In-Reply-To: References: <20210521171418.393871-1-hdegoede@redhat.com> <20210522190138.1715b095@jic23-huawei> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, 22 May 2021 21:03:02 +0300 Andy Shevchenko wrote: > On Sat, May 22, 2021 at 9:00 PM Jonathan Cameron wrote: > > > On Fri, 21 May 2021 19:14:10 +0200 > > Hans de Goede wrote: > > > > Some 360 degree hinges (yoga) style 2-in-1 devices use 2 bmc150 accels > > > to allow the OS to determine the angle between the display and the base > > > of the device, so that the OS can determine if the 2-in-1 is in laptop > > > or in tablet-mode. > > > > > > We already support this setup on devices using a single ACPI node > > > with a HID of "BOSC0200" to describe both accelerometers. This patch > > > set extends this support to also support the same setup but then > > > using a HID of "DUAL250E". > > > > > > While testing this I found some crashes on rmmod, patches 1-2 > > > fix those patches, patch 3 does some refactoring and patch 4 > > > adds support for the "DUAL250E" HID. > > > > > > Unfortunately we need some more special handling though, which the > > > rest of the patches are for. > > > > > > On Windows both accelerometers are read (polled) by a special service > > > and this service calls a DSM (Device Specific Method), which in turn > > > translates the angles to one of laptop/tablet/tent/stand mode and then > > > notifies the EC about the new mode and the EC then enables or disables > > > the builtin keyboard and touchpad based in the mode. > > > > > > When the 2-in-1 is powered-on or resumed folded in tablet mode the > > > EC senses this independent of the DSM by using a HALL effect sensor > > > which senses that the keyboard has been folded away behind the display. > > > > > > At power-on or resume the EC disables the keyboard based on this and > > > the only way to get the keyboard to work after this is to call the > > > DSM to re-enable it (similar to how we also need to call a special > > > DSM in the kxcjk-1013.c accel driver to re-enable the keyboard). > > > > > > Patches 5-7 deal with the DSM mess and patch 8 adds labels to the > > > 2 accelerometers specifying which one is which. > > > > Given only thing I'm planning to do is tweak the line wrapping, I'm > > happy to pick this series up. > > > > The two fixes will slow things down a bit though as we should probably > > get those upstream this cycle. > > > > I'm going to leave this on list for a few days before I take anything > > though, to give others time to take a look. > > You are, guys, too fast :-) One day did seem a bit short for a series doing as much as this one :) > > I have few (minor) comments on a few patches, in general they are okay! > So, after settling on the comments, > Reviewed-by: Andy Shevchenko > for the entire series. > > Thanks, Hans, for doing this! > > > One side note, cc list includes a few random choices... Seems you've > > accidentally included alsa people as well as IIO ones. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D04C2B9F2 for ; Sat, 22 May 2021 18:49:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6585260FDC for ; Sat, 22 May 2021 18:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6585260FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D7F81663; Sat, 22 May 2021 20:48:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D7F81663 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621709378; bh=fEY5AgBXasvIfpoH/meG4ewkXRa2Ng2xSuN92ipfkIo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mrUL9wlS09Noft4k12h5jk8re3zFirt4CAN1X8REYjpxifYYt0NHf9UWzwhsHKPZQ NdRYyxzQe5VaIugrVzFCEBlQg5/uFYmDBBf8Zgjoll6+8TOp5dgG3TInO2tcd2uQ9Y L2gmGn7bCo+BdkXCu38D70Pw6yKeGYJaxCEVTxkw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 23515F8020B; Sat, 22 May 2021 20:48:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AB555F80217; Sat, 22 May 2021 20:48:46 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A2445F80153 for ; Sat, 22 May 2021 20:48:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A2445F80153 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38B1C60FDC; Sat, 22 May 2021 18:48:35 +0000 (UTC) Date: Sat, 22 May 2021 19:49:57 +0100 From: Jonathan Cameron To: Andy Shevchenko Subject: Re: [PATCH 0/8] iio: accel: bmc150: Add support for yoga's with dual accelerometers with an ACPI HID of DUAL250E Message-ID: <20210522194957.3002406c@jic23-huawei> In-Reply-To: References: <20210521171418.393871-1-hdegoede@redhat.com> <20210522190138.1715b095@jic23-huawei> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ALSA Development Mailing List , Lars-Peter Clausen , Charles Keepax , linux-iio , patches@opensource.cirrus.com, Liam Girdwood , Jeremy Cline , Hans de Goede , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 22 May 2021 21:03:02 +0300 Andy Shevchenko wrote: > On Sat, May 22, 2021 at 9:00 PM Jonathan Cameron wrote: > > > On Fri, 21 May 2021 19:14:10 +0200 > > Hans de Goede wrote: > > > > Some 360 degree hinges (yoga) style 2-in-1 devices use 2 bmc150 accels > > > to allow the OS to determine the angle between the display and the base > > > of the device, so that the OS can determine if the 2-in-1 is in laptop > > > or in tablet-mode. > > > > > > We already support this setup on devices using a single ACPI node > > > with a HID of "BOSC0200" to describe both accelerometers. This patch > > > set extends this support to also support the same setup but then > > > using a HID of "DUAL250E". > > > > > > While testing this I found some crashes on rmmod, patches 1-2 > > > fix those patches, patch 3 does some refactoring and patch 4 > > > adds support for the "DUAL250E" HID. > > > > > > Unfortunately we need some more special handling though, which the > > > rest of the patches are for. > > > > > > On Windows both accelerometers are read (polled) by a special service > > > and this service calls a DSM (Device Specific Method), which in turn > > > translates the angles to one of laptop/tablet/tent/stand mode and then > > > notifies the EC about the new mode and the EC then enables or disables > > > the builtin keyboard and touchpad based in the mode. > > > > > > When the 2-in-1 is powered-on or resumed folded in tablet mode the > > > EC senses this independent of the DSM by using a HALL effect sensor > > > which senses that the keyboard has been folded away behind the display. > > > > > > At power-on or resume the EC disables the keyboard based on this and > > > the only way to get the keyboard to work after this is to call the > > > DSM to re-enable it (similar to how we also need to call a special > > > DSM in the kxcjk-1013.c accel driver to re-enable the keyboard). > > > > > > Patches 5-7 deal with the DSM mess and patch 8 adds labels to the > > > 2 accelerometers specifying which one is which. > > > > Given only thing I'm planning to do is tweak the line wrapping, I'm > > happy to pick this series up. > > > > The two fixes will slow things down a bit though as we should probably > > get those upstream this cycle. > > > > I'm going to leave this on list for a few days before I take anything > > though, to give others time to take a look. > > You are, guys, too fast :-) One day did seem a bit short for a series doing as much as this one :) > > I have few (minor) comments on a few patches, in general they are okay! > So, after settling on the comments, > Reviewed-by: Andy Shevchenko > for the entire series. > > Thanks, Hans, for doing this! > > > One side note, cc list includes a few random choices... Seems you've > > accidentally included alsa people as well as IIO ones. > >