[PATCH] regulator: bd71815: add select to fix build

[PATCH] regulator: bd71815: add select to fix build

[Randy Dunlap]

Mend the Kconfig for REGULATOR_BD71815 to prevent build errors:

riscv32-linux-ld: drivers/regulator/bd71815-regulator.o: in function `.L0 ':
regulator.c:289: undefined reference to `rohm_regulator_set_dvs_levels'
riscv32-linux-ld: drivers/regulator/bd71815-regulator.c:370: undefined reference to `rohm_regulator_set_dvs_levels'

Fixes: 1aad39001e85 ("regulator: Support ROHM BD71815 regulators")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
---
 drivers/regulator/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20210521.orig/drivers/regulator/Kconfig
+++ linux-next-20210521/drivers/regulator/Kconfig
@@ -207,6 +207,7 @@ config REGULATOR_BD70528
 config REGULATOR_BD71815
 	tristate "ROHM BD71815 Power Regulator"
 	depends on MFD_ROHM_BD71828
+	select REGULATOR_ROHM
 	help
 	  This driver supports voltage regulators on ROHM BD71815 PMIC.
 	  This will enable support for the software controllable buck

Re: [PATCH] regulator: bd71815: add select to fix build

[Vaittinen, Matti]

On Sat, 2021-05-22 at 17:14 -0700, Randy Dunlap wrote:
> Mend the Kconfig for REGULATOR_BD71815 to prevent build errors:
> 
> riscv32-linux-ld: drivers/regulator/bd71815-regulator.o: in function
> `.L0 ':
> regulator.c:289: undefined reference to
> `rohm_regulator_set_dvs_levels'
> riscv32-linux-ld: drivers/regulator/bd71815-regulator.c:370:
> undefined reference to `rohm_regulator_set_dvs_levels'
> 
> Fixes: 1aad39001e85 ("regulator: Support ROHM BD71815 regulators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> ---
Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Thank you (again) for fixing this Randy.
I am quite sure this is not the first time I see this patch. As far as
I remember few fixes were sent during last development cycle by Randy
and Arnd - but I think they were not merged because commits they fixed
were not yet in regulator tree.

I could go through those and resend them if they are missing - but is
there a way to do that while giving the credit to original authors?

>  drivers/regulator/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/drivers/regulator/Kconfig
> +++ linux-next-20210521/drivers/regulator/Kconfig
> @@ -207,6 +207,7 @@ config REGULATOR_BD70528
>  config REGULATOR_BD71815
>  	tristate "ROHM BD71815 Power Regulator"
>  	depends on MFD_ROHM_BD71828
> +	select REGULATOR_ROHM
>  	help
>  	  This driver supports voltage regulators on ROHM BD71815 PMIC.
>  	  This will enable support for the software controllable buck

Re: [PATCH] regulator: bd71815: add select to fix build

[Mark Brown]

On Sat, 22 May 2021 17:14:27 -0700, Randy Dunlap wrote:
> Mend the Kconfig for REGULATOR_BD71815 to prevent build errors:
> 
> riscv32-linux-ld: drivers/regulator/bd71815-regulator.o: in function `.L0 ':
> regulator.c:289: undefined reference to `rohm_regulator_set_dvs_levels'
> riscv32-linux-ld: drivers/regulator/bd71815-regulator.c:370: undefined reference to `rohm_regulator_set_dvs_levels'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: bd71815: add select to fix build
      commit: 5ba3747dbc9ade2d22a8f5bff3c928cb41d35030

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark