From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6CDD517F for ; Sun, 23 May 2021 00:01:41 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ECB21042; Sat, 22 May 2021 17:01:40 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CADBD3F73B; Sat, 22 May 2021 17:01:38 -0700 (PDT) Date: Sun, 23 May 2021 01:01:24 +0100 From: Andre Przywara To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , Icenowy Zheng , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones Subject: Re: [PATCH v6 01/17] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Message-ID: <20210523010124.2fb56fa5@slackpad.fritz.box> In-Reply-To: <7ebfaef7-5cf2-e60c-99ef-4275c873e72d@sholland.org> References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-2-andre.przywara@arm.com> <7ebfaef7-5cf2-e60c-99ef-4275c873e72d@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 22 May 2021 09:46:23 -0500 Samuel Holland wrote: > On 5/19/21 5:41 AM, Andre Przywara wrote: > > The AXP305 PMIC used in AXP805 seems to be fully compatible to the > ^^^^^^^^^^^^^^ > Typo? Do you mean "used with the H616 SoC"? Ouch, yes. And even more embarrassingly Chen-Yu pointed that out already in the previous version. Same for the compatible string. Thanks for having a look! Cheers, Andre > > > AXP805 PMIC, so add the proper chain of compatible strings. > > > > Also at least on one board (Orangepi Zero2) there is no interrupt line > > connected to the CPU, so make the "interrupts" property optional. > > > > Signed-off-by: Andre Przywara > > --- > > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > > index 4991a6415796..4fd748101e3c 100644 > > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > > @@ -26,10 +26,10 @@ Required properties: > > * "x-powers,axp803" > > * "x-powers,axp806" > > * "x-powers,axp805", "x-powers,axp806" > > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" > ^^^^^^ > This should be x-powers,axp305. > > Regards, > Samuel > > > * "x-powers,axp809" > > * "x-powers,axp813" > > - reg: The I2C slave address or RSB hardware address for the AXP chip > > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > > - interrupt-controller: The PMIC has its own internal IRQs > > - #interrupt-cells: Should be set to 1 > > > > @@ -43,6 +43,7 @@ more information: > > AXP20x/LDO3: software-based implementation > > > > Optional properties: > > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > > AXP152/20X: range: 750-1875, Default: 1.5 MHz > > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC18C2B9F2 for ; Sun, 23 May 2021 00:04:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D48DC610A2 for ; Sun, 23 May 2021 00:04:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D48DC610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=slgp1kY1SUD8k7JPgknw+k9X/Bt2pBME8ncHqnT3AvU=; b=dpryRRClDYvuK/Azt736K/6otX 27aSPMbj7haolpoblYIWBy8BG1jiu9ciy1aZZQn7TBGu/tTSgVf62aOjbQFNM6CtRKY3VUU9uqfVx ZOKE00jl2+LX2D6pVWO23/weStFY28Q1jEYT+B9uYw0smYx5BtwFvG7TwL5NTCnMXTy40PrUqvDpf XB7h+reKMU3fdU+hPfJbLr6p1WJJcgZZzxPo5c9ojeFM0Uhfr5fPez8D3e50y7aMdFVrJ/pIZvV0u IE4vg2/Lq+5svGxvDAIAthq+wzOtkQTiOrDBKEcCpLWMgeMKSP7aUy1bw7ehtvbIZUmLxPFIAQ9KW xoMdQDqw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkbZ6-003Lj5-Ke; Sun, 23 May 2021 00:01:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkbZ0-003Lio-5R for linux-arm-kernel@desiato.infradead.org; Sun, 23 May 2021 00:01:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=DCip8eY2/TgqS2LenNdSL8E4vBXWaHpb92yc0gNZpCU=; b=Bng+kOKLWG6N3VaDnWu9p8yl6s mL/Yft+chFgXRE1CYfbdMvIeQsviJ1YEzuT8lX0XIOjvMjJCCTh8V3P459PSjhJzpCSyatRQ8ayXm 3Hkv4MrmgaMjW0i5ISu7PAMK6Zl1IPOz9g6NOVkYd5TDY042kZV4CWReAVD3/j+U3nc/d7UXYe4We uWR9RomCCIBfLnkQ0EfynCrwVrKpnQF2hAa4R7Az5dBjqKOEp9lj8ALnINep8LQ5z+7OClCF0WFld R26UdQTD+EHQVRo/QlugzNLiVILghKptjxF301fEQiYPIaecU7YnbUHLgHVvhmH6J73XhcI4hoSCx sC6ZaluA==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lkbYx-000FVY-6l for linux-arm-kernel@lists.infradead.org; Sun, 23 May 2021 00:01:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ECB21042; Sat, 22 May 2021 17:01:40 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CADBD3F73B; Sat, 22 May 2021 17:01:38 -0700 (PDT) Date: Sun, 23 May 2021 01:01:24 +0100 From: Andre Przywara To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , Icenowy Zheng , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones Subject: Re: [PATCH v6 01/17] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Message-ID: <20210523010124.2fb56fa5@slackpad.fritz.box> In-Reply-To: <7ebfaef7-5cf2-e60c-99ef-4275c873e72d@sholland.org> References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-2-andre.przywara@arm.com> <7ebfaef7-5cf2-e60c-99ef-4275c873e72d@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210522_170147_332465_951E69E9 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 22 May 2021 09:46:23 -0500 Samuel Holland wrote: > On 5/19/21 5:41 AM, Andre Przywara wrote: > > The AXP305 PMIC used in AXP805 seems to be fully compatible to the > ^^^^^^^^^^^^^^ > Typo? Do you mean "used with the H616 SoC"? Ouch, yes. And even more embarrassingly Chen-Yu pointed that out already in the previous version. Same for the compatible string. Thanks for having a look! Cheers, Andre > > > AXP805 PMIC, so add the proper chain of compatible strings. > > > > Also at least on one board (Orangepi Zero2) there is no interrupt line > > connected to the CPU, so make the "interrupts" property optional. > > > > Signed-off-by: Andre Przywara > > --- > > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > > index 4991a6415796..4fd748101e3c 100644 > > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > > @@ -26,10 +26,10 @@ Required properties: > > * "x-powers,axp803" > > * "x-powers,axp806" > > * "x-powers,axp805", "x-powers,axp806" > > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" > ^^^^^^ > This should be x-powers,axp305. > > Regards, > Samuel > > > * "x-powers,axp809" > > * "x-powers,axp813" > > - reg: The I2C slave address or RSB hardware address for the AXP chip > > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > > - interrupt-controller: The PMIC has its own internal IRQs > > - #interrupt-cells: Should be set to 1 > > > > @@ -43,6 +43,7 @@ more information: > > AXP20x/LDO3: software-based implementation > > > > Optional properties: > > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > > AXP152/20X: range: 750-1875, Default: 1.5 MHz > > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel