All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH v2 6/6] ALSA: pcm: Block the release until the system resume finishes
Date: Sun, 23 May 2021 11:09:20 +0200	[thread overview]
Message-ID: <20210523090920.15345-7-tiwai@suse.de> (raw)
In-Reply-To: <20210523090920.15345-1-tiwai@suse.de>

The normal PCM operations are already blocked during the card power
off state in the PCM common ioctl handler, but the release isn't
covered.  As the PCM stream release may also access the hardware,
let's block the release until the card power turns on.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/pcm_native.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 82f80d0c068b..11acea02bc74 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -2799,6 +2799,10 @@ static int snd_pcm_release(struct inode *inode, struct file *file)
 	if (snd_BUG_ON(!substream))
 		return -ENXIO;
 	pcm = substream->pcm;
+
+	/* block until the device gets woken up as it may touch the hardware */
+	snd_power_wait(pcm->card);
+
 	mutex_lock(&pcm->open_mutex);
 	snd_pcm_release_substream(substream);
 	kfree(pcm_file);
-- 
2.26.2


  parent reply	other threads:[~2021-05-23  9:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23  9:09 [PATCH v2 0/6] ALSA: Prep work for PCI rescan support Takashi Iwai
2021-05-23  9:09 ` [PATCH v2 1/6] ALSA: core: Use READ_ONCE() / WRITE_ONCE() for power state change Takashi Iwai
2021-05-23  9:09 ` [PATCH v2 2/6] ALSA: control: Track in-flight control read/write/tlv accesses Takashi Iwai
2021-05-23  9:09 ` [PATCH v2 3/6] ALSA: control: Drop superfluous snd_power_wait() calls Takashi Iwai
2021-05-23  9:09 ` [PATCH v2 4/6] ALSA: control: Minor optimization for SNDRV_CTL_IOCTL_POWER_STATE Takashi Iwai
2021-05-23  9:09 ` [PATCH v2 5/6] ALSA: Drop superfluous argument from snd_power_wait() Takashi Iwai
2021-05-24  8:39   ` Mark Brown
2021-05-23  9:09 ` Takashi Iwai [this message]
2021-05-24  9:32 ` [PATCH v2 0/6] ALSA: Prep work for PCI rescan support Jaroslav Kysela
2021-05-25  6:56 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210523090920.15345-7-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.