From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, hare@suse.de
Subject: [PATCH v19 00/45] sg: add v4 interface
Date: Sun, 23 May 2021 21:01:02 -0400 [thread overview]
Message-ID: <20210524010147.94845-1-dgilbert@interlog.com> (raw)
This patchset is the first stage of a two stage rewrite of the scsi
generic (sg) driver. The main goal of the first stage is to introduce
the sg v4 interface that uses 'struct sg_io_v4' as well as keeping and
modernizing the sg v3 interface (based on 'struct sg_io_hdr'). The
async interface formerly requiring the use of write() and read()
system calls now have ioctl(SG_IOSUBMIT) and ioctl(SG_IORECEIVE)
replacements.
For documentation see either url:
https://sg.danny.cz/sg/sg_v40.html
https://doug-gilbert.github.io/sg_v40.html
This patchset is against Martin Petersen's 5.14/scsi-queue branch.
Changes since v18 (sent to linux-scsi list on 20210407)
- a request queue's QUEUE_FLAG_POLL flag can be cleared via
sysfs, overriding the ability to use blk_poll() even when the
associated LLD allows it. Check that flag and, only when it
is set and the sg user gives SGV4_FLAG_HIPRI, set REQ_HIPRI
on a request.
- simplify the functions supporting ioctl(SG_SET_RESERVED_SIZE)
- replace blk_rq_append_bio() calls with the simpler
blk_rq_bio_prep() calls
[see lk: a4fe2d3afe3ce77edeadb567c0d0a8d102c6b159]
- rebase on 5.14/scsi-queue branch [lk 5.13-0-rc1]
- unchecked_isa_dma removed
- BIO_MAX_PAGES renamed to BIO_MAX_VECS
Changes since v17 (sent to linux-scsi list on 20210407)
- make clearer distinction between user pollable (i.e. async)
requests and (user) non-pollable requests (e.g. those injected
with ioctl(SG_IO), IOWs sync requests)
- fix crash is sg_start_req() when blk_get_request() yields an
error (e.g. -EAGAIN when low on resources)
- sg_finish_scsi_blk_rq(): remove now_zero variable as suggested
by Hannes R.
- change deprecation warning url reference from http to https
Changes since v16 (sent to linux-scsi list on 20210208)
- sg_start_req() fix double free on error path [KASAN]
- sg_rq_map_kern() fix uninitialized variable [coverity]
- sg_add_sfp() fix use after free [coverity]
- sg_remove_sfp_usercontext(): remove pointless NULL check [coverity]
- fix misuse of WARN_ONCE in sg_rq_end_io_usercontext() [D. Carpenter]
- remove unused error checks: tracking blk_put_request() calls and
multiple SG_XA_RQ_FREE calls
- hipri: as blk_poll() can return > 0 for requests other than the one
that is being checked for, need to re-check that request is ready
- rebased on MKP's 5.13/scsi-queue
Changes since v15 (sent to linux-scsi list on 20210125)
- tweak state machine which sets INFLIGHT state _before_
blk_execute_rq_nowait() is called. Add a bit flag that indicates
the logic flow has returned from that call. This guards against
blk_poll() being called before the block layer has really
launched the request.
- fix bug clearing SG_FFD_HIPRI_SEEN bit as
atomic_dec_and_test() returns true when the post-decrement value
is zero, the opposite of what a C conditional does.
Changes since v14 and earlier
- see: the v18 patchset sent to linux-scsi on 20210427
Douglas Gilbert (45):
sg: move functions around
sg: remove typedefs, type+formatting cleanup
sg: sg_log and is_enabled
sg: rework sg_poll(), minor changes
sg: bitops in sg_device
sg: make open count an atomic
sg: move header to uapi section
sg: speed sg_poll and sg_get_num_waiting
sg: sg_allow_if_err_recovery and renames
sg: improve naming
sg: change rwlock to spinlock
sg: ioctl handling
sg: split sg_read
sg: sg_common_write add structure for arguments
sg: rework sg_vma_fault
sg: rework sg_mmap
sg: replace sg_allow_access
sg: rework scatter gather handling
sg: introduce request state machine
sg: sg_find_srp_by_id
sg: sg_fill_request_element
sg: printk change %p to %pK
sg: xarray for fds in device
sg: xarray for reqs in fd
sg: replace rq array with xarray
sg: sense buffer rework
sg: add sg v4 interface support
sg: rework debug info
sg: add 8 byte SCSI LUN to sg_scsi_id
sg: expand sg_comm_wr_t
sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls
sg: add some __must_hold macros
sg: move procfs objects to avoid forward decls
sg: protect multiple receivers
sg: first debugfs support
sg: rework mmap support
sg: defang allow_dio
sg: warn v3 write system call users
sg: add mmap_sz tracking
sg: remove rcv_done request state
sg: track lowest inactive and await indexes
sg: remove unit attention check for device changed
sg: no_dxfer: move to/from kernel buffers
sg: add blk_poll support
sg: bump version to 4.0.12
drivers/scsi/sg.c | 5353 +++++++++++++++++++++++++++-------------
include/scsi/sg.h | 273 +-
include/uapi/scsi/sg.h | 375 +++
3 files changed, 4065 insertions(+), 1936 deletions(-)
create mode 100644 include/uapi/scsi/sg.h
--
2.25.1
next reply other threads:[~2021-05-24 1:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 1:01 Douglas Gilbert [this message]
2021-05-24 1:01 ` [PATCH v19 01/45] sg: move functions around Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 02/45] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 03/45] sg: sg_log and is_enabled Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 04/45] sg: rework sg_poll(), minor changes Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 05/45] sg: bitops in sg_device Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 06/45] sg: make open count an atomic Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 07/45] sg: move header to uapi section Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 08/45] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 09/45] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 10/45] sg: improve naming Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 11/45] sg: change rwlock to spinlock Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 12/45] sg: ioctl handling Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 13/45] sg: split sg_read Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 14/45] sg: sg_common_write add structure for arguments Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 15/45] sg: rework sg_vma_fault Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 16/45] sg: rework sg_mmap Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 17/45] sg: replace sg_allow_access Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 18/45] sg: rework scatter gather handling Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 19/45] sg: introduce request state machine Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 20/45] sg: sg_find_srp_by_id Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 21/45] sg: sg_fill_request_element Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 22/45] sg: printk change %p to %pK Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 23/45] sg: xarray for fds in device Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 24/45] sg: xarray for reqs in fd Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 25/45] sg: replace rq array with xarray Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 26/45] sg: sense buffer rework Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 27/45] sg: add sg v4 interface support Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 28/45] sg: rework debug info Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 29/45] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 30/45] sg: expand sg_comm_wr_t Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 31/45] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 32/45] sg: add some __must_hold macros Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 33/45] sg: move procfs objects to avoid forward decls Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 34/45] sg: protect multiple receivers Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 35/45] sg: first debugfs support Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 36/45] sg: rework mmap support Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 37/45] sg: defang allow_dio Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 38/45] sg: warn v3 write system call users Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 39/45] sg: add mmap_sz tracking Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 40/45] sg: remove rcv_done request state Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 41/45] sg: track lowest inactive and await indexes Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 42/45] sg: remove unit attention check for device changed Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 43/45] sg: no_dxfer: move to/from kernel buffers Douglas Gilbert
2021-05-24 1:01 ` [PATCH v19 44/45] sg: add blk_poll support Douglas Gilbert
2021-05-25 8:36 ` Hannes Reinecke
2021-05-24 1:01 ` [PATCH v19 45/45] sg: bump version to 4.0.12 Douglas Gilbert
2021-05-25 8:36 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524010147.94845-1-dgilbert@interlog.com \
--to=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.