From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55DDBC04FF3 for ; Mon, 24 May 2021 18:12:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2108B61406 for ; Mon, 24 May 2021 18:12:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2108B61406 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=BKOneyEzVkYWpvKVMHIIW+cj/osSeqZH6L5WrR2S+zI=; b=z4T1lF/mIeMn69/pvZ19K+zcVn jmVqDBped//7ftDmmNq8/lQFvkXpuULqor11ZkGPMRjAEDghza5r2ji1qL08rMt1p2yG9QOR8WAfi DdAgLhI42SGAuW4OxqOINETYGoGQcKnoRSyQIAqhNNtWztHCJIsXKA0iu8kWMIutBmCeG0ldYpQKs Ew8uORdlJBad1wKLpiRZvmfFJ6wykZ7opkmqJxMLB6waurxNxROjNboHhM2l9la520wgk6iIeJXm3 Ln1B+dq6ymEwBH8G0Xx9uipVjyKlTY0qzktBQ6gSSJk6Mw+1AWfKo5WgrVFwINbU9Od7+PEKtkZGD FiIV4irQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llF1g-001P1y-Mg; Mon, 24 May 2021 18:10:06 +0000 Received: from mail-qk1-x749.google.com ([2607:f8b0:4864:20::749]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll5yi-000lrK-Sg for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 08:30:26 +0000 Received: by mail-qk1-x749.google.com with SMTP id n3-20020a378b030000b02903a624ca95adso8862731qkd.17 for ; Mon, 24 May 2021 01:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=6CjxhVQT4fcLHx09RilT7W95JHz4NAcMGt19k9LWXko=; b=fTwom+vJznJs2oND7ApG9ekHPeHWQQpwMcdJj1s4TV8uKSmreVRTupDGGAn/1A0TNQ S+y+BabvsY0M8//44pB0sCV4m4a8rs7Jno7ZRMsFr1aMK1bV2Pbo5/ujeLKZRdcR0tZ5 EPFDG7bk1fv7CwDw0QdqgvZAc8Ud86tdHFRWEeOX8Q2+SMWxhc33/cuB07+ooN+rXBN2 0mfkkxdyBIiP4U1Fztr0Tz2UAiNKvCLnH9x+jQv+RHC4DN5K05paheoCpOPh2w/wqb1t 1acC9GoD47J2PuuU7YNF5XcQcAVDy4GcdmaacaxNDLCsn2IHiaOHZOsYDvbjSbP58gBP ESoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=6CjxhVQT4fcLHx09RilT7W95JHz4NAcMGt19k9LWXko=; b=ZE+jt02o3DwsVB2aH9bcO3CamX8moxGk/yI9YOWziij0vTe0c2Dll1wBsVOEup3xVb wPtIX0p5b9w5pVvc3U63EuZ2K55rYcMr1oCOkd9L5SfqAi27ZCJ7nklZLJm0P0vZtvmV xJE3d34QgBjRlgrKhuEaYSqoq2fdzckgPzGerVe6bxu5anDm0LbXdkH6ceKZXJT12otN +cAJ0hZEvfcXHj9TdUjNa/gROsf2xF965Yb6xfcf7/cSzyh3w8BkRPziKZ01yNI+EMYi Ni46Lrorjm1M2JmRW/DU2gwYVMX3pF/QkzBY5PQ35N/qSSLow8KFdHRIrikOLM76581z lXTg== X-Gm-Message-State: AOAM532AQ8cBpcK9lDpV2pzaoQw7QBLvc4ZwumKn13r04RwZeSQnlQRF ISIMNh3CHKV2mZPOizmJuriC6NhZPmE9sTOKFlNBWMP/Fpg77JTZ/NjGIg5H7kIyH65axdwj1Ul oBwEHq2WLJkny+qyV67hEsVujCRz0entlbZ98VfIN80j550vzGjrMCtmZkjP3guphZHdJsn+aH7 7W+Q== X-Google-Smtp-Source: ABdhPJyVjcX7zPqt/LPAbP6HslDlwhvGUdKwxdAjtF5O8ZmJtWzF4plVthdhOyICCAVQyc/lQd7a6wLHFg== X-Received: from tabba.c.googlers.com ([fda3:e722:ac3:10:28:9cb1:c0a8:482]) (user=tabba job=sendgmr) by 2002:a0c:ecc8:: with SMTP id o8mr29012946qvq.23.1621845022467; Mon, 24 May 2021 01:30:22 -0700 (PDT) Date: Mon, 24 May 2021 09:29:52 +0100 In-Reply-To: <20210524083001.2586635-1-tabba@google.com> Message-Id: <20210524083001.2586635-10-tabba@google.com> Mime-Version: 1.0 References: <20210524083001.2586635-1-tabba@google.com> X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog Subject: [PATCH v4 09/18] arm64: Fix comments to refer to correct function __flush_icache_range From: Fuad Tabba To: linux-arm-kernel@lists.infradead.org Cc: will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, maz@kernel.org, ardb@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, robin.murphy@arm.com, tabba@google.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_013024_946481_A308FDE7 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Many comments refer to the function flush_icache_range, where the intent is in fact __flush_icache_range. Fix these comments to refer to the intended function. That's probably due to commit 3b8c9f1cdfc506e9 ("arm64: IPI each CPU after invalidating the I-cache for kernel mappings"), which renamed flush_icache_range() to __flush_icache_range() and added a wrapper. No functional change intended. Acked-by: Mark Rutland Signed-off-by: Fuad Tabba --- arch/arm64/kernel/hibernate-asm.S | 4 ++-- arch/arm64/mm/cache.S | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/hibernate-asm.S b/arch/arm64/kernel/hibernate-asm.S index 0ed2f72a6b94..ef2ab7caf815 100644 --- a/arch/arm64/kernel/hibernate-asm.S +++ b/arch/arm64/kernel/hibernate-asm.S @@ -45,7 +45,7 @@ * Because this code has to be copied to a 'safe' page, it can't call out to * other functions by PC-relative address. Also remember that it may be * mid-way through over-writing other functions. For this reason it contains - * code from flush_icache_range() and uses the copy_page() macro. + * code from __flush_icache_range() and uses the copy_page() macro. * * This 'safe' page is mapped via ttbr0, and executed from there. This function * switches to a copy of the linear map in ttbr1, performs the restore, then @@ -87,7 +87,7 @@ SYM_CODE_START(swsusp_arch_suspend_exit) copy_page x0, x1, x2, x3, x4, x5, x6, x7, x8, x9 add x1, x10, #PAGE_SIZE - /* Clean the copied page to PoU - based on flush_icache_range() */ + /* Clean the copied page to PoU - based on __flush_icache_range() */ raw_dcache_line_size x2, x3 sub x3, x2, #1 bic x4, x10, x3 diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S index 14eac9d76d57..910ae8f6a389 100644 --- a/arch/arm64/mm/cache.S +++ b/arch/arm64/mm/cache.S @@ -43,7 +43,7 @@ alternative_else_nop_endif .endm /* - * flush_icache_range(start,end) + * __flush_icache_range(start,end) * * Ensure that the I and D caches are coherent within specified region. * This is typically used when code has been written to a memory region, -- 2.31.1.818.g46aad6cb9e-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel