From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641B02FAE for ; Mon, 24 May 2021 12:08:46 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 279FD15FA; Mon, 24 May 2021 08:08:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 24 May 2021 08:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=KuYrmIVCiLVbSSTdfz4ZTMoPZUe vG5TsxBnT23F3ZtI=; b=VY3TRQAGB0UhY9VLyddLVz+IvpoHtPjcngvTgKLIcEi uuQGdI+ldIF0njPwa7GstT9j793TjzmhDvFzCzEdx0mXw4E5ONfI3CvQab9MndbJ 2j4ZemUAdZBPZ6M4V+Vp2c5fUZZ7ITC3gQalja/LRTi/5QgAdQzos0+er8dL86hx IXbTR1i70BBjR3YXzViHjzxFGZQ1/KYn5iGkPoY2ZnvEew7nk1C72YcaOftAzKF5 7/nfNeYppr/DxeTWgewHJ5a/ddJNcmAA2/HRblqIOgIzpS99HEK/DLyRhT4W1Rc7 sKAD9lfoE/xmas58MfK3R+yE63n3X32UIbTjg4O2V2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KuYrmI VCiLVbSSTdfz4ZTMoPZUevG5TsxBnT23F3ZtI=; b=jEbiZcEM/wdt6YhmQUAb5u uFGA+dO8AHnmT04TSkF/5BZIS11Tr7cqaSIuorT/9ynk3bMTk8JS+MuXWFs9Itci VoFL0Rtl+nrqoY9OaJKqDVWjSnsD81E77HIfZ9H/7gpC6dLNdD+WwG3fKK6pInmW EG3yMurED35jNYa6Z/sWAmKJTKnTQP8YixdkQD6xwYN4wc3rgvXOt3kcKMtdUTcU aAyVmNKiPpySK+Jx2Mc/e7ZXSjIjmDnPAgqN+IeB1qb/hObGfelwINQ5gzd0gh7A xcZrnZPkug6ACe615JzEFo5WyKswwZ1GzQZ7xbWmvKWZu69upPnKZSQ1x7Em/yoQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 08:08:43 -0400 (EDT) Date: Mon, 24 May 2021 14:08:41 +0200 From: Maxime Ripard To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Liam Girdwood , Mark Brown , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Message-ID: <20210524120841.bj6fohyxrhpp3i2u@gilmour> References: <20210430035859.3487-1-samuel@sholland.org> <20210430035859.3487-8-samuel@sholland.org> <20210507080942.lxysxdbrviv3ys7m@gilmour> <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vdqks5dqd2amw37s" Content-Disposition: inline In-Reply-To: <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> --vdqks5dqd2amw37s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 09, 2021 at 08:54:36PM -0500, Samuel Holland wrote: > On 5/7/21 3:09 AM, Maxime Ripard wrote: > > Hi, > >=20 > > On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote: > >> From: Arnaud Ferraris > >> > >> Add the "PinePhone" name to the sound card: this will make > >> upstreaming an ALSA UCM config easier as we can use a unique name. > >> > >> It also avoids an issue where the default card name is truncated. > >> > >> Signed-off-by: Arnaud Ferraris > >> [Samuel: Split out change, updated commit message] > >> Signed-off-by: Samuel Holland > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b= /arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > >> index 51cbfdc12936..02712f85f6bd 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi g> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > >> @@ -433,6 +433,7 @@ ®_rtc_ldo { > >> =20 > >> &sound { > >> status =3D "okay"; > >> + simple-audio-card,name =3D "PinePhone"; > >> simple-audio-card,aux-devs =3D <&codec_analog>, <&speaker_amp>; > >> simple-audio-card,widgets =3D "Microphone", "Headset Microphone", > >> "Microphone", "Internal Microphone", > >=20 > > Isn't that reported to the userspace? I'm not sure we can just change it > > without breaking it. >=20 > Yes, this is seen by userspace. >=20 > Ideally, we would add this property with a unique value when enabling > audio for any board, but as you mention, it would be a breaking change > to add those properties now. >=20 > In practice, all distributions supporting the PinePhone are already > carrying this patch, because the ALSA setup needed for the PinePhone is > very different from most other boards. So it would be similarly breaking > for them (and their users) to drop this patch. Ack :) Since no one else complained, I merged this patch too Thanks! Maxime --vdqks5dqd2amw37s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKuXSQAKCRDj7w1vZxhR xQeqAQDH3EOIl439YaZCsAopMTIIpwmTqAD047YX53owNIwA8gEAr3PT+rxlJ51k fqTfXb4QIVbfh/RtIUWCrNx6tU+MGAw= =V5lB -----END PGP SIGNATURE----- --vdqks5dqd2amw37s-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D835C04FF3 for ; Mon, 24 May 2021 12:09:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 387E6613B6 for ; Mon, 24 May 2021 12:09:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 387E6613B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C84061697; Mon, 24 May 2021 14:09:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C84061697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621858190; bh=TrAeQ1+Hu7z8acma0Y+agrS27l4spK/NLy2PnnHDRSc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eHiEovuuDa46sSI9JFndX38cGX3a6WesE13MT0O4zfQ4LgE+JJvM4OfYHPVOK+1kx vXqaaJ9FlOvmM9KsG04+geQfo7bHK01x2q84oQBPVL0V/255RMnCyO2RlMu9yOlv3j dBYH0Th0IcUUzK8gi87WU4bMKH8aQ9MhoIWC0KAc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 687EEF8021D; Mon, 24 May 2021 14:09:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 22848F8022B; Mon, 24 May 2021 14:08:59 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BBEBEF80149 for ; Mon, 24 May 2021 14:08:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BBEBEF80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="VY3TRQAG"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jEbiZcEM" Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 279FD15FA; Mon, 24 May 2021 08:08:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 24 May 2021 08:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=KuYrmIVCiLVbSSTdfz4ZTMoPZUe vG5TsxBnT23F3ZtI=; b=VY3TRQAGB0UhY9VLyddLVz+IvpoHtPjcngvTgKLIcEi uuQGdI+ldIF0njPwa7GstT9j793TjzmhDvFzCzEdx0mXw4E5ONfI3CvQab9MndbJ 2j4ZemUAdZBPZ6M4V+Vp2c5fUZZ7ITC3gQalja/LRTi/5QgAdQzos0+er8dL86hx IXbTR1i70BBjR3YXzViHjzxFGZQ1/KYn5iGkPoY2ZnvEew7nk1C72YcaOftAzKF5 7/nfNeYppr/DxeTWgewHJ5a/ddJNcmAA2/HRblqIOgIzpS99HEK/DLyRhT4W1Rc7 sKAD9lfoE/xmas58MfK3R+yE63n3X32UIbTjg4O2V2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KuYrmI VCiLVbSSTdfz4ZTMoPZUevG5TsxBnT23F3ZtI=; b=jEbiZcEM/wdt6YhmQUAb5u uFGA+dO8AHnmT04TSkF/5BZIS11Tr7cqaSIuorT/9ynk3bMTk8JS+MuXWFs9Itci VoFL0Rtl+nrqoY9OaJKqDVWjSnsD81E77HIfZ9H/7gpC6dLNdD+WwG3fKK6pInmW EG3yMurED35jNYa6Z/sWAmKJTKnTQP8YixdkQD6xwYN4wc3rgvXOt3kcKMtdUTcU aAyVmNKiPpySK+Jx2Mc/e7ZXSjIjmDnPAgqN+IeB1qb/hObGfelwINQ5gzd0gh7A xcZrnZPkug6ACe615JzEFo5WyKswwZ1GzQZ7xbWmvKWZu69upPnKZSQ1x7Em/yoQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 08:08:43 -0400 (EDT) Date: Mon, 24 May 2021 14:08:41 +0200 From: Maxime Ripard To: Samuel Holland Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Message-ID: <20210524120841.bj6fohyxrhpp3i2u@gilmour> References: <20210430035859.3487-1-samuel@sholland.org> <20210430035859.3487-8-samuel@sholland.org> <20210507080942.lxysxdbrviv3ys7m@gilmour> <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vdqks5dqd2amw37s" Content-Disposition: inline In-Reply-To: <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Rob Herring , Liam Girdwood , Chen-Yu Tsai , Mark Brown , Arnaud Ferraris , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --vdqks5dqd2amw37s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 09, 2021 at 08:54:36PM -0500, Samuel Holland wrote: > On 5/7/21 3:09 AM, Maxime Ripard wrote: > > Hi, > >=20 > > On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote: > >> From: Arnaud Ferraris > >> > >> Add the "PinePhone" name to the sound card: this will make > >> upstreaming an ALSA UCM config easier as we can use a unique name. > >> > >> It also avoids an issue where the default card name is truncated. > >> > >> Signed-off-by: Arnaud Ferraris > >> [Samuel: Split out change, updated commit message] > >> Signed-off-by: Samuel Holland > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b= /arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > >> index 51cbfdc12936..02712f85f6bd 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi g> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > >> @@ -433,6 +433,7 @@ ®_rtc_ldo { > >> =20 > >> &sound { > >> status =3D "okay"; > >> + simple-audio-card,name =3D "PinePhone"; > >> simple-audio-card,aux-devs =3D <&codec_analog>, <&speaker_amp>; > >> simple-audio-card,widgets =3D "Microphone", "Headset Microphone", > >> "Microphone", "Internal Microphone", > >=20 > > Isn't that reported to the userspace? I'm not sure we can just change it > > without breaking it. >=20 > Yes, this is seen by userspace. >=20 > Ideally, we would add this property with a unique value when enabling > audio for any board, but as you mention, it would be a breaking change > to add those properties now. >=20 > In practice, all distributions supporting the PinePhone are already > carrying this patch, because the ALSA setup needed for the PinePhone is > very different from most other boards. So it would be similarly breaking > for them (and their users) to drop this patch. Ack :) Since no one else complained, I merged this patch too Thanks! Maxime --vdqks5dqd2amw37s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKuXSQAKCRDj7w1vZxhR xQeqAQDH3EOIl439YaZCsAopMTIIpwmTqAD047YX53owNIwA8gEAr3PT+rxlJ51k fqTfXb4QIVbfh/RtIUWCrNx6tU+MGAw= =V5lB -----END PGP SIGNATURE----- --vdqks5dqd2amw37s-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6FEC2B9F7 for ; Mon, 24 May 2021 22:58:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D2AA613D2 for ; Mon, 24 May 2021 22:58:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D2AA613D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l3NNBdX3wOOhGXl5eMQp5F2KAnvBfzLf7YA143Mzxxg=; b=BT/gksRLRTz9iCw8fNzTxekee hmahghYQUTebpTgcajvEkkFrLdYDA03z8CdcmMcEFArQ2ujw/xma0PvXqvCmsVjrTPZinBBhvRB1D WPI6DfwgWeW1FG7ZpNZ9VXJmjNm4SjANOw+t+3TXGE7CVWZLIBU2lFTlW36eiNc/zFz5cOvaD7eMT Y7kYvFclhyOapxvYyPtsb2IoMryZqnk9fJuG8RX7gE1oW6AKS393XhcFAOTk1O265UZ9UXZVlvSFM vA1AVG+PqacdeKxojwVbyGzwOhHiqgO0H5UgpZrVvQ5EdQmqIYx4QadDWrWAMDToe3DqxrlMVs5MH cH4DZYB8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llJUH-002EZd-2P; Mon, 24 May 2021 22:55:53 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll9O6-000tv9-3v for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 12:08:51 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 279FD15FA; Mon, 24 May 2021 08:08:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 24 May 2021 08:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=KuYrmIVCiLVbSSTdfz4ZTMoPZUe vG5TsxBnT23F3ZtI=; b=VY3TRQAGB0UhY9VLyddLVz+IvpoHtPjcngvTgKLIcEi uuQGdI+ldIF0njPwa7GstT9j793TjzmhDvFzCzEdx0mXw4E5ONfI3CvQab9MndbJ 2j4ZemUAdZBPZ6M4V+Vp2c5fUZZ7ITC3gQalja/LRTi/5QgAdQzos0+er8dL86hx IXbTR1i70BBjR3YXzViHjzxFGZQ1/KYn5iGkPoY2ZnvEew7nk1C72YcaOftAzKF5 7/nfNeYppr/DxeTWgewHJ5a/ddJNcmAA2/HRblqIOgIzpS99HEK/DLyRhT4W1Rc7 sKAD9lfoE/xmas58MfK3R+yE63n3X32UIbTjg4O2V2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KuYrmI VCiLVbSSTdfz4ZTMoPZUevG5TsxBnT23F3ZtI=; b=jEbiZcEM/wdt6YhmQUAb5u uFGA+dO8AHnmT04TSkF/5BZIS11Tr7cqaSIuorT/9ynk3bMTk8JS+MuXWFs9Itci VoFL0Rtl+nrqoY9OaJKqDVWjSnsD81E77HIfZ9H/7gpC6dLNdD+WwG3fKK6pInmW EG3yMurED35jNYa6Z/sWAmKJTKnTQP8YixdkQD6xwYN4wc3rgvXOt3kcKMtdUTcU aAyVmNKiPpySK+Jx2Mc/e7ZXSjIjmDnPAgqN+IeB1qb/hObGfelwINQ5gzd0gh7A xcZrnZPkug6ACe615JzEFo5WyKswwZ1GzQZ7xbWmvKWZu69upPnKZSQ1x7Em/yoQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 08:08:43 -0400 (EDT) Date: Mon, 24 May 2021 14:08:41 +0200 From: Maxime Ripard To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Liam Girdwood , Mark Brown , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Message-ID: <20210524120841.bj6fohyxrhpp3i2u@gilmour> References: <20210430035859.3487-1-samuel@sholland.org> <20210430035859.3487-8-samuel@sholland.org> <20210507080942.lxysxdbrviv3ys7m@gilmour> <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> MIME-Version: 1.0 In-Reply-To: <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_050850_206586_33751A1E X-CRM114-Status: GOOD ( 27.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7593767067388750274==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7593767067388750274== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vdqks5dqd2amw37s" Content-Disposition: inline --vdqks5dqd2amw37s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 09, 2021 at 08:54:36PM -0500, Samuel Holland wrote: > On 5/7/21 3:09 AM, Maxime Ripard wrote: > > Hi, > >=20 > > On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote: > >> From: Arnaud Ferraris > >> > >> Add the "PinePhone" name to the sound card: this will make > >> upstreaming an ALSA UCM config easier as we can use a unique name. > >> > >> It also avoids an issue where the default card name is truncated. > >> > >> Signed-off-by: Arnaud Ferraris > >> [Samuel: Split out change, updated commit message] > >> Signed-off-by: Samuel Holland > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b= /arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > >> index 51cbfdc12936..02712f85f6bd 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi g> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > >> @@ -433,6 +433,7 @@ ®_rtc_ldo { > >> =20 > >> &sound { > >> status =3D "okay"; > >> + simple-audio-card,name =3D "PinePhone"; > >> simple-audio-card,aux-devs =3D <&codec_analog>, <&speaker_amp>; > >> simple-audio-card,widgets =3D "Microphone", "Headset Microphone", > >> "Microphone", "Internal Microphone", > >=20 > > Isn't that reported to the userspace? I'm not sure we can just change it > > without breaking it. >=20 > Yes, this is seen by userspace. >=20 > Ideally, we would add this property with a unique value when enabling > audio for any board, but as you mention, it would be a breaking change > to add those properties now. >=20 > In practice, all distributions supporting the PinePhone are already > carrying this patch, because the ALSA setup needed for the PinePhone is > very different from most other boards. So it would be similarly breaking > for them (and their users) to drop this patch. Ack :) Since no one else complained, I merged this patch too Thanks! Maxime --vdqks5dqd2amw37s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKuXSQAKCRDj7w1vZxhR xQeqAQDH3EOIl439YaZCsAopMTIIpwmTqAD047YX53owNIwA8gEAr3PT+rxlJ51k fqTfXb4QIVbfh/RtIUWCrNx6tU+MGAw= =V5lB -----END PGP SIGNATURE----- --vdqks5dqd2amw37s-- --===============7593767067388750274== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7593767067388750274==--