From: Alex Williamson <alex.williamson@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>,
Eric Auger <eric.auger@redhat.com>
Subject: Re: [PATCH] vfio/pci: zap_vma_ptes() needs MMU
Date: Mon, 24 May 2021 13:46:50 -0600 [thread overview]
Message-ID: <20210524134650.01ed417b@x1.home.shazbot.org> (raw)
In-Reply-To: <20210515190856.2130-1-rdunlap@infradead.org>
On Sat, 15 May 2021 12:08:56 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> zap_vma_ptes() is only available when CONFIG_MMU is set/enabled.
> Without CONFIG_MMU, vfio_pci.o has build errors, so make
> VFIO_PCI depend on MMU.
>
> riscv64-linux-ld: drivers/vfio/pci/vfio_pci.o: in function `vfio_pci_mmap_open':
> vfio_pci.c:(.text+0x1ec): undefined reference to `zap_vma_ptes'
> riscv64-linux-ld: drivers/vfio/pci/vfio_pci.o: in function `.L0 ':
> vfio_pci.c:(.text+0x165c): undefined reference to `zap_vma_ptes'
>
> Fixes: 89e1f7d4c66d ("vfio: Add PCI device driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: kvm@vger.kernel.org
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> ---
> drivers/vfio/pci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210514.orig/drivers/vfio/pci/Kconfig
> +++ linux-next-20210514/drivers/vfio/pci/Kconfig
> @@ -2,6 +2,7 @@
> config VFIO_PCI
> tristate "VFIO support for PCI devices"
> depends on VFIO && PCI && EVENTFD
> + depends on MMU
> select VFIO_VIRQFD
> select IRQ_BYPASS_MANAGER
> help
Yes, these !MMU configs are getting annoying and I don't know of any
demand for vfio in them. I suspect we were ok with !MMU until
11c4cd07ba11 though, that's where we added zap_vma_ptes usage. I
updated the Fixes: tag but I suspect either case would reach the same
set of stable trees. Applied to vfio for-linus branch for v5.13.
Thanks!
Alex
prev parent reply other threads:[~2021-05-24 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 19:08 [PATCH] vfio/pci: zap_vma_ptes() needs MMU Randy Dunlap
2021-05-24 19:46 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524134650.01ed417b@x1.home.shazbot.org \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.